tor-browser-build merge requestshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests2023-03-27T10:29:06Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/690Bug 40827: MAR generation uses (mostly) hard-coded MAR update channel2023-03-27T10:29:06ZrichardBug 40827: MAR generation uses (mostly) hard-coded MAR update channel## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40827
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40827
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [x] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Explicitly define the MAR_CHANNEL_ID where needed to populate generated mar's channel name correctly.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/689Bug 40826: Correctly set appname_marfile while signing basebrowser nightly2023-03-28T10:02:29ZboklmBug 40826: Correctly set appname_marfile while signing basebrowser nightly## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40826
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40826
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/688Bug 40824: dmg2mar script using hardcoded project names for paths2023-03-24T14:23:39ZrichardBug 40824: dmg2mar script using hardcoded project names for paths## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40824
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40824
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [x] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
export the required environment variables before invoking dmg2mar
For reference, the relevant lines in dmg2mar:
```
my $appname = $ENV{TOR_APPNAME_BUNDLE_OSX} // 'Tor Browser';
my $appname_dmg = $ENV{TOR_APPNAME_DMGFILE} // 'TorBrowser';
my $appname_mar = $ENV{TOR_APPNAME_MARFILE} // 'tor-browser';
```richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/687Bug 40823: Update appname_* variables in projects/release/update_responses_co...2023-03-24T11:35:28ZrichardBug 40823: Update appname_* variables in projects/release/update_responses_config.yml## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40823
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40823
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [x] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Updates appname_* and urls to use the appropriate `var/projectname`
<!-- Whatever context the reviewer needs to effectively review the patchset -->richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/686Bug 40822: --disable-reloc-section on NSIS stubs.2023-03-23T14:35:27ZPier Angelo VendrameBug 40822: --disable-reloc-section on NSIS stubs.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40822
- etc
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. f...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40822
- etc
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [x] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
The change does not affect the product, but only the installers.
I think it won't affect most of the users, but it solves a problem that prevents some users to install Tor Browser.
So, I'd say that it's a good candidate for backport to stable.
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
The issue describes how to test that currently our installers don't work with mandatory ASLR.
From this [old discussion](https://web.archive.org/web/20150920123232/forums.winamp.com/showthread.php?t=344755):
> Note that IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE is probably not going to relocate the .exe in memory since we strip the relocations to reduce the size.
It seems that for cross compiling, this relied on these section not to be created on the first place.
However, [from this bug report](https://sourceforge.net/p/nsis/bugs/1283/?limit=25#e303):
> Since binutils 2.36, ld will include a .reloc section by default when linking. Compiling NSIS with said binutils version required modifying SConstruct in order to pass `-Wl,--disable-reloc-section` to the stubs environment. It appears that `APPEND_LINKFLAGS` is not being passed through.
The `APPEND_LINKFLAGS` problem is a known one, and [another comment](https://sourceforge.net/p/nsis/bugs/1283/?limit=25#e303/e90f) said how to pass that flag properly:
> The stub environment flags are set in "./SCons/Config/gnu", add this line and see if this works:
>
> ```
> stub_env.Append(LINKFLAGS = ['-Wl,--disable-reloc-section'])
> ```
So, I've created a diff file to apply with `patch` in the nsis project.
It seems to fix the problem.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/685Bug 40758: Prepare alpha release 12.5a42023-03-22T11:15:59ZrichardBug 40758: Prepare alpha release 12.5a4## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40758
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40758
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Doing a build on `tb-build-05`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/684Bug 40817: Add basebrowser-incrementals-nightly makefile target2023-03-20T15:16:17ZboklmBug 40817: Add basebrowser-incrementals-nightly makefile target## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40817
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40817
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/683fixup! Bug 40765: Prepare stable release 12.0.42023-03-17T13:31:28Zrichardfixup! Bug 40765: Prepare stable release 12.0.4## Merge Info
- ### Related Issues
- tor-browser#40765
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which d...## Merge Info
- ### Related Issues
- tor-browser#40765
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Updates the android-components and firefox/geckoview git tags (tor-browser and base-browser) to incorporate pending android security backports.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/682Bug 40765: Prepare stable release 12.0.42023-03-15T11:47:50ZrichardBug 40765: Prepare stable release 12.0.4## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40765
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40765
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
A straight-forward release still pending Android security backports. Building on `tb-build-05` overnight.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/681Bug 40813: Disable updater for base-browser stable builds; Enable var/updater...2023-03-20T10:22:30ZboklmBug 40813: Disable updater for base-browser stable builds; Enable var/updater_enabled for basebrowser nightly## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40813
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40813
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/680Bug 40812: Make var/rezip in projects/firefox/config quiet2023-03-13T15:00:03ZboklmBug 40812: Make var/rezip in projects/firefox/config quiet## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40812
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40812
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/679Bug 40763+40807: Add support for signing multiple browsers in tools/signing/n...2023-03-20T17:26:26ZboklmBug 40763+40807: Add support for signing multiple browsers in tools/signing/nightly; Add config for basebrowser nightly signing## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40763
- Closes #40807
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e....## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40763
- Closes #40807
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->
I've been running the updated script on `tbb-nightlies-master.tpo` manually to check that there was no error. I also created the `nssdb-basebrowser-1` certificate there, that we will use for signing base browser nightly updates.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/678Big 40810: Enable Finnish localization2023-03-13T13:37:54ZPier Angelo VendrameBig 40810: Enable Finnish localization## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40810
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40810
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Enable Finnish localization in nightlies and in the next alpha (12.5a4).Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/677Draft: Bug 40808: Set update URL for nightly base-browser2023-03-10T14:48:51ZboklmDraft: Bug 40808: Set update URL for nightly base-browser## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40808
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40808
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/676Bug 40809: Remove browser-update options from projects/firefox/mozconfig2023-03-10T13:57:20ZboklmBug 40809: Remove browser-update options from projects/firefox/mozconfig## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40809
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40809
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [x] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/675Bug 40805&40806: Update the version flag and the mozconfig name2023-03-10T08:49:45ZPier Angelo VendrameBug 40805&40806: Update the version flag and the mozconfig name## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- #40805
- #40806
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- #40805
- #40806
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Changes needed after tor-browser!568.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/674Bug 32355: Enable linux-arm target for openssl project2024-02-12T21:30:49ZJeremyRandBug 32355: Enable linux-arm target for openssl project## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#32355
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#32355
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](http://eweiibe6tdjsdprb4px6rqrzzcsi22m4koia44kc5pcjr7nec2rlxyad.onion/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->
Per discussion with @richard on IRC today, we're going to try to get the linux-arm patches merged piece by piece rather than having me rebase the whole thing constantly. This MR covers the `openssl` project and its dependencies. The resulting `openssl` executable works on my Asus C201 (modulo a missing libssp shared library, which is distributed outside of the `openssl` project). I haven't tested targets other than linux-arm, but I would be mildly surprised if this MR breaks anything for x86 targets.
(First time sending an MR since the MR template was added, let me know if I'm screwing anything up.)https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/673Bug 40801: Correct the ExecShell open path on the Windows system-wide installer2023-03-06T09:22:32ZPier Angelo VendrameBug 40801: Correct the ExecShell open path on the Windows system-wide installer## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40801
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40801
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Fixes an error that prevented PB from being opened after system-wide installation.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/672Bug 40750: Solve rlbox reproducibility problems2023-03-06T08:58:28ZPier Angelo VendrameBug 40750: Solve rlbox reproducibility problems## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40750
- tor-browser-build#40353
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other m...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40750
- tor-browser-build#40353
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
The problem with reproducibility seems to be related to `libc.a` not being built in a reproducible way.
I've added a script to re-create this archive, as the trivial changes to `libc`'s `Makefile` aren't enough.
For the reviewer: let's build an alpha testbuild for all platforms with `make torbrowser-testbuild` (remember to disable nightly in `rbm.local.conf`).
Upstream issue: https://github.com/WebAssembly/wasi-libc/issues/398Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/671Bug 40798: dmg2mar step also takes care of copying the signed+stabled dmg to ...2023-03-03T17:38:16ZrichardBug 40798: dmg2mar step also takes care of copying the signed+stabled dmg to the signed directory## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40798
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40798
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
This patch moves the dmg copy to the end of gatekeeper_bundling.h out of dmg2mar so that privacy-browser signing succeeds as expected. Pending approval I'll merge once I've verified the scripts work when I sign the next release.richardrichard