tor-browser-build merge requestshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests2023-06-21T13:01:41Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/741Bug 40730: Tor Browser 12.5.02023-06-21T13:01:41ZrichardBug 40730: Tor Browser 12.5.0## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40730
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40730
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
First pass at a 12.5 release prep MR.
I've removed conjure and webtunnel PTs from the tor-expert-bundle, so they should no longer be packaged in the final browser (EDIT: I realise now that we need to do more here for Android, will force push a new version in a second).
The firefox and geckoview projects presume we will have another build3 tag in the tor-browser-102.12.0esr-12.5-1 branch which does not exist yet.
Please have a look at the Changelog an make sure ther earen't any obvious errors. I derived this changelog via the existing 12.5 alpha and 12.0 stable changelogs plus manual pruning, so any errors there will have propagated.
/cc @boklm @dan @henry @ma1 @pierov @donutsrichardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/644Bug 40731: Update torbutton directory to apply namecoin-torbutton.patch2023-01-23T17:20:48ZboklmBug 40731: Update torbutton directory to apply namecoin-torbutton.patch## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40731.
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40731.
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/630Bug 40732: Review the Bundle-Data and do not ship the default profile2023-01-16T19:53:46ZPier Angelo VendrameBug 40732: Review the Bundle-Data and do not ship the default profile## Merge Info
### Related Issues
- tor-browser-build#40732
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which...## Merge Info
### Related Issues
- tor-browser-build#40732
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [x] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
This commit reviews the entire Bundle-Data mechanism, and it does maybe too many things:
1. we stop shipping Bundle-Data/$osname in base-browser, which results in not shipping a default profile anymore (except for Tor Browser);
2. Linux's start script referred the default profile: we must not do it anymore, and since it isn't required on Linux either, I've just removed these lines also for Tor Browser;
3. In tor-browser!517/tor-browser!518, we've disabled the profile migrator at Firefox build config level: we do not need to ship the `override.ini` anymore (we did for macOS);
4. macOS files in Bundle-Data did not follow the final structure, and we had to move them while building. If I understand correctly, it was legacy, so get rid of it;
5. finally, the commit reworks the template for the .dmg files: instead of having two generic dmg, one to install to /Applications (which is the only one used) and one for ~/Desktop, we now have two templates: one for Tor Browser, and one for Base Browser.
The branch for this MR includes the commit for !627, which should be merged, first, to avoid conflicts with the DMG HFS+Icon changes.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/619Bug 40733: Use the new branding directories2023-01-12T07:42:32ZPier Angelo VendrameBug 40733: Use the new branding directoriesThis commit updates the build files to use the new branding directories from tor-browser#41428 (see also tor-browser!507).
Closes #40733.This commit updates the build files to use the new branding directories from tor-browser#41428 (see also tor-browser!507).
Closes #40733.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/621Bug 40734: Backport the translation project2023-01-12T11:27:57ZPier Angelo VendrameBug 40734: Backport the translation projectI am proceeding with a MR because the cherry-pick was not clean, and I wanted to include also the tool to print the hashes, since it was not part of the original commit.
Closes #40734.I am proceeding with a MR because the cherry-pick was not clean, and I wanted to include also the tool to print the hashes, since it was not part of the original commit.
Closes #40734.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/622Bug 40735: Add command to list which translation components need to be updated2023-01-12T20:05:32ZboklmBug 40735: Add command to list which translation components need to be updatedCloses #40735.Closes #40735.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/626Bug 40738: Update Android git hashes templates2023-01-13T14:30:51ZPier Angelo VendrameBug 40738: Update Android git hashes templates!612 renamed the main git_hash, but did not update the git_hash of nightlies.
This commit fixes this error.
Fixes #40738.!612 renamed the main git_hash, but did not update the git_hash of nightlies.
This commit fixes this error.
Fixes #40738.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/629Bug 40739: tor-expert-bundle should include ClientTransportPlugin torrc lines...2023-01-16T17:43:34ZrichardBug 40739: tor-expert-bundle should include ClientTransportPlugin torrc lines...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40739
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40739
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
This patch adds a pt_config.json file containing:
- the default preferred bridge type
- built-in bridge lines
- torrc ClientTransportPlugin lines
The pt_config.json file in the tor-expert-bundle directory has two placeholders in:
- `${pt_path}` : to be swapped out by consuming applications with actual path of the pluggable transports directory (relative to the tor daemon process's working directory)
- `${pt_extension}` : swapped out by the `tor-expert-bundle` build script with either `.exe` for Windows targets or `.so` for Android targets
Future MRs for tor-browser-build#40741 will consume pt_config.json in the Tor Browser build process.
After tor-browser-build#40741 we can remove the existing bridge string text files.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/798Bug 40740: Android's snowflake ClientTransportPlugin parameters.2023-08-28T13:17:53ZPier Angelo VendrameBug 40740: Android's snowflake ClientTransportPlugin parameters.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40740
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40740
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [x] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **nightly builds** : boklm
- **rebases/release-prep** : dan_b, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
#### Change Description
richard asked for this to be added before the release preparation for 12.5.3.
It seems okay, but we should double check Snowflake after we finish building.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/799Bug 40740: Do not add -utls-imitate to Snowflake on tor-onion-proxy-library.2023-09-06T06:38:46ZPier Angelo VendrameBug 40740: Do not add -utls-imitate to Snowflake on tor-onion-proxy-library.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40740
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40740
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [x] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [ ] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **nightly builds** : boklm
- **rebases/release-prep** : dan_b, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
#### Change Description
Some changes we added yesterday don't work as expected (the `utls-imitate` parameter; the removal of some ICE servers that aren't available anymore or asked us not to be included is okay). So, revert them.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/822Bug 40741: Update browser, and tor-android-service projects to populate PT...2023-09-28T20:55:38ZrichardBug 40741: Update browser, and tor-android-service projects to populate PT...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40741
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40741
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
#### Change Description
Updates `browser` to populate bridge prefs (default bridge and bridge lines) and the default torrc file from the `tor-expert-bundle`'s `pt_config.json` file. PT base paths are pulled from the browser config's `var/pt_path` variable. Usage of the bridge line text files is removed.
Updates `tor-android-service` project to get bridge lines from `pt_config.json`.
Unraveling `tor-onion-proxy-library`s patch files seemed like more of a mess then I want to deal with, especially given this code is going away with the transition to Arti with ~"Sponsor 96" work in Q4.
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
Doing a final testbuild on `tb-build-03`, will verify platforms before marking this MR as ready:
- https://tb-build-03.torproject.org/~richard/builds/testbuild/
/cc @Pierov @boklm
<!-- Description of steps taken to verify the change -->richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/631Bug 40742: Add Privacy Browser targets2023-02-01T09:54:20ZPier Angelo VendrameBug 40742: Add Privacy Browser targets## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40742
- #40745
- #40753
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major ...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40742
- #40745
- #40753
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
This MR should allow us to build Privacy Browser build.
It introduces the following changes:
1. it allows us to customize `MOZ_APP_BASENAME`, which has direct effects on the output paths and filenames
2. it adds a few needed files for the Windows and macOS installers
3. it adds the privacybrowser targets
4. it adds the `torbrowser-` prefix to the `Makefile` targets for generating updates
5. it adds `privacybrowser` to the `.gitignore` (and adds back `release`, `alpha` and `nightly` to guarantee compatibility with older builds and with `maint-12.0`)
6. it updates the needed documentation
So far, the builds work, but only if you use the single target.
Group targets (such as desktop) don't work, but I cannot fix them on my own.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/634Bug 40744: Ensure reproducibility with HFS DMG2023-01-18T08:26:50ZPier Angelo VendrameBug 40744: Ensure reproducibility with HFS DMG## Merge Info
### Related Issues
- #40744
- #28124
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do no...## Merge Info
### Related Issues
- #40744
- #28124
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [x] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Makes the changes in !627 reproducible:
- it adds a patch to generate the HFS UUID deterministically starting from the volume label
- restore Mike Perry's patch for `dmg` (the commit in Moz's repo isn't enough, I've opened a PR, let's see if they take it)
- populates the HFS in orderPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/638Bug 40746: Remove pt_config.json from pt dir on macos2023-01-18T18:50:03ZboklmBug 40746: Remove pt_config.json from pt dir on macos## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
Closes #40746
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day ...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
Closes #40746
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/640Bug 40747+40748: empty line at the top of sha256sums-unsigned-build.txt2023-01-23T16:47:43ZboklmBug 40747+40748: empty line at the top of sha256sums-unsigned-build.txt## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40747
- Closes #40748
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40747
- Closes #40748
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/672Bug 40750: Solve rlbox reproducibility problems2023-03-06T08:58:28ZPier Angelo VendrameBug 40750: Solve rlbox reproducibility problems## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40750
- tor-browser-build#40353
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other m...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40750
- tor-browser-build#40353
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
The problem with reproducibility seems to be related to `libc.a` not being built in a reproducible way.
I've added a script to re-create this archive, as the trivial changes to `libc`'s `Makefile` aren't enough.
For the reviewer: let's build an alpha testbuild for all platforms with `make torbrowser-testbuild` (remember to disable nightly in `rbm.local.conf`).
Upstream issue: https://github.com/WebAssembly/wasi-libc/issues/398Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/642Bug 40751: Fix make signtag-* after #407372023-01-26T16:15:52ZboklmBug 40751: Fix make signtag-* after #40737## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40751
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-d...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40751
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/643Bug 40752: Fix urls in download-android-*.json files2023-01-24T12:05:29ZboklmBug 40752: Fix urls in download-android-*.json files## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40752.
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- Closes #40752.
- ### Backport Timeline
- [x] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [ ] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/685Bug 40758: Prepare alpha release 12.5a42023-03-22T11:15:59ZrichardBug 40758: Prepare alpha release 12.5a4## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40758
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes...## Merge Info
<!-- Bookkeeping information for release management -->
- ### Related Issues
- tor-browser-build#40758
- ### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
- ### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Doing a build on `tb-build-05`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/707Bug 40759: Prepare Tor Browser Alpha 12.5a52023-04-19T20:48:12ZrichardBug 40759: Prepare Tor Browser Alpha 12.5a5## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40759
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for ...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#40759
### Backport Timeline
- [ ] **Immediate** - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
- [ ] **Next Minor Stable Release** - patchset that needs to be verified in nightly before backport
- [ ] **Eventually** - patchset that needs to be verified in alpha before backport
- [x] **No Backport** - patchset for the next major stable
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
## Change Description
Building on tb-build-05
/cc @boklm @pierov @ma1 @danrichardrichard