tor-browser-build merge requestshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests2024-02-21T14:39:20Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/918Update Mullvad and Tor Browser Release Prep issue templates2024-02-21T14:39:20ZrichardUpdate Mullvad and Tor Browser Release Prep issue templates## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs ...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Update the release prep templates for Tor and Mullvad Browsers
/cc @boklm @ma1 @pierov whomever wants to review+merge this
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
<!-- Description of steps taken to verify the change -->richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/917Fix typos in generated cdn.stagemole.eu URL build hash location2024-02-20T12:54:54ZrichardFix typos in generated cdn.stagemole.eu URL build hash location## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41085
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Rele...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41085
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [x] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Updates the path generation for build hash location with fixed types
#### How Tested
<!-- Description of steps taken to verify the change -->richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/916Bug 41084: $app_bundle is missing the final .app2024-02-20T08:56:58ZPier Angelo VendrameBug 41084: $app_bundle is missing the final .app## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#xxxxx
- tor-browser-build#41084, #40569
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#xxxxx
- tor-browser-build#41084, #40569
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
I had missed a `.app` at the end when defining `$app_bundle` in `projects/firefox/build`, and this made nightly (and potentially alpha) macOS builds fail.
#### How Tested
Built a nightly testbuild and checked it arrived to the end.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/915Bug 41062: Update Tor Browser changelog2024-02-15T11:52:03ZrichardBug 41062: Update Tor Browser changelog## Merge Info
### Related Issues
- tor-browser-build#41062
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Changelog update for Tor Browser 13.0.10## Merge Info
### Related Issues
- tor-browser-build#41062
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Changelog update for Tor Browser 13.0.10richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/914Bug 41081: Update detailsURL in tools/signing/nightly/update-responses-base-c...2024-02-15T09:30:25ZboklmBug 41081: Update detailsURL in tools/signing/nightly/update-responses-base-config.yml## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41081
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41081
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Update the URL shown by the updater to a non-onion address so that it works in Mullvad Browser.
#### How Tested
Not tested but simple change.
After merging this we'll need to checkout the new commit on tbb-nightlies-master.torproject.org.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/913Bug 41079: Bump version of snowflake to v2.9.02024-02-14T16:56:52ZCecylia BocovichBug 41079: Bump version of snowflake to v2.9.0## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41079
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41079
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [x] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [ ] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
<!-- Description of steps taken to verify the change -->Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/912Update RBM to rbm@efd874abee2d4afe652feb6c79c1d929f70d136b2024-02-15T07:17:02ZrichardUpdate RBM to rbm@efd874abee2d4afe652feb6c79c1d929f70d136b## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41062
- rbm#40072
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor ...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41062
- rbm#40072
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Updated rbm to rbm@efd874abee2d4afe652feb6c79c1d929f70d136b for rbm#40072, missing backport from `main`. Also update to `-build2` for building Mullvad Browser 13.0.10
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
<!-- Description of steps taken to verify the change -->richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/911Bug 41061,41062: Prepare Tor and Mullvad Browser Stable 13.0.102024-02-14T11:36:00ZrichardBug 41061,41062: Prepare Tor and Mullvad Browser Stable 13.0.10## Merge Info
### Related Issues
- tor-browser-build#41061
- tor-browser-build#41062
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Assumes we h...## Merge Info
### Related Issues
- tor-browser-build#41061
- tor-browser-build#41062
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Assumes we have a `-build13` for `firefox-android`, `-build1` for `tor-browser` and `mullvad-browser` (we can update tor-browser related tags if we have Android security backports). We will need a subsequent Changelog change for `tor-browser` for the security backports issue.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/910Bug 41082: Tor Expert Bundle android builds create .aar file2024-02-28T22:33:57ZDan BallardBug 41082: Tor Expert Bundle android builds create .aar file## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41082
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41082
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [ ] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
The tor expert bundles .tar.gz for android now includes a .aar with all the needed files
#### How Tested
for a local fenix build, using the native bootstrap, I commented out use of the tor-android-service interface, deleted it's .aar files, dropped this one in, and native bootstrap was able to workDan BallardDan Ballardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/909Bug 40569: Include the channel name on macOS dmgs.2024-02-14T11:08:50ZPier Angelo VendrameBug 40569: Include the channel name on macOS dmgs.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#41839, tor-browser#42398
- mullvad-browser#xxxxx
- tor-browser-build#40569
### Backporting
#### Timeline
- [ ] **Immediate**: patc...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#41839, tor-browser#42398
- mullvad-browser#xxxxx
- tor-browser-build#40569
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
For the Mullvad Browser changes we're doing to make it possible to have it as a default installer, we're updating `MOZ_APP_DISPLAYNAME` to make channels not clash.
This has the side (but welcome) effect of changing the bundle name on macOS.
In turns, this involves changes on the build and signing scripts.
I've defined a new variable, `var/display_name` that is `Project_Name` on release, and `Project_Name` + `channel` on other channels.
`Project_Name_Channel` already did this, but I think its name was a little bit misleading.
So, I've renamed old occurrences of `Project_Name_Channel` to `display_name`, and now `Project_Name_Channel` will contain the channel also in release.
I've updated also the label of DMGs, so I had to update the singing script as well.
Of course, I couldn't test, so they'll need a very accurate review.
#### How Tested
I've built for all desktop x86-64 platforms + macOS merged dmg.
I've ran the builds to check we didn't have surprises.
The impact on Linux is minimal, I think only the `about:buildconfig` page changed.
On Windows, I had already started a similar change with the NSIS installer.
This also changes the properties of the DLLs and exe.
On macOS we had the highest number of changes, and I had to generate updated `.DS_Store` files.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/908Bug 41080: Re-pack omni.ja with 7-zip on Android.2024-02-15T07:17:02ZPier Angelo VendrameBug 41080: Re-pack omni.ja with 7-zip on Android.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#xxxxx
- tor-browser-build#41080
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#xxxxx
- tor-browser-build#41080
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [x] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [x] **Other**: backport only if forced (i.e., if we exceed the 100MB threshold for APKs again)
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Re-pack also `omni.ja` with 7-zip in addition to the APK, to shave a few other MBs.
#### How Tested
Checked that Android still builds.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/907Bug 41078: touch pt_config.json before adding to omni.ja2024-02-01T13:08:22ZrichardBug 41078: touch pt_config.json before adding to omni.ja## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41078
- tor-browser-build#41051
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ]...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41078
- tor-browser-build#41051
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
[% touch %] pt_config.json before adding to omni.ja, and update changlog and build number for rebuilding 13.5a4
#### How Tested
<!-- Description of steps taken to verify the change -->richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/906Bug 41076&41077: Second version of the MB installer2024-02-13T18:10:14ZPier Angelo VendrameBug 41076&41077: Second version of the MB installer## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#200
- tor-browser-build#41076 #41077
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#200
- tor-browser-build#41076 #41077
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
/cc @richard
### Change Description
As per Rui's request, the installer should be quite different from what we initially drafted, so here's a second draft that will help me to work on the default browser.
Rui asked that we implemented the possibility to install MB with a single click with the default options, but also the possibility to use the same `.exe` for the portable install.
In the same page where you choose if you want to do the portable install, you can choose if you want the desktop icon (instead of abusing of the readme checkbox like the Tor Browser installer does).
I didn't add a checkbox for the start menu because we might have to always add one for the install (for the default browser, because it's based on the AUMID and the AUMID is tied to the start menu entry - I'm not sure you can customize it without the start menu entry).
So, we always add it for the install mode, and never add it for the portable mode.
We will let the designers sort this out eventually.
In general, this wasn't approved by the UX team, but it's a blocker for the default browser investigation.
So, the idea is that we keep shipping the portable installer, and just keep this for testing purposes.
Also, it might help shaping the final UX eventually (e.g., we might just add a few more texts, but keep this new script otherwise).
Since it isn't definitive, I didn't handle the localization yet, but after we have the final design, we should do that.
The installation is only for the current user, but I've been told it's okay.
This allows us not to enable the privilege elevation code paths - I have a branch that can do it in my fork, but it isn't ready.
Rui said that he talked with other Mullvad people, and they think that eventually the current-user only install could stay, as not having the privilege elevation paths enabled is positive for MB.
The main differences between the portable and install mode are:
- install mode will always store the profile inside `%appData%` and `%localAppData%` regardless of where it's installed, following Moz's schemes to find those paths (currently, it's `Mullvad\MullvadBrowser\Profiles`)
- install mode will write to the registry, so that users can uninstall the browser from there
- for this reason, we need to write an uninstaller for install mode
- also, after the updates we need to update the version of the browser (we don't update the date because Windows uses the date at which you modify the registry items if you don't provide an explicit date)
- Mozilla does so with the uninstaller, but we write it from the installer. So, to be able to update the `postupdate.exe` hook, I created an additional NSIS executable that we include also for portable installations (and it checks whether we're in portable or install mode).
- The post update is enabled in mullvad-browser!102.
- another consequence is that we can have as many portable installations as we want, but only one install. So, the updater checks if there's already a registry entry for Mullvad Browser, and in case it won't prompt for the install location, and it will change the button from Install to Update. Portable install will be still possible.
- multiple installs would be difficult to differentiate in the control panel from the UX point of view, and we'd have to deal with the install hash to identify each one - Firefox does something like this already, but it's additional complexity that we could implement in a second moment only if we really need it
- the only exception is that understanding channels is easy enough, so actually you can have one install for each channel (one for release, one for alpha, one for nightly). Testbuilds will be displayed as testbuild, but will conflict with the channel they're based on, maybe we can change this (I've realized only now)
While the new installer is quite different from the previous one, they also share a lot of functionalities, so I've used `.nsh` files (NSIS Headers).
Also, to make it easier to test the changes, I removed all template directives, except for a single file, in which we convert them to NSIS defines.
This allows to run the scripts in a Windows system with the NSIS GUI.
It makes the process much more streamlined.
Notice that a "rendered" `defines.nsh` is available in `out/browser`.
Finally, the uninstaller should remove the links it created.
I thought it would have been sloppy if we just removed the link without testing if it's to the actual install we do have (rather than, for example, to a portable install).
So, the uninstaller reads the link target, but to do so I had to add the ShellLink plugin.
#### How Tested
Built, and checked the installation phases, including trying to reinstall when an installation already exist.
Then, tried to update and check that the control panel entries are updated (it includes the commits from `mullvad-browser.git`).
Also, tried to uninstall.
In general, I've played with the different combinations.
For the ShellLink plugin, I've tested it builds and the NSIS artifact stays reproducible even after the changes in its build script.
Then, I tested the desktop icon isn't deleted if I change its target path.
Build: https://tb-build-03.torproject.org/~pierov/mullvadbrowser/nightly/tbb-nightly.2024.01.10/mullvad-browser-windows-x86_64-install-tbb-nightly.2024.01.10.exePier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/905Update rbm for rbm#40068 and rbm#400692024-02-07T09:51:53ZboklmUpdate rbm for rbm#40068 and rbm#40069To merge after 13.5a4 is built.To merge after 13.5a4 is built.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/904Bug 41051: Update changelogs for Tor Browser 13.5a42024-01-31T13:54:36ZrichardBug 41051: Update changelogs for Tor Browser 13.5a4## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41051
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Rele...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41051
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
WIP MR for ongoing changelog updates
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
<!-- Description of steps taken to verify the change -->richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/903Bug 41067: Use Capture::Tiny instead of IO::CaptureOutput2024-01-30T16:46:24ZboklmBug 41067: Use Capture::Tiny instead of IO::CaptureOutput## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41067
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41067
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [x] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [x] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Use Capture::Tiny instead of IO::CaptureOutput. In some places (`rbm.conf`, `tools/clean-old` and `tools/download-torbrowser`) we just remove the use of IO::CaptureOutput, since we were including the module but not using it.
#### How Tested
I checked that `tools/download-torbrowser` is still working. The other scripts are not easy to test without publishing a release.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/902Bug 41038: Add RPM dependencies to README.2024-01-30T10:18:10ZPier Angelo VendrameBug 41038: Add RPM dependencies to README.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#xxxxx
- tor-browser-build#41038
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#xxxxx
- tor-browser-build#41038
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [x] **Other**: we could backport since the user says they verified also 13.0.
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Add the package required to use tor-browser-build on Fedora.
Originally sent as a `.patch` file by @NoisyCoil in #41038.
I've justified it to the 80 columns limit and added that it's been tested with Fedora 39 in the description.
So, I've created a MR for the patch, but since I result as the author, I think someone else should review it now.
#### How Tested
Not tested by me, the original author said it works.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/901Document required packages for container-less build2024-01-30T07:45:48ZMynacolDocument required packages for container-less buildAdd required packages for container-less
jq and 7zip are both absolutely required, 7zip just recently.
bison, tcl, gyp and python3-venv are scattered around as dependency.
wget is also definitely required, but it's not available in a m...Add required packages for container-less
jq and 7zip are both absolutely required, 7zip just recently.
bison, tcl, gyp and python3-venv are scattered around as dependency.
wget is also definitely required, but it's not available in a minimal
docker image.
Besides this, python3, not python2 is required, similarly jdk 11 instead
of 8.
#41073MynacolMynacolhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/900Bug 41072: Set correct updater_url for Mullvad Browser nightly builds2024-01-30T11:19:33ZboklmBug 41072: Set correct updater_url for Mullvad Browser nightly builds## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41072
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41072
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Updating `var/nightly_updates_publish_dir_prefix` should fix the update URL for Mullvad Browser nightly builds.
#### How Tested
Not tested yet. After merging this we should check if the next nightly build is able to able to update to the following release.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/899Bug 41051,41052: Tor,Mullvad Browser 13.5a4 Release Prep2024-01-29T18:11:16ZrichardBug 41051,41052: Tor,Mullvad Browser 13.5a4 Release Prep## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41051
- tor-browser-build#41052
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ]...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41051
- tor-browser-build#41052
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Release prep!
TODO -> sign+tag:
- tor-browser
- mullvad-browser
- firefox-android
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
<!-- Description of steps taken to verify the change -->richardrichard