tor-browser-build merge requestshttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests2022-02-10T12:00:44Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/402Release prep for 11.5a4 (desktop only)2022-02-10T12:00:44ZrichardRelease prep for 11.5a4 (desktop only)Version bumps and changelog updateVersion bumps and changelog updateTor Browser 11.5richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/943Draft: Bug 41083: Make a deb package for Mullvad Browser2024-03-28T10:54:57ZboklmDraft: Bug 41083: Make a deb package for Mullvad Browser## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41083
- tor-browser-build#41112
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ]...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41083
- tor-browser-build#41112
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
This create a `mullvad-browser`, `mullvad-browser-alpha` or `mullvad-browser-nightly` package (depending on channel we build). The package create a link to the start script in `/usr/bin` with the same name as the package.
I changed the start script to set `HOME` to `$HOME/.$package_name/home` (for system installs).
#### How Tested
I tested alpha and nightly builds. Installing the package on Debian bullseye worked, and running `mullvad-browser-alpha` or `mullvad-browser-nightly` started the browser correctly.
I also checked that the tar.xz bundle is still working after the changes in the start script.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/942Bug 41094,41095: Tor,Mullvad Browser 13.5a6 Release Prep2024-03-28T08:10:53ZrichardBug 41094,41095: Tor,Mullvad Browser 13.5a6 Release Prep## Merge Info
### Related Issues
- tor-browser-build#41094
- tor-browser-build#41095
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Pending tags...## Merge Info
### Related Issues
- tor-browser-build#41094
- tor-browser-build#41095
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Pending tags:
- `tor-browser-115.9.0esr-13.5-1-build2`
- `firefox-android-115.2.1-13.5-1-build8`
- `mullvad-browser-115.9.0esr-13.5-1-build2`
Pending patches:
- https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/41111
/cc @boklm @clairehurst @dan @henry @ma1 @pierov pleaes have a look at the proposed changelists and see if any of your work is missing!richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/941Bug 41110: Avoid Fontconfig warning about "ambiguous path"2024-03-26T17:45:46ZRusty BirdBug 41110: Avoid Fontconfig warning about "ambiguous path"## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41110
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41110
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [x] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **fonts** : pierovRusty BirdRusty Birdhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/940Bug 41108, 41109: Prepare Tor and Mullvad Browser Stable 13.0.132024-03-22T13:11:13ZrichardBug 41108, 41109: Prepare Tor and Mullvad Browser Stable 13.0.13## Merge Info
### Related Issues
- tor-browser-build#41108
- tor-browser-build#41109
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Preemptive r...## Merge Info
### Related Issues
- tor-browser-build#41108
- tor-browser-build#41109
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Preemptive release prep presuming we have a 115.9.1 Friday. Only update firefox presuming we are not shipping Android.
@pierov @ma1: Can you inform @ruihildt once/if :upside_down: we have matching (unsigned!) Mullvad Browser builds Friday?
@ruihildt: I'll let you know asap once we have signed builds to publish.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/939Bug 41107: Add new type of URL for downloading signatures from people.tpo2024-03-20T08:28:04ZboklmBug 41107: Add new type of URL for downloading signatures from people.tpo## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41107
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41107
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [x] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
I tested that with the change, the 13.0.12 signature is correctly downloaded.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/938Bug 41106: Force rebuild of application-services2024-03-19T12:43:37ZboklmBug 41106: Force rebuild of application-services## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41106
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41106
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [x] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
This does not fix the issue, but forces a rebuild as a temporary workaround.
#### How Tested
Not tested.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/937Bug 41086: Prepare Tor Browser 13.0.12 Part 22024-03-19T12:30:48ZrichardBug 41086: Prepare Tor Browser 13.0.12 Part 2## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41086
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41086
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [ ] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Updated tor-browser buildid (and pushed new tor-browser tag), update changelog to include new snowflake, updated translations
Verified no further updates need for other components.
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
Starting build on `tb-build-02`
<!-- Description of steps taken to verify the change -->
/cc @ma1 @pierovrichardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/936Bug 41105: Bump Snowflake version to v2.9.22024-03-18T21:26:04ZCecylia BocovichBug 41105: Bump Snowflake version to v2.9.2## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41105
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41105
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [ ] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
<!-- Description of steps taken to verify the change -->Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/935Bug 41088: Remove use of projects/browser/run_scripts2024-03-12T17:51:20ZboklmBug 41088: Remove use of projects/browser/run_scripts## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41088
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41088
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
One commit is removing use of projects/browser/run_scripts, and a second commit is simplifying a little projects/browser/build.
#### How Tested
I did a desktop build with and without those commits, and the output was the same.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/934Bug 41086,41087: Prepare Tor and Mullvad Browser Stable 13.0.122024-03-13T19:18:09ZPier Angelo VendrameBug 41086,41087: Prepare Tor and Mullvad Browser Stable 13.0.12## Merge Info
### Related Issues
- tor-browser-build#41086
- tor-browser-build#41087
## Review
### Request Reviewer
- [ ] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description## Merge Info
### Related Issues
- tor-browser-build#41086
- tor-browser-build#41087
## Review
### Request Reviewer
- [ ] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change DescriptionPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/933Allow to replace malloc with LD_PRELOAD2024-03-14T01:33:43ZmurmelurmelAllow to replace malloc with LD_PRELOAD## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- [Secureblue Issue](https://github.com/secureblue/secureblue/issues/171)
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as ...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- [Secureblue Issue](https://github.com/secureblue/secureblue/issues/171)
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [x] **Other**: allows to use Torbrowser with [hardened_malloc](https://github.com/GrapheneOS/hardened_malloc)
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- boklm /cc ma1
### Change Description
This does not change how the browser works normally. If a user uses LD_PRELOAD to load a different memory allocator though, it enables Torbrowser to use this allocator instead. This allows Torbrowser to be ran on systems preloading [hardened_malloc](https://github.com/GrapheneOS/hardened_malloc) or even compiling it into their version of gcc.
Such a preload can be disabled, but if it eventually gets integrated into gcc it is not reversible (afaik).
When preloading hardened_malloc [Firefox and variants crash immediately](https://github.com/secureblue/secureblue/issues/171). This is prevented with this build argument, which is not set by default.
In theory it can be a security risk to allow the use of a different malloc, provided by the system. But it would be an easy fix, not affecting how it runs on most systems, but allowing this use case. This should be evaluated.
#### How Tested
I have used Firefox Nightly with completely disabled jemalloc (thus using hardened_malloc via LD_PRELOAD) for multiple days, ran benchmarks, watched videos, DRM content etc, and it worked perfectly. Maybe a bit slower, but not a single crash. This will be the same with this flag.murmelurmelmurmelurmelhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/932Bug 41102: Compress firefox source tarball in a container2024-03-11T15:31:11ZboklmBug 41102: Compress firefox source tarball in a container## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41102
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41102
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [x] **Other**: please explain - fix reproducibility issue
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
As the xz version on the host can be different and produce different
output, we compress the firefox source tarball inside a container.
At the same time we use xz's --threads option to make compression
faster by using multiple threads.
We also move the src-tarballs step definition from rbm.conf to
projects/firefox/config since it's not used in any other project.
#### How Tested
Ran `make torbrowser-nightly-src` and checked that it uses the same container as macos builds.
I also ran `make torbrowser-nightly-macos` to check that it still builds (as it is using firefox source tarball during the build).boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/931Bug 42438 (TB): Export the original $HOME on Linux.2024-03-07T09:43:31ZPier Angelo VendrameBug 42438 (TB): Export the original $HOME on Linux.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#42438
- mullvad-browser#xxxxx
- tor-browser-build#xxxxx
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#42438
- mullvad-browser#xxxxx
- tor-browser-build#xxxxx
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [ ] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Define `BB_ORIGINAL_HOME`, as required by tor-browser!931.
#### How Tested
Built a test build (with tor-browser!931) and tested it can import bookmarks from Chromium.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/930Bug 41101: Prepare Tor Browser Stable 13.0.11.2024-03-05T17:30:31ZPier Angelo VendrameBug 41101: Prepare Tor Browser Stable 13.0.11.## Merge Info
### Related Issues
- tor-browser-build#41101
- tor-browser-build#xxxxx
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Prepare the ...## Merge Info
### Related Issues
- tor-browser-build#41101
- tor-browser-build#xxxxx
## Review
### Request Reviewer
- [x] Request review from a release engineer: boklm, dan, ma1, pierov, richard
### Change Description
Prepare the unscheduled Tor Browser 13.0.11.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/929Update snowflake builtin bridges to use cdn77 domain front2024-03-15T17:12:53ZCecylia BocovichUpdate snowflake builtin bridges to use cdn77 domain front## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- https://gitlab.torproject.org/tpo/anti-censorship/team/-/issues/135
### Backporting
#### Timeline
- [X] **Immediate**: patchset needed as soon...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- https://gitlab.torproject.org/tpo/anti-censorship/team/-/issues/135
### Backporting
#### Timeline
- [X] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [X] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [ ] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
Right now, neither of the builtin Snowflake bridges work.
#### How Tested
<!-- Description of steps taken to verify the change -->Cecylia BocovichCecylia Bocovichhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/928Bug 41098: Fix URL in tor-qa email in TB Release Prep issue templates2024-02-29T12:47:16ZboklmBug 41098: Fix URL in tor-qa email in TB Release Prep issue templates## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- /closes tor-browser-build#41098
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stab...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- /closes tor-browser-build#41098
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
<!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour -->
#### How Tested
<!-- Description of steps taken to verify the change -->boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/927Bug 41097: authenticode-timestamping.sh: create $tmp_dir with mktemp -d2024-03-05T16:12:30ZboklmBug 41097: authenticode-timestamping.sh: create $tmp_dir with mktemp -d## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41097
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41097
### Backporting
#### Timeline
- [x] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [ ] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [x] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Avoids an error when restarting the `authenticode-timestamping.sh` if it failed.
#### How Tested
Tested while signing 13.5a5.boklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/926Bug 41089: Register file types in the Mullvad Browser installer.2024-03-06T18:17:12ZPier Angelo VendrameBug 41089: Register file types in the Mullvad Browser installer.## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#80
- tor-browser-build#41089
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser#xxxxx
- mullvad-browser#80
- tor-browser-build#41089
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Changes to support mullvad-browser#80.
In particular, we need to save some stuff in the registry when we install the browser.
Then we have to clean them when we uninstall it.
Most of it has been adapted form Firefox's installers.
These NSIS changes require some new plugins.
Instead of finding hard ways to include them in the built, since Firefox includes their source code, I decided to build them when building Firefox, and add them to the exported artifactsm even though this means we always rebuild a couple of plugins.
#### How Tested
See mullvad-browser!108.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/925Bug 41093: Unsign APKs before signing them2024-02-28T15:19:13ZboklmBug 41093: Unsign APKs before signing them## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41093
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Relea...## Merge Info
<!-- Bookkeeping information for release management -->
### Related Issues
- tor-browser-build#41093
### Backporting
#### Timeline
- [ ] **Immediate**: patchset needed as soon as possible
- [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport
- [ ] **Eventually**: patchset that needs to be verified in alpha before backport
- [x] **No Backport (preferred)**: patchset for the next major stable
#### (Optional) Justification
- [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc
- [ ] **Censorship event**: patchset enables censorship circumvention
- [ ] **Critical bug-fix**: patchset fixes a bug in core-functionality
- [ ] **Consistency**: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
- [ ] **Sponsor required**: patchset required for sponsor
- [ ] **Other**: please explain
### Issue Tracking
- [x] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort=updated_desc&state=opened&label_name%5B%5D=Release%20Prep&first_page_size=20) for changelog generation
### Review
#### Request Reviewer
- [x] Request review from an applications developer depending on modified system:
- **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer)
- **accessibility** : henry
- **android** : clairehurst, dan
- **build system** : boklm
- **extensions** : ma1
- **firefox internals (XUL/JS/XPCOM)** : ma1
- **fonts** : pierov
- **frontend (implementation)** : henry
- **frontend (review)** : donuts, richard
- **localization** : henry, pierov
- **macos** : clairehurst, dan
- **nightly builds** : boklm
- **rebases/release-prep** : boklm, dan, ma1, pierov, richard
- **security** : ma1
- **signing** : boklm, richard
- **updater** : pierov
- **misc/other** : pierov, richard
### Change Description
Signing script changes for #41093.
#### How Tested
Not tested yet. I will test while signing the release tomorrow.boklmboklm