From 4f672e711220985034d8f391f7e120c0d179d373 Mon Sep 17 00:00:00 2001
From: Nicolas Vigier <boklm@torproject.org>
Date: Tue, 23 Jun 2026 08:26:24 +0200
Subject: [PATCH 1/2] Bug 41823: Add version for cbindgen and clang in
 toolchain updates list

In addition to the revision (git hash) that we were already checking.
---
 .../extract-firefox-versions-infos            | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/tools/toolchain-updates/extract-firefox-versions-infos b/tools/toolchain-updates/extract-firefox-versions-infos
index 339f566f..9993a6e8 100755
--- a/tools/toolchain-updates/extract-firefox-versions-infos
+++ b/tools/toolchain-updates/extract-firefox-versions-infos
@@ -129,9 +129,16 @@ sub get_clang_info {
     }
 
     my $fetch = YAML::XS::LoadFile('taskcluster/kinds/fetch/toolchains.yml');
-    set_version_info("clang-$os", $fetch->{$clang_fetch}{fetch}{revision});
+    my ($clang_version) = $fetch->{$clang_fetch}{description} =~ m/^clang (.+) source code$/;
+    set_version_info("clang-${os}_version", $clang_version);
+    set_version_info("clang-${os}_revision", $fetch->{$clang_fetch}{fetch}{revision});
 
-    set_rbm_info("clang-$os", {
+    set_rbm_info("clang-${os}_version", {
+        project => 'llvm-project',
+        option  => 'version',
+        targets => [ $rbm_os_target{$os} ],
+      });
+    set_rbm_info("clang-${os}_revision", {
         project => 'llvm-project',
         option  => 'git_hash',
         targets => [ $rbm_os_target{$os} ],
@@ -142,17 +149,23 @@ sub get_clang_info {
 ## cbindgen
 sub get_cbindgen_info {
   my $fetch = YAML::XS::LoadFile('taskcluster/kinds/fetch/toolchains.yml');
-  my $revision;
+  my ($revision, $version);
   T: foreach my $t (keys %$fetch) {
     next unless $fetch->{$t}{'fetch-alias'};
     if ($fetch->{$t}{'fetch-alias'} eq 'cbindgen') {
       $revision = $fetch->{$t}{fetch}{revision};
+      ($version) = $t =~ m/^cbindgen-(.+)/;
       last T;
     }
   }
   return 0 unless $revision;
-  set_version_info('cbindgen', $revision);
-  set_rbm_info('cbindgen', {
+  set_version_info('cbindgen_version', $version);
+  set_rbm_info('cbindgen_version', {
+      project => 'cbindgen',
+      option  => 'version',
+    });
+  set_version_info('cbindgen_revision', $revision);
+  set_rbm_info('cbindgen_revision', {
       project => 'cbindgen',
       option  => 'git_hash',
     });
-- 
GitLab


From f9fed927e7dc9313ca7048b2c72ec1e0f6ab5f53 Mon Sep 17 00:00:00 2001
From: Nicolas Vigier <boklm@torproject.org>
Date: Thu, 25 Jun 2026 15:25:15 +0200
Subject: [PATCH 2/2] Bug 41823: Update how we define version and
 var/llvm_major in llvm-project

This will make it easier to automate the update of `version`.

Suggested by @pierov in
https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/merge_requests/1498#note_3429864.

Co-authored-by: Pier Angelo Vendrame <pierov@torproject.org>
---
 projects/llvm-project/config | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/projects/llvm-project/config b/projects/llvm-project/config
index 41740034..dd7f212c 100644
--- a/projects/llvm-project/config
+++ b/projects/llvm-project/config
@@ -1,10 +1,10 @@
 # vim: filetype=yaml sw=2
-version: "[% c('var/llvm_major') %].1.8"
+version: "20.1.8"
 git_hash: 87f0227cb60147a26a1eeb4fb06e3b505e9c7261
 git_url: https://github.com/llvm/llvm-project
 filename: '[% project %]-[% c("version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]'
 
 var:
-  llvm_major: '20'
+  llvm_major: "[% c('version').split('\\.').0 %]"
 
 input_files:
-- 
GitLab