tor-browser-spec issueshttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues2023-10-04T17:32:58Zhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40062FF115 Audit2023-10-04T17:32:58ZrichardFF115 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `b1d2c35b2699a6d77f6a41ae2338d9c370c5172e` ( `FIREFOX_114_0_2_RELEASE` )
- End: `e0ccf0a049acc6e0911465c9679d9cae1e026ba2` ( `FIREFOX_115_0_2_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `1ce2908f358ade54248faf0b62a994e869f3f3e0` ( no tag :angry: )
- End: `8fbed2280909ff901287ba2b66937be5967cfe07` ( `v116.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `fa28e4ddf82bedaa65153cbc6bac3ce7d8729ef5`
- End: `a37ad25ecf5f26cfa0cb0a40d9a850c83710880d`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
#### Problematic Commits
- Bug 1832069 - Add Google Play install referrer library `3bd103c0ff8bf0257de3929788e0471d2fc305d0`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42016
- **RESOLUTION** nothing to do, respects the global remove telemetry disable settings
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=115%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Tickets
- **add an Android shortcut to go straight to the login and passwords page** https://bugzilla.mozilla.org/show_bug.cgi?id=1810629
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42012
- **RESOLUTION** button doesn't do anything for us, but should be removed in the future
- **Do not call EmptyClipboard() in nsBaseClipboard destructor** https://bugzilla.mozilla.org/show_bug.cgi?id=1834374
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42013
- **RESOLUTION** re-implemnted this feature correctly, clipboard is cleared of browser contents on browser exit
- **Implement a Remote Settings for the Quarantined Domains pref** https://bugzilla.mozilla.org/show_bug.cgi?id=1832791
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42014
- **Keep a history window of WebRTC stats for about:webrtc** https://bugzilla.mozilla.org/show_bug.cgi?id=1830790
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42015
- **RESOLUTION**: nothing to fix, the new feature respects private browsing mode and is disabled by default, we will explicitly disable the pref as security in depth
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40061FF114 Audit2023-10-04T17:32:58ZrichardFF114 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `8a724297d78ba792067a7e4d17d170c6b3af796e` ( `FIREFOX_113_0_2_RELEASE` )
- End: `b1d2c35b2699a6d77f6a41ae2338d9c370c5172e` ( `FIREFOX_114_0_2_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `b126218b17a2273edb2f1ed5806f689440740b23` ( `v114.1` not really, Mozilla created a new branch and there's no tag associated with v114.1 in )
- End: `78ab4ce85120f45a4b67b055936e401193eabd68` ( `v115.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
#### Problematic Commits
- Add Remote Settings client component `d054f01641a3da94dba4076c3ac8236547e2b3f4`
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `9d87757910437e94a860e1d6f2577d5648ded966`
- End: `fa28e4ddf82bedaa65153cbc6bac3ce7d8729ef5`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=114%20Branch&order=priority%2Cbug_severity&limit=0`
Nothing of interest (manual inspection)
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40060FF113 Audit2023-10-04T17:32:42ZrichardFF113 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `8307d3d3e4bfbca09aaa17e444f106e1e1d91b65` ( `FIREFOX_112_0_2_RELEASE` )
- End: `8a724297d78ba792067a7e4d17d170c6b3af796e` ( `FIREFOX_113_0_2_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `48916bbaf585f89fdff3404d181b260ed981a2d6` ( `v97.5.0` )
- End: `e3db1107890d3fe69122d4d78ae04c857329b0ea` ( `v114.1` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `32bb398127bacccb268a272091d2e62b8d72d6b9`
- End: `9d87757910437e94a860e1d6f2577d5648ded966`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
#### Problematic Commits
- Bug 1822268 - Part 1: Add juno onboarding fragment `536df038039d256cd41ecad41df97b1b3da1a2e4`
- Bug 1821726 - Part 2: Add juno onboarding telemetry `db4bc04177766a241f1e36621c1d8c480aab568d`
- Bug 1822750 - Add option to open default browser help page in custom tab `a488c06ae9ff9d060517da08e2a2db94465dc871`
- **RESOLUTION** All three of these are part of the Firefox onboarding which we have disabled entirely!
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=113%20Branch&order=priority%2Cbug_severity&limit=0`
Nothing of interest (manual inspection)
#### Problematic Tickets
- **Allow users to submit site support requests in Fenix** https://bugzilla.mozilla.org/show_bug.cgi?id=1805450
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42007
- **RESOLUTION** disabled
- **Copying images from Pixiv and pasting them in certain programs is broken** https://bugzilla.mozilla.org/show_bug.cgi?id=1808146
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42008
- **RESOLUTION** verified the web request happens in Firefox not the destination app
- **Enable overscroll on Windows on all channels** https://bugzilla.mozilla.org/show_bug.cgi?id=1810641
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42010
- **RESOLUTION** nothing to do here until we enable touch events (disabled for now)
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40059FF112 Audit2023-10-04T17:32:42ZrichardFF112 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `431cede9cc9472bb648f5dfe24c54d0067c290e4` ( `FIREFOX_111_0_1_RELEASE` )
- End: `8307d3d3e4bfbca09aaa17e444f106e1e1d91b65` ( `FIREFOX_112_0_2_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `9657aebb7450c5b58e8b9a88bec12bd5e9e0f700` ( `v97.2.0` )
- End: `48916bbaf585f89fdff3404d181b260ed981a2d6` ( `v97.5.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `6b0f9fdb3f603974914de82185cd184065b2ebee`
- End: `32bb398127bacccb268a272091d2e62b8d72d6b9`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
#### Problematic Commits
- Bug 1809305 - Allow user to copy an image to the clipboard (#948)
`fce0a9aa4f2ac60254dde989ee115252116fe1d7`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42002
- **RESOLUTION** nothing to do here, no linkability concern
- Bug 1819431 - Reimplement default browser notification with Nimbus Messaging equivalent (#1031) - `5989841d341f3ca867cdb2581dd06b6ce4d86156`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42003
- **RESOLUTION** nothing to do here, nimbus isn't initialised
- Bug 1818015 - Use custom tab to show privacy notice during onboarding `8661a63a378da6c76fede176824e8c8655d9d560`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42004
- **RESOLUTION** nothing to do here as we don't use firefox onboarding
- Bug 1816932 - Add Maps to app links common sub domains
`84227af1a8d6df8fa28f1f0c44966bf376b94337`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42005
- **RESOLUTION** nothing to do here, does not affect us as we don't use firefox's builtin onboarding
- Bug 1817726 - Add Recents url sharing - `c2586cba5091402723e4b4aaab7ac357a5e0b707`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42006
- **RESOLUTION** Disabled this feature in Tor Browser
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=112%20Branch&order=priority%2Cbug_severity&limit=0`
Nothing of interest (manual inspection)
### Problematic Tickets
- **Give user a choice on how open in app works** https://bugzilla.mozilla.org/show_bug.cgi?id=1818085
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40058FF111 Audit2023-10-04T17:32:42ZrichardFF111 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `250178df19caa1fb25bfa0e35728426cfbde95f8` ( `FIREFOX_110_0_1_RELEASE` )
- End: `431cede9cc9472bb648f5dfe24c54d0067c290e4` ( `FIREFOX_111_0_1_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `5755d9ce30ef10248eb55c4b39a522a118ce7d95` ( `v97.1.0` )
- End: `9657aebb7450c5b58e8b9a88bec12bd5e9e0f700` ( `v97.2.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `bc529747751ab545dba0a90a339f11382d742c97`
- End: `6b0f9fdb3f603974914de82185cd184065b2ebee`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
#### Problematic Commits
- Bug 1811531 - Add 'site' query parameter to Pocket sponsored stories request
`2dfe183ed96720b843f872fdf51fe206ed9a311c`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41990
- **RESOLUTION** pocket not available in PBM which we lock+enforce
- Bug 1812518 - Allow a custom View for 3rd party downloads `174237dcbb6d8c631f5834ecbc7875d670bb6d8d`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41991
- **RESOLUTION** feature disabled
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `69e08e3ffbf4b9f5a2ffec99b238fa0c5da1d315`
- End: `8571b648efc860bd2511183540b792e10c6cc0f4`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
#### Problematic Commits
- Bug 1815623 - Add telemetry for sharing to an app from the share sheet
`4e5d9b323b465a73d24f8ee91a8b55df10545c36`
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=111%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Tickets
- **Add API for saving a PDF** https://bugzilla.mozilla.org/show_bug.cgi?id=1810761
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41993
- **RESOLUTION** just enabling download byte-per-byte and viewing of PDF in browser, no extra meta data or conversion happens
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40057FF110 Audit2023-10-04T17:32:42ZrichardFF110 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `b89c6dedbd57992efe751d1b585116f2eaa34481` ( `FIREFOX_109_0_1_RELEASE` )
- End: `250178df19caa1fb25bfa0e35728426cfbde95f8` ( `FIREFOX_110_0_1_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `102fa0de36a21b1b2f561ba6de557e20d05b7380` ( `v96.3.0` )
- End: `5755d9ce30ef10248eb55c4b39a522a118ce7d95` ( `v97.1.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
### Problematic Commits
- Create shared remote settings client and port Nimbus to it `1d55a254fb6817c538ce19666cc02196c61170e6`
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `a7e03da7c26d76bea2fb9c77efce9d841d81f4e0`
- End: `bc529747751ab545dba0a90a339f11382d742c97`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `efb2198489bbf27e18e434306183667cf4df0526` ( `v110.0b1` )
- End: `43c570380c5aa091f361018f038fa37cbfa71662` ( `v110.0.1` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=$(FIREFOX_VERSION)%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Tickets
- **Add about:preferences entry for cookie banner handling** https://bugzilla.mozilla.org/show_bug.cgi?id=1800675
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41981
- **RESOLUTION** disabling for 13.0 and revisiting for the 13.5 alpha series
- **Add Cocoa platform support for paste files** https://bugzilla.mozilla.org/show_bug.cgi?id=1762392
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41982
- **RESOLUTION** has to deal with pasting into tor-browser, not exfiltration of data out, so we're good here
- **Create a reusable "support-link" widget** https://bugzilla.mozilla.org/show_bug.cgi?id=1770447
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41983
- **RESOLUTION** not an issue, just a hint to us for future UX work
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40056FF109 Audit2023-10-04T17:32:42ZrichardFF109 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `0ae93a27c796bea7836d4b0885c8a1f2c4c18284` ( `FIREFOX_108_0_2_RELEASE` )
- End: `b89c6dedbd57992efe751d1b585116f2eaa34481` ( `FIREFOX_109_0_1_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `d8b5a386936aa156f4c6d93e6645a6d2188aa788` ( `v96.2.1` )
- End: `102fa0de36a21b1b2f561ba6de557e20d05b7380` ( `v96.3.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `55d34bf82ad051e25f15c0d1ef5fb8b3a32a7522`
- End: `a7e03da7c26d76bea2fb9c77efce9d841d81f4e0`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `dc08c68a6cd7932dad599d0713bb3bd3b9f72b57` ( `v109.0b1` )
- End: `a66807eeb0ff39f96a41a60ac950bd9f31ecf5bd` ( `v109.2.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=109%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Tickets
- **Re-enable pingsender2** https://bugzilla.mozilla.org/show_bug.cgi?id=1746983
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41969
- **RESOLUTION** our existing patches are sufficient to keep pingsender away
- **WebRTC bypasses Network settings & proxy.onRequest** https://bugzilla.mozilla.org/show_bug.cgi?id=1790270
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41970
- **RESOLUTION** nothing to do here, the upstream bug fix is good for us and fixes some proxy leak
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40055FF108 Audit2023-10-04T17:32:42ZrichardFF108 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `1187da3c99c93ad941eea0809d3b2c8f81ac5ccf` ( `FIREFOX_107_0_1_RELEASE` )
- End: `0ae93a27c796bea7836d4b0885c8a1f2c4c18284` ( `FIREFOX_108_0_2_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `ce8f1767d991da9d6d26331faecd426210071c7e` ( `v96.1.0` )
- End: `d8b5a386936aa156f4c6d93e6645a6d2188aa788` ( `v96.2.1` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Firefox Android: https://github.com/mozilla-mobile/firefox-android.git
- Start: `0486e931b4427d646af1dcf69a53c90efbe60862`
- End: `55d34bf82ad051e25f15c0d1ef5fb8b3a32a7522`
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `171d8a7aa521676d008bfd98bfae34ce8774e5f5` ( `v108.0b1` )
- End: `78718ba91dd19f78e94d8f8c462598c29d48069a` ( `v108.2.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=108%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Issues:
- **Remove descriptionheightworkaround.** https://bugzilla.mozilla.org/show_bug.cgi?id=1795944
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41959
- **RESOLUTOIN** not a security issue, more of a general ESR migration/functionality issue
- **Proxy environment variables should be upper case / case insensitive** https://bugzilla.mozilla.org/show_bug.cgi?id=1797896
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41960
- **RESOLUTION**: determined this logic is gated behind our tor configuration settings, and so aren't relevant or a de-anonimisation vector; nothing to do here
- **Hide cookie banner handling UI by default** https://bugzilla.mozilla.org/show_bug.cgi?id=1798868
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41961
- **RESOLUTION**: we will hide the UI to enable/disable the feature, and likely enable the feature for everyone
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40054FF107 Audit2023-10-04T17:32:41ZrichardFF107 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `ac898d40ded7de23ef22a6f336f2ab1f0bca0d3f` ( `FIREFOX_106_0_5_RELEASE` )
- End: `1187da3c99c93ad941eea0809d3b2c8f81ac5ccf` ( `FIREFOX_107_0_1_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `f1276e45b7c284bc4435896b1d5d09b35f3b295b` ( `v95.0.1` )
- End: `ce8f1767d991da9d6d26331faecd426210071c7e` ( `v96.1.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `1c48533cff068056259e62861344bd8a490a83e7`
- End: `ff4f1f8ae3c12e6f6e0dcf52f88049ca251470d8` ( `v107.0.3` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `8c088f08d339514ac12732bffdc9bb90540d9337` ( `v107.0b1` )
- End: `1490acda7e44894c8437cc7fb677d3fba1a711ce` ( `v107.2.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=107%20Branch&order=priority%2Cbug_severity&limit=0`
where `$(FIREFOX_VERSION)` is the major Firefox version we are auditing (eg: '91')
Nothing of interest (manual inspection)
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40053FF106 Audit2023-10-04T17:32:41ZrichardFF106 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `2dd649f09f70ec5b9304d62daeb427a86bbc5a36` ( `FIREFOX_105_0_3_RELEASE` )
- End: `ac898d40ded7de23ef22a6f336f2ab1f0bca0d3f` ( `FIREFOX_106_0_5_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `be8254df118b2fc2aae726e1d13ca4c982bec920` ( `v94.3.1` )
- End: `f1276e45b7c284bc4435896b1d5d09b35f3b295b` ( `v95.0.1` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x ] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `5bf7550ec9d5686fae721ee045132866f88afca6`
- End: `5f06485fc33a26206ba4ef7996ba1ae83134e353` ( `v106.0.5` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `74e6ce8103fe3d4525c0a91d8e0c0403d1fee44f` ( `v106.0b1` )
- End: `71ca6c1f7a7a2f2045b82ed16be329acadc15084` ( `v106.1.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=106%20Branch&order=priority%2Cbug_severity&limit=0`
Nothing of interest (manual inspection)
#### Problematic Issues
- **Add the possibility to check that the clipboard contains some pdfjs stuff** https://bugzilla.mozilla.org/show_bug.cgi?id=1788668
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41950
- **RESOLUTION** nothing to do here, verified no linkability concerns via testing
- **Enable seperatePrivateDefault by default** https://bugzilla.mozilla.org/show_bug.cgi?id=1790681
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41951
- **RESOLUTION** nothing to do here, this is a tweak to a feature we have completley disabled
## Export
- [x] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40052FF105 Audit2023-10-04T17:32:41ZrichardFF105 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `a8c31da1c243a855de8c3b241a437dd1b65684d5` ( `FIREFOX_104_0_2_RELEASE` )
- End: `2dd649f09f70ec5b9304d62daeb427a86bbc5a36` ( `FIREFOX_105_0_3_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `78b165b798118e9b5fa62af07aa44d663f386492` ( `v94.1.0` )
- End: `be8254df118b2fc2aae726e1d13ca4c982bec920` ( `v94.3.1` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `b3e0289b3f07929c0403ac6e672c88b5db079748`
- End: `658c2d239f9aef5927f654aa36a0b0739b116d92` ( `v105.0.8` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `a5d13e2ef26d4eb98a32c94b6c6530771e90cd56` ( `v105.0b1` )
- End: `01fbfd63743f30ebca31bbfb775bddef94a01a3e` ( `v105.2.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=105%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Issues
- **Use the WER runtime exception module to catch early crashes** https://bugzilla.mozilla.org/show_bug.cgi?id=1682520
- *RESOLUTION*: no new functionality here, just making it work better by moving the registration earlier in the Firefox boot process
- **Add a pref to disable Spectre mitigations for Fission web content processes** https://bugzilla.mozilla.org/show_bug.cgi?id=1774178
- **Add Surrogate COM Server to handle native Windows notifications when Firefox is closed.** https://bugzilla.mozilla.org/show_bug.cgi?id=1774083
- *RESOLUTOIN* COM sever registration happens in the official firefox installer which we do not use, so nothing to do here
- **Add a cookie banner service to automatically handle website cookie banners** https://bugzilla.mozilla.org/show_bug.cgi?id=1783019
- *RESOLUTION* disabled this feature until fully audit, may bring back in the 13.5 time-frame
- **Add a locale parameter to the text recognition API** https://bugzilla.mozilla.org/show_bug.cgi?id=1782579
- *RESOLUTION* we'v diabled this system entirely in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42057
- **Broken since Firefox 102.0: no instant fallback to direct connection when proxy became unreachable while runtime** https://bugzilla.mozilla.org/show_bug.cgi?id=1779005
- *RESOLUTION*: Tor Browser uses explicitly configured proxy settings so this auto-detect system is no used/does not apply to us
- **On systems with IPv6 preferred DNS resolution clients will fail to connect when "localhost" is used as host for the WebSocket server** https://bugzilla.mozilla.org/show_bug.cgi?id=1769994
- **Hide the text recognition context menu if the macOS version doesn't support APIs** https://bugzilla.mozilla.org/show_bug.cgi?id=1782981
- *RESOLUTION* we'v diabled this system entirely in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42057
- **Implement a context menu modal for text recognition** https://bugzilla.mozilla.org/show_bug.cgi?id=1782578
- *RESOLUTION* we've disabled this system entirely in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42057
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40051FF104 Audit2023-10-04T17:32:41ZrichardFF104 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `1f1c56dc6bae6b3302471f097ed132ef44cded86` ( `FIREFOX_103_0_2_RELEASE` )
- End: `a8c31da1c243a855de8c3b241a437dd1b65684d5` ( `FIREFOX_104_0_2_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
#### Problematic Commits
- Bug 1780014: Add specific telemetry for conservative and first-try handshakes `7a55bf9c230b83c0a195929feaad1f5e77195412`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41937
- **RESOLUTION** nothing to do here, telemetry is gated in the usual fashoin
- Bug 1769994 - [remote] Resolve localhost to an IP before starting httpd.js. `c193147b7b622a9b69e768079553e0d27c05c993`
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41938
- **RESOLUTION** nothing to do here, this is a debugger feature not a web content one
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `b70c54882fec606d10e77520b1dd2ae144768747` ( `v94.0.0` )
- End: `78b165b798118e9b5fa62af07aa44d663f386492` ( `v94.1.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `ae333f064744e005ef22ac86ab8518d9bf7d9820`
- End: `7b0499725d3016a0d9288c337fcde4ffff60acfe` ( `v104.0.10` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `3f7ddd5d6ef4f8495092138149d36b42e08dbbdb` ( `v104.0b1 )
- End: `0f9ad767addb7eeef1800ac5bb80e094e3e87f07` ( `v104.2.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=104%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Tickets
- **Support fetching data from Remote Setting** https://bugzilla.mozilla.org/show_bug.cgi?id=1728871
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41939
- **RESOLUTION** nothing to do here, only applies to safe-browsing which we disable
- **When a filetype is set to "always ask" and the user makes a save/open choice in the dialog, we should not also open the downloads panel** https://bugzilla.mozilla.org/show_bug.cgi?id=1739348
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41940
- **RESOLUTION** was not a security or privacy issue, just needed to make sure it played nciely with our own custom downloads UX which it does
- **Improve Math.pow accuracy for large exponents** https://bugzilla.mozilla.org/show_bug.cgi?id=1775254
- https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41941
- **RESOLUTION** tjr fortunately verified this doesn't break existing fingerprinting assumptions upstream
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40050FF103 Audit2023-10-04T17:32:41ZrichardFF103 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `feef2b7da6ff76b4c3c7a13e611eab6e97837ae2` ( `FIREFOX_102_0_1_RELEASE` )
- End: `1f1c56dc6bae6b3302471f097ed132ef44cded86` ( `FIREFOX_103_0_2_RELEASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `0302b89604bb29adb34fdcd710feabd3dd01992d` ( `v93.5.0` )
- End: `b70c54882fec606d10e77520b1dd2ae144768747` ( `v94.0.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `c349019286e21e5179a59e33cec6ae528b108519`
- End: `ce720e6308e26588decd5f9d2b02e4658d5b9d14` ( `v103.0.11` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
<!--
### foreach PROBLEMATIC_HASH:
#### $(PROBLEMATIC_HASH)
- Summary
- Review Result: (SAFE|BAD)
-->
#### Problematic Commits
- Biometric prompt feature (#12291): `b1723820859fce1c6d0a358e1edec4f4dec39234`
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `6e0ad035e384ef1fb7d8c8ac8d398470d953e1dc` ( `v103.0.0-beta.1` )
- End: `e0d3c03afefe699a7456214b0da140f74ef499f7` ( `v103.2.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
Bugzilla Query: `https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=103%20Branch&order=priority%2Cbug_severity&limit=0`
#### Problematic Tickets
- **Use double-conversion library instead of dtoa for string-to-double conversion** https://bugzilla.mozilla.org/show_bug.cgi?id=1770158
- We should make sure this isn't somehow hardware dependent
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40049Remove processes/ReleaseProcess (replaced by gitlab issue template)2023-07-13T20:07:12ZboklmRemove processes/ReleaseProcess (replaced by gitlab issue template)`processes/ReleaseProcess` needs some updates after last signing process changes. However, since everything is already documented in `tor-browser-build/.gitlab/issue_templates/Release Prep - Tor Browser Stable.md` (and `Release Prep - To...`processes/ReleaseProcess` needs some updates after last signing process changes. However, since everything is already documented in `tor-browser-build/.gitlab/issue_templates/Release Prep - Tor Browser Stable.md` (and `Release Prep - Tor Browser Stable.md` for alpha), I think we should check if something from `processes/ReleaseProcess` is missing in the gitlab issue template, and then remove `processes/ReleaseProcess`.
/cc @richardboklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/31161Document usage and setup of Android signing token2023-07-13T08:20:04ZGeorg KoppenDocument usage and setup of Android signing tokenWe have documentation in `tor-browser-spec` about setting up our Windows signing token and should do the same for the Android one.
We could add the relevant instructions for using the whole setup on our actual signing machine in a separ...We have documentation in `tor-browser-spec` about setting up our Windows signing token and should do the same for the Android one.
We could add the relevant instructions for using the whole setup on our actual signing machine in a separate commit within this ticket's scope.Tor Browser: 11.0 Issues with previous releaseboklmboklmhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40036FF101 Audit2022-12-20T18:13:49ZrichardFF101 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `59930a20119813ea25546eaca75dcc3bbc500039` ( `FIREFOX_RELEASE_101_BASE` )
- End: `856b9168439ef597dbd103cd1e2940a8ad110450` ( `FIREFOX_RELEASE_102_BASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `6a4737d1c043d71dfac67e270ee4afa4fb6c73b4` ( `v93.2.1` )
- End: `0302b89604bb29adb34fdcd710feabd3dd01992d` ( `v93.5.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `4eef6c129c9611b6927bd50a5a1620ede57744b1` ( `v101.0.0` )
- End: `95fe1972b83b518a70febc76cdf3e27d5cfa390f` ( `v101.0.9` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `02ca27633b10acbe4db08aecf9c0a12d83376fd9` ( `v101.0.0-beta.1` )
- End: `be90007a460cc7b06008f319447011b2dce76aaa` ( `releases_v101.0.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
### 101 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=101%20Branch&order=priority%2Cbug_severity&limit=0
- https://bugzilla.mozilla.org/show_bug.cgi?id=1766401 : @ma1 https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41147
- https://bugzilla.mozilla.org/show_bug.cgi?id=1661450 : @boklm https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41148
- https://bugzilla.mozilla.org/show_bug.cgi?id=1762576 : @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41149
- https://bugzilla.mozilla.org/show_bug.cgi?id=1753302 : @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41150
- https://bugzilla.mozilla.org/show_bug.cgi?id=1757823 : @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41151
## Regression/Prior Vuln Review ##
Review proxy bypass bugs; check for new vectors to look for:
- https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=Proxy%20Bypass
- Look for new features like these. Especially external app launch vectors
## Export
- [x] Export Report and save to `tor-browser-spec/audits`Sponsor 131 - Phase 3 - Major ESR 102 Migrationrichardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40037FF102 Audit2022-11-23T13:44:36ZrichardFF102 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `856b9168439ef597dbd103cd1e2940a8ad110450` ( `FIREFOX_RELEASE_102_BASE` )
- End: `4960b7d420528392cc095c247a662670785b18b9` ( `FIREFOX_RELEASE_103_BASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `0302b89604bb29adb34fdcd710feabd3dd01992d` ( `v93.5.0` )
- End: `55cbbddfdcb4ec82d2850e0811e8675fea2686c2` ( `v93.7.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `2b414097d4f540948f67f62f57c5ddcb0e2789d9` ( `v102.0.1` )
- End: `cd19f9a6c5e26c4e57dda6e549a5c63ac7c042ea` ( `v102.0.14` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `cc68c965cbb29eb16244d242d433051327de5f48` ( `v102.0.0-beta.1` )
- End: `2ec252d5f5d09b3eb73840ce585453b7105a7a7d` ( `releases_v102.0.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
### 102 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=102%20Branch&order=priority%2Cbug_severity&limit=0
- https://bugzilla.mozilla.org/show_bug.cgi?id=1767919 : @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41152
- ~~https://bugzilla.mozilla.org/show_bug.cgi?id=1770881 : @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41153~~ 102esr is unaffected: the Bugzilla ticket was wrong and then has been fixed
- https://bugzilla.mozilla.org/show_bug.cgi?id=1765167 : @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41154
- https://bugzilla.mozilla.org/show_bug.cgi?id=1751450 : @richard https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41155
where `$(FIREFOX_VERSION)` is the major Firefox version we are auditing (eg: '91')
Nothing of interest (manual inspection)
**OR** (foreach)**
### foreach PROBLEMATIC_TICKET:
#### $(PROBLEMATIC_TICKET)
- Summary
- Review Result: (SAFE|BAD)
## Regression/Prior Vuln Review ##
Review proxy bypass bugs; check for new vectors to look for:
- https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=Proxy%20Bypass
- Look for new features like these. Especially external app launch vectors
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`Sponsor 131 - Phase 3 - Major ESR 102 Migrationrichardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40029FF95 Audit2022-11-02T20:48:15ZrichardFF95 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `6c9b6e1483551f220cd409e4e584349bc74a8231` ( `FIREFOX_RELEASE_95_BASE` )
- End: `6a277ae5bdf6554793cd0da292a9c9ea804b4ed9` ( `FIREFOX_RELEASE_96_BASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `df1a47fde89f49201b1e839f960e8f16eb95a55d` ( `v87.1.0` )
- End: `5ceeb43598871a7d8550acc574a6a3fb93803ad7` ( `v87.3.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `ef09fecd91dfcbffb85d9f4907b76cc9e5a0b70e` ( `v95.0.0` )
- End: `93066a8f082fa2db3d38d361d0a538c438d2e1b8` ( `v95.0.15` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `9ab24a371b2dd51d18dab2f7f49facc6d2fd56ad` ( `v95.0.0-beta.1` )
- End: `d01642a0b1e3819cd2802b42a8a6aae43eb5ff12` ( `releases_v95.0.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
### Review List
#### 95 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=95%20Branch&order=priority%2Cbug_severity&limit=0
- https://bugzilla.mozilla.org/show_bug.cgi?id=1732792 : @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41125
- https://bugzilla.mozilla.org/show_bug.cgi?id=1734262 : @ma1 https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41126
- https://bugzilla.mozilla.org/show_bug.cgi?id=1726524 : @henry https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41127
- https://bugzilla.mozilla.org/show_bug.cgi?id=1734331 : @boklm https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41128
### foreach PROBLEMATIC_TICKET:
#### $(PROBLEMATIC_TICKET)
- Summary
- Review Result: (SAFE|BAD)
## Regression/Prior Vuln Review ##
Review proxy bypass bugs; check for new vectors to look for:
- https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=Proxy%20Bypass
- Look for new features like these. Especially external app launch vectors
## Export
- [x] Export Report and save to `tor-browser-spec/audits`Sponsor 131 - Phase 3 - Major ESR 102 Migrationrichardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40030FF97 Audit2022-11-01T21:23:44ZrichardFF97 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `e6b83e1727b7e9a6847e6e15bdb935d9937099e4` ( `FIREFOX_RELEASE_97_BASE` )
- End: `82764d45153d175f4686ead7aac977810fe1fd1b` ( `FIREFOX_RELEASE_98_BASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
**OR**
### foreach PROBLEMATIC_HASH:
#### $(PROBLEMATIC_HASH)
- Summary
- Review Result: (SAFE|BAD)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `df53ad867be7d79899e05797533cd624f1eeb2a2` ( `v90.0.1` )
- End: `17942945873cdb8be56a9316d3cb8a611b3ef321` ( `v91.1.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `604152ef532c33d8fc2412fd6d21cf29e9764c51` ( `v97.0.0` )
- End: `0465a6f809adafd5429c230e890e7f4911f0070e` ( `v97.0.13` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `84d4a07c0067f7c51757b157c79658a891870d95` ( `v97.0.0-beta.1` )
- End: `16042ab2a16a64c9c94c8c01ea93578062415ac5` ( `releases_v97.0.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
### Review List
#### 97 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=97%20Branch&order=priority%2Cbug_severity&limit=0
- https://bugzilla.mozilla.org/show_bug.cgi?id=1741428 @richard https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41130
- https://bugzilla.mozilla.org/show_bug.cgi?id=1738983 @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41131
- https://bugzilla.mozilla.org/show_bug.cgi?id=1432983 @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41132
- https://bugzilla.mozilla.org/show_bug.cgi?id=1745092 @boklm https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41133
Nothing of interest (manual inspection)
**OR** (foreach)**
### foreach PROBLEMATIC_TICKET:
#### $(PROBLEMATIC_TICKET)
- Summary
- Review Result: (SAFE|BAD)
## Regression/Prior Vuln Review ##
Review proxy bypass bugs; check for new vectors to look for:
- https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=Proxy%20Bypass
- Look for new features like these. Especially external app launch vectors
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`Sponsor 131 - Phase 3 - Major ESR 102 Migrationrichardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser-spec/-/issues/40035FF100 Audit2022-10-26T23:12:49ZrichardFF100 Audit# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java...# General
The audit begins at the commit hash where the previous audit ended. Use code_audit.sh for creating the diff and highlighting potentially problematic code. The audit is scoped to a specific language (currently C/C++, Rust, Java/Kotlin, and Javascript).
The output includes the entire patch where the new problematic code was introduced. Search for `XXX MATCH XXX` to find the next potential violation.
`code_audit.sh` contains the list of known problematic APIs. New usage of these functions are documented and analyzed in this audit.
## Firefox: https://github.com/mozilla/gecko-dev.git
- Start: `cd4dcd48476d8cb29f4770f6fb659e440ff84345` ( `FIREFOX_RELEASE_100_BASE` )
- End: `59930a20119813ea25546eaca75dcc3bbc500039` ( `FIREFOX_RELEASE_101_BASE` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
---
## Application Services: https://github.com/mozilla/application-services.git
- Start: `21f2904245a956366cae798e16035156c8232cad` ( `v93.0.2` )
- End: `6a4737d1c043d71dfac67e270ee4afa4fb6c73b4` ( `v93.2.1` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Android Components: https://github.com/mozilla-mobile/android-components.git
- Start: `ba604c57073b3ed91cc863e5d9a7aa9d7e7a4b95` ( `v100.0.0` )
- End: `7b24cbd76371562a9e9a842ca351dae7599d53f3` ( `v100.0.12` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Fenix: https://github.com/mozilla-mobile/fenix.git
- Start: `89d64fc0e8204b6f2f442a656108ee2dc9bffbef` ( `v100.0.0-beta.1` )
- End: `827b01341f76e9ee8c152260992eb5f22a775791` ( `releases_v100.0.0` )
### Languages:
- [x] java
- [x] cpp
- [x] js
- [x] rust
Nothing of interest (using `code_audit.sh`)
## Ticket Review ##
### 100 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=100%20Branch&order=priority%2Cbug_severity&limit=0
- https://bugzilla.mozilla.org/show_bug.cgi?id=1760621 : @boklm https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41142
- https://bugzilla.mozilla.org/show_bug.cgi?id=1758781 : @pierov https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41143
- https://bugzilla.mozilla.org/show_bug.cgi?id=1752906 : @ma1 https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41144
- https://bugzilla.mozilla.org/show_bug.cgi?id=1759592 : @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41145
- https://bugzilla.mozilla.org/show_bug.cgi?id=1699658 : @dan https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41146
Nothing of interest (manual inspection)
**OR** (foreach)**
### foreach PROBLEMATIC_TICKET:
#### $(PROBLEMATIC_TICKET)
- Summary
- Review Result: (SAFE|BAD)
## Regression/Prior Vuln Review ##
Review proxy bypass bugs; check for new vectors to look for:
- https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&utf8=%E2%9C%93&state=opened&label_name[]=Proxy%20Bypass
- Look for new features like these. Especially external app launch vectors
## Export
- [ ] Export Report and save to `tor-browser-spec/audits`Sponsor 131 - Phase 3 - Major ESR 102 Migrationrichardrichard