Skip to content
  • Emilio Cobos Álvarez's avatar
    Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj · 256c124f
    Emilio Cobos Álvarez authored
    This was done by:
    
    This was done by applying:
    
    ```
    diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
    index 789affde7bbf..fe33c4c7d4d1 100644
    --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
    +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
    @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
             from subprocess import Popen, PIPE, check_output, CalledProcessError
    
             diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
    -        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
    +        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']
    
             if not output_file:
                 args.append("-i")
    ```
    
    Then running `./mach clang-format -c <commit-hash>`
    
    Then undoing that patch.
    
    Then running check_spidermonkey...
    256c124f