Bug 1706746 - New user onboarding - Remove urlbar focus by default r=andreio a=RyanVM

Removes focus from address bar on about:welcome, patch will be uplifted to 89 and ride along with a dot release in 88

Differential Revision: https://phabricator.services.mozilla.com/D113014

browser/app/profile/firefox.js

@@ -1471,7 +1471,7 @@ pref("trailhead.firstrun.newtab.triplets", "");
 pref("browser.aboutwelcome.enabled", true);
 // Used to set multistage welcome UX
 pref("browser.aboutwelcome.screens", "");
-pref("browser.aboutwelcome.skipFocus", false);
+pref("browser.aboutwelcome.skipFocus", true);
 pref("browser.aboutwelcome.design", "");
 
 // The pref that controls if the What's New panel is enabled.

browser/components/newtab/test/browser/browser_aboutwelcome_focus.js

@@ -55,10 +55,10 @@ async function openAboutWelcomeBrowserWindow() {
 
 add_task(async function test_multistage_default() {
   let win = await openAboutWelcomeBrowserWindow();
-  Assert.ok(win.gURLBar.focused, "Focus should be on awesome bar");
+  Assert.ok(!win.gURLBar.focused, "Focus should not be on awesome bar");
   Assert.ok(
-    win.gURLBar.hasAttribute("focused"),
-    "Has focused attribute on urlBar"
+    !win.gURLBar.hasAttribute("focused"),
+    "No focused attribute on urlBar"
   );
 
   registerCleanupFunction(async () => {
@@ -68,6 +68,7 @@ add_task(async function test_multistage_default() {
 
 add_task(async function test_multistage_without_skipFocus() {
   await setAboutWelcomeOverrideContent(JSON.stringify(TEST_MULTISTAGE_JSON));
+  await pushPrefs([ABOUT_WELCOME_FOCUS_PREF, false]);
   let win = await openAboutWelcomeBrowserWindow();
   Assert.ok(win.gURLBar.focused, "Focus should be on awesome bar");
   Assert.ok(