Commit 2acc89f2 authored by William Durand's avatar William Durand
Browse files

Bug 1823507 - Collect `install_stats` for RTAMO as well. r=rpl 

The data review request in Bug 1653020 should still apply to this but we
might need a new data review anyway. I am not sure.

Differential Revision: https://phabricator.services.mozilla.com/D173073
parent b69e6563

toolkit/components/telemetry/Events.yaml

+3 −2
Original line number Diff line number Diff line
@@ -237,8 +237,9 @@ addonsManager: 
  install_stats:

    description: >

      These events are recorded at the end of the install flow, but only when

      the source that originally triggered the add-on installation is "amo" or

      "disco". The value of an event is the SHA256 hash of the addon_id.

      the source that originally triggered the add-on installation is "amo",

      "rtamo" or "disco". The value of an event is the SHA256 hash of the

      addon_id.

    objects:

      - "extension"

      - "theme"

toolkit/mozapps/extensions/AddonManager.jsm

+1 −1
Original line number Diff line number Diff line
@@ -64,7 +64,7 @@ const WEBAPI_TEST_INSTALL_HOSTS = 
    ? ["addons.allizom.org", "addons-dev.allizom.org", "example.com"]

    : ["addons-stage.thunderbird.net", "example.com"];



const AMO_ATTRIBUTION_ALLOWED_SOURCES = ["amo", "disco"];

const AMO_ATTRIBUTION_ALLOWED_SOURCES = ["amo", "disco", "rtamo"];

const AMO_ATTRIBUTION_DATA_KEYS = [

  "utm_campaign",

  "utm_content",

toolkit/mozapps/extensions/test/xpcshell/test_addon_manager_telemetry_events.js

+44 −0
Original line number Diff line number Diff line
@@ -826,6 +826,50 @@ add_task(async function test_collect_attribution_data_for_amo_with_long_id() { 
  });

});



add_task(async function test_collect_attribution_data_for_rtamo() {

  assertNoTelemetryEvents();



  const url = "https://addons.mozilla.org/";

  const addonId = "{28374a9a-676c-5640-bfa7-865cd4686ead}";

  // This is the SHA256 hash of the `addonId` above.

  const expectedHashedAddonId =

    "cf815c9f45c249473d630705f89e64d359737a106a375bbb83be71e6d52dc234";



  // We simulate what is happening in:

  // https://searchfox.org/mozilla-central/rev/d2786d9a6af7507bc3443023f0495b36b7e84c2d/browser/components/newtab/content-src/lib/aboutwelcome-utils.js#91

  const installTelemetryInfo = {

    ...FAKE_INSTALL_TELEMETRY_INFO,

    sourceURL: `${url}?utm_content=utm-content-value`,

    source: "rtamo",

  };



  const fakeAddonInstall = {

    addon: { id: addonId },

    type: "extension",

    installTelemetryInfo,

    hashedAddonId: expectedHashedAddonId,

  };

  AMTelemetry.recordInstallStatsEvent(fakeAddonInstall);



  const installStatsEvents = getTelemetryEvents(["install_stats"]);

  Assert.equal(

    installStatsEvents.length,

    1,

    "only one install_stats event should be recorded"

  );



  const installStatsEvent = installStatsEvents[0];



  Assert.deepEqual(installStatsEvent, {

    method: "install_stats",

    object: "extension",

    value: expectedHashedAddonId,

    extra: {

      addon_id: AMTelemetry.getTrimmedString(addonId),

    },

  });

});



add_task(async function teardown() {

  await TelemetryController.testShutdown();

});