Commit 460128ba authored by Alexander Cooper's avatar Alexander Cooper Committed by aborovova@mozilla.com
Browse files

Bug 1967327 [wpt PR 52648] - Remove unnecessary isCpuOptimized parameter/generators, 

Automatic update from web-platform-tests
Remove unnecessary isCpuOptimized parameter/generators

A lot of depth-sensing tests pass in whether this is a test case
expecting a cpu-optimized session or not; however, this data is
available from the session object and doesn't need to be passed in. This
results in many cases where a generator function is no longer truly
needed, and so a simple test function is created instead. There is still
value in having these tests split into gpu/cpu subfolders, so these
tests are still left written in a shared .js file

Change-Id: I81e8e73bd90473fda49796e9672829489d846c6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6554764


Reviewed-by: default avatarPiotr Bialecki <bialpio@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1462400}

--

wpt-commits: 6407bf32623942504a5a969a615400cb16a30e33
wpt-pr: 52648

Differential Revision: https://phabricator.services.mozilla.com/D250714
parent 4d439052

testing/web-platform/tests/webxr/depth-sensing/cpu/depth_sensing_cpu_dataUnavailable.https.html

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ const fakeDeviceInitParams = { 
};



xr_session_promise_test("Ensures depth data is not available when cleared in the controller, `cpu-optimized`",

  dataUnavailableTestFunctionGenerator(/*isCpuOptimized=*/true),

  dataUnavailableTestFunction,

  fakeDeviceInitParams,

  'immersive-ar', {

    requiredFeatures: ['depth-sensing'],

testing/web-platform/tests/webxr/depth-sensing/cpu/depth_sensing_cpu_inactiveFrame.https.html

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ const fakeDeviceInitParams = { 
};



xr_session_promise_test("Ensures appropriate depth methods and attributes throw when not run in an active frame, `cpu-optimized`",

  inactiveFrameTestFunctionGenerator(/*isCpuOptimized=*/true),

  inactiveFrameTestFunction,

  fakeDeviceInitParams,

  'immersive-ar', {

    requiredFeatures: ['depth-sensing'],

testing/web-platform/tests/webxr/depth-sensing/cpu/depth_sensing_cpu_matchDepthViewIdentity.https.html

+3 −3
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ const fakeDeviceInitParams = { 
};



xr_session_promise_test("Ensures XRViewGeometry values match XRView when matchDepthView is unset, `cpu-optimized`",

  depthViewGeometryTestGenerator(/*isCpuOptimized=*/true, /*matchDepthView=*/true),

  depthViewGeometryTestGenerator(/*matchDepthView=*/true),

  fakeDeviceInitParams,

  'immersive-ar', {

    requiredFeatures: ['depth-sensing'],
@@ -29,7 +29,7 @@ xr_session_promise_test("Ensures XRViewGeometry values match XRView when matchDe 
  });



xr_session_promise_test("Ensures XRViewGeometry values match XRView when matchDepthView=true, `cpu-optimized`",

  depthViewGeometryTestGenerator(/*isCpuOptimized=*/true, /*matchDepthView=*/true),

  depthViewGeometryTestGenerator(/*matchDepthView=*/true),

  fakeDeviceInitParams,

  'immersive-ar', {

    requiredFeatures: ['depth-sensing'],
@@ -41,7 +41,7 @@ xr_session_promise_test("Ensures XRViewGeometry values match XRView when matchDe 
  });



xr_session_promise_test("Ensures XRViewGeometry values do not match XRView when matchDepthView=false, `cpu-optimized`",

  depthViewGeometryTestGenerator(/*isCpuOptimized=*/true, /*matchDepthView=*/false),

  depthViewGeometryTestGenerator(/*matchDepthView=*/false),

  fakeDeviceInitParams,

  'immersive-ar', {

    requiredFeatures: ['depth-sensing'],

testing/web-platform/tests/webxr/depth-sensing/cpu/depth_sensing_cpu_pauseResume.https.html

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ const fakeDeviceInitParams = { 
};



xr_session_promise_test("Ensures appropriate data availability with (pause|resume)DepthSensing, `cpu-optimized`",

  pauseResumeTestFunctionGenerator(/*isCpuOptimized=*/true),

  pauseResumeTestFunction,

  fakeDeviceInitParams,

  'immersive-ar', {

    requiredFeatures: ['depth-sensing'],

testing/web-platform/tests/webxr/depth-sensing/cpu/depth_sensing_cpu_staleView.https.html

+1 −1
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ const fakeDeviceInitParams = { 
};



xr_session_promise_test("Ensures getDepthInformation() throws when run with stale XRView, `cpu-optimized`",

  staleViewsTestFunctionGenerator(/*isCpuOptimized=*/true),

  staleViewsTestFunction,

  fakeDeviceInitParams,

  'immersive-ar', {

    requiredFeatures: ['depth-sensing'],