Commit 4b29e21b authored by Jan Grulich's avatar Jan Grulich
Browse files

Bug 1841851 - WebRTC backport: PipeWire capturer: increase buffer size to...

Bug 1841851 - WebRTC backport: PipeWire capturer: increase buffer size to avoid buffer overflow r=jib,webrtc-reviewers,mjf, a=dsmith

This is a simple backport of an WebRTC upstream change.

Upstream commit: 8fcc6df79daf1810cd4ecdb8d2ef1d361abfdc9c

Differential Revision: https://phabricator.services.mozilla.com/D183355
parent d2425e4c
Loading
Loading
Loading
Loading
+3 −3
Original line number Diff line number Diff line
@@ -281,7 +281,7 @@ void SharedScreenCastStreamPrivate::OnStreamParamChanged(

  that->stream_size_ = DesktopSize(width, height);

  uint8_t buffer[1024] = {};
  uint8_t buffer[2048] = {};
  auto builder = spa_pod_builder{buffer, sizeof(buffer)};

  // Setup buffers and meta header for new format.
@@ -365,7 +365,7 @@ void SharedScreenCastStreamPrivate::OnRenegotiateFormat(void* data, uint64_t) {
  {
    PipeWireThreadLoopLock thread_loop_lock(that->pw_main_loop_);

    uint8_t buffer[2048] = {};
    uint8_t buffer[4096] = {};

    spa_pod_builder builder = spa_pod_builder{buffer, sizeof(buffer)};

@@ -483,7 +483,7 @@ bool SharedScreenCastStreamPrivate::StartScreenCastStream(

    pw_stream_add_listener(pw_stream_, &spa_stream_listener_,
                           &pw_stream_events_, this);
    uint8_t buffer[2048] = {};
    uint8_t buffer[4096] = {};

    spa_pod_builder builder = spa_pod_builder{buffer, sizeof(buffer)};

+1 −0
Original line number Diff line number Diff line
We cherry-picked this in bug 1841851