Commit 50307024 authored by Cosmin Sabou's avatar Cosmin Sabou
Browse files

Backed out 3 changesets (bug 675943) for causing wpt unexpected passes. 

Backed out changeset 56d084bfc8b8 (bug 675943)
Backed out changeset 8f514549a81c (bug 675943)
Backed out changeset 33fabcece85d (bug 675943)
parent e9f4d7d4

dom/html/HTMLInputElement.cpp

+1 −11
Original line number Diff line number Diff line
@@ -5853,17 +5853,7 @@ HTMLInputElement::SubmitNamesValues(FormData* aFormData) { 
    value = defaultValue;

  }



  const nsresult rv = aFormData->AddNameValuePair(name, value);

  if (NS_FAILED(rv)) {

    return rv;

  }



  // Submit dirname=dir

  if (DoesDirnameApply()) {

    return SubmitDirnameDir(aFormData);

  }



  return NS_OK;

  return aFormData->AddNameValuePair(name, value);

}



static nsTArray<FileContentData> SaveFileContentData(

dom/html/HTMLInputElement.h

+0 −17
Original line number Diff line number Diff line
@@ -730,13 +730,6 @@ class HTMLInputElement final : public TextControlElement, 
    SetHTMLAttr(nsGkAtoms::usemap, aValue, aRv);

  }



  void GetDirName(nsAString& aValue) {

    GetHTMLAttr(nsGkAtoms::dirname, aValue);

  }

  void SetDirName(const nsAString& aValue, ErrorResult& aRv) {

    SetHTMLAttr(nsGkAtoms::dirname, aValue, aRv);

  }



  nsIControllers* GetControllers(ErrorResult& aRv);

  // XPCOM adapter function widely used throughout code, leaving it as is.

  nsresult GetControllers(nsIControllers** aResult);
@@ -1590,16 +1583,6 @@ class HTMLInputElement final : public TextControlElement, 
    }

  }



  bool DoesDirnameApply() const {

    switch (mType) {

      case FormControlType::InputText:

      case FormControlType::InputSearch:

        return true;

      default:

        return false;

    }

  }



  static bool CreatesDateTimeWidget(FormControlType aType) {

    return aType == FormControlType::InputDate ||

           aType == FormControlType::InputTime ||

dom/html/HTMLTextAreaElement.cpp

+2 −8
Original line number Diff line number Diff line
@@ -706,15 +706,9 @@ HTMLTextAreaElement::SubmitNamesValues(FormData* aFormData) { 
  GetValueInternal(value, false);



  //

  // Submit name=value

  // Submit

  //

  const nsresult rv = aFormData->AddNameValuePair(name, value);

  if (NS_FAILED(rv)) {

    return rv;

  }



  // Submit dirname=dir

  return SubmitDirnameDir(aFormData);

  return aFormData->AddNameValuePair(name, value);

}



void HTMLTextAreaElement::SaveState() {

dom/html/HTMLTextAreaElement.h

+0 −6
Original line number Diff line number Diff line
@@ -169,12 +169,6 @@ class HTMLTextAreaElement final : public TextControlElement, 
    uint32_t cols = aCols ? aCols : DEFAULT_COLS;

    SetUnsignedIntAttr(nsGkAtoms::cols, cols, DEFAULT_COLS, aError);

  }

  void GetDirName(nsAString& aValue) {

    GetHTMLAttr(nsGkAtoms::dirname, aValue);

  }

  void SetDirName(const nsAString& aValue, ErrorResult& aError) {

    SetHTMLAttr(nsGkAtoms::dirname, aValue, aError);

  }

  bool Disabled() { return GetBoolAttr(nsGkAtoms::disabled); }

  void SetDisabled(bool aDisabled, ErrorResult& aError) {

    SetHTMLBoolAttr(nsGkAtoms::disabled, aDisabled, aError);

dom/html/nsGenericHTMLElement.cpp

+0 −18
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ 
#include "mozilla/StaticPrefs_layout.h"

#include "mozilla/StaticPrefs_accessibility.h"



#include "mozilla/dom/FormData.h"

#include "nscore.h"

#include "nsGenericHTMLElement.h"

#include "nsAttrValueInlines.h"
@@ -2813,23 +2812,6 @@ bool nsGenericHTMLFormControlElement::IsAutocapitalizeInheriting() const { 
         type == FormControlType::Select || type == FormControlType::Textarea;

}



nsresult nsGenericHTMLFormControlElement::SubmitDirnameDir(

    FormData* aFormData) {

  // Submit dirname=dir if element has non-empty dirname attribute

  if (HasAttr(kNameSpaceID_None, nsGkAtoms::dirname)) {

    nsAutoString dirname;

    GetAttr(kNameSpaceID_None, nsGkAtoms::dirname, dirname);

    if (!dirname.IsEmpty()) {

      const Directionality eDir = GetDirectionality();

      MOZ_ASSERT(eDir == eDir_RTL || eDir == eDir_LTR,

                 "The directionality of an element is either ltr or rtl");

      const nsString dir = eDir == eDir_LTR ? u"ltr"_ns : u"rtl"_ns;

      return aFormData->AddNameValuePair(dirname, dir);

    }

  }

  return NS_OK;

}



//----------------------------------------------------------------------



static const nsAttrValue::EnumTable kPopoverTargetActionTable[] = {