Commit 5e9f0cd3 authored by ma1's avatar ma1 Committed by Beatriz Rizental
Browse files

BB 41918: Option to reuse last window size when letterboxing is enabled.

parent d33e3384

browser/app/profile/001-base-profile.js

+2 −0
Changes for browser/app/profile/001-base-profile.js: 2 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -450,6 +450,8 @@ pref("privacy.resistFingerprinting.letterboxing", true); 
pref("privacy.resistFingerprinting.letterboxing.vcenter", true);

// tor-browser#41917: Letterboxing gradient background

pref("privacy.resistFingerprinting.letterboxing.gradient", true);

// tor-browser#41918: Should we reuse last window sizes if letterboxing is enabled

pref("privacy.resistFingerprinting.letterboxing.rememberSize", false);

// tor-browser#43402: Avoid a resize from the skeleton to the newwin size.

// Should be fixed in ESR-140 with Bug 1448423.

pref("browser.startup.blankWindow", false);

browser/components/BrowserGlue.sys.mjs

+5 −0
Changes for browser/components/BrowserGlue.sys.mjs: 5 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -1898,6 +1898,11 @@ BrowserGlue.prototype = { 
      return;

    }



    // We don't want to mess up with RFP new window / letterboxing machinery.

    if (Services.prefs.getBoolPref("privacy.resistFingerprinting", false)) {

      return;

    }



    let store = Services.xulStore;

    let getValue = attr =>

      store.getValue(AppConstants.BROWSER_CHROME_URL, "main-window", attr);

dom/base/nsContentUtils.cpp

+12 −0
Changes for dom/base/nsContentUtils.cpp: 12 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -2744,6 +2744,18 @@ void nsContentUtils::CalcRoundedWindowSizeForResistingFingerprinting( 
  *aOutputHeight = resultHeight;

}



bool nsContentUtils::ShouldRoundWindowSizeForResistingFingerprinting() {

  return !(

      Preferences::GetBool("privacy.resistFingerprinting.letterboxing",

                           false) &&

      // We want to round window size at least once in the browser's life time:

      // AppWindow::ForceRoundedDimensions() will set this preference to true.

      Preferences::GetBool(

          "privacy.resistFingerprinting.letterboxing.didForceSize", false) &&

      Preferences::GetBool(

          "privacy.resistFingerprinting.letterboxing.rememberSize", false));

}



bool nsContentUtils::ThreadsafeIsCallerChrome() {

  return NS_IsMainThread() ? IsCallerChrome()

                           : IsCurrentThreadRunningChromeWorker();

dom/base/nsContentUtils.h

+4 −0
Changes for dom/base/nsContentUtils.h: 4 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -408,6 +408,10 @@ class nsContentUtils { 
      bool aSetOuterWidth, bool aSetOuterHeight, int32_t* aOutputWidth,

      int32_t* aOutputHeight);



  // Tell if we actually want to round size of new windows for RFP,

  // depending on letterboxing status and user's preference.

  static bool ShouldRoundWindowSizeForResistingFingerprinting();



  /**

   * Returns the parent node of aChild crossing document boundaries, but skips

   * any cross-process parent frames and continues with the nearest in-process

toolkit/components/resistfingerprinting/RFPHelper.sys.mjs

+5 −0
Changes for toolkit/components/resistfingerprinting/RFPHelper.sys.mjs: 5 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -19,6 +19,8 @@ const kPrefLetterboxingVcenter = 
  "privacy.resistFingerprinting.letterboxing.vcenter";

const kPrefLetterboxingGradient =

  "privacy.resistFingerprinting.letterboxing.gradient";

const kPrefLetterboxingDidForceSize =

  "privacy.resistFingerprinting.letterboxing.didForceSize";



const kTopicDOMWindowOpened = "domwindowopened";
@@ -142,6 +144,7 @@ class _RFPHelper { 
  _handlePrefChanged(data) {

    switch (data) {

      case kPrefResistFingerprinting:

        Services.prefs.clearUserPref(kPrefLetterboxingDidForceSize);

        this._handleResistFingerprintingChanged();

        break;

      case kPrefSpoofEnglish:
@@ -149,6 +152,8 @@ class _RFPHelper { 
        this._handleSpoofEnglishChanged();

        break;

      case kPrefLetterboxing:

        Services.prefs.clearUserPref(kPrefLetterboxingDidForceSize);

      // fall-through

      case kPrefLetterboxingVcenter:

      case kPrefLetterboxingGradient:

        this._handleLetterboxingPrefChanged();