Commit 6b840f4f authored by Pier Angelo Vendrame's avatar Pier Angelo Vendrame 🎃
Browse files

fixup! Bug 40933: Add tor-launcher functionality 

Bug 42636: A bad bridge line might get TBA stuck.

A while ago I reworked the relationship between TorSettings and
TorProvider. While doing so I was too strict, and a failure to push
settings during initialization will stop the initialization itself,
which will result in TBA stuck at the splash screen.

The problem appears also on desktop (the user will get a prompt that
asks to restart Tor, even though it is not perfect, see #21053).
However, on desktop the user can go to the settings and deleting the
bridges from there (which is not an optimal experience anyway).
parent 66463ec9

toolkit/components/tor-launcher/TorProvider.sys.mjs

+1 −3
Original line number Diff line number Diff line
@@ -232,11 +232,9 @@ export class TorProvider { 
        await this.writeSettings(lazy.TorSettings.getSettings());

      } catch (e) {

        logger.warn(

          "Failed to initialize TorSettings or to write our settings, so uninitializing.",

          "Failed to initialize TorSettings or to write our initial settings. Continuing the initialization anyway.",

          e

        );

        this.uninit();

        throw e;

      }

    }