Commit 80f441a2 authored by Emilio Cobos Álvarez's avatar Emilio Cobos Álvarez
Browse files

Bug 1683188 - BrowserChild::MakeHidden() shouldn't mess with tab state. r=nika, a=jcristau

I flagged this as sketchy before (though it was trying to preserve
existing behavior).

However now that that state propagates to the parent process and races
with the state that the parent process reads, it started causing
correctness issues.

Just remove this line, it shouldn't be needed. I'm not sure how to write
a test for this, unfortunately :(

Differential Revision: https://phabricator.services.mozilla.com/D100971
parent 6ae3ac51
......@@ -2879,14 +2879,6 @@ void BrowserChild::MakeHidden() {
}
}
// FIXME(emilio): The lack of parallelism between this and MakeVisible is a
// bit suspect, but I guess we don't always want the front-end to manage the
// tab visibility.
if (mIsTopLevel && mBrowsingContext && mBrowsingContext->IsActive()) {
Unused << mBrowsingContext->SetExplicitActive(
dom::ExplicitActiveStatus::None);
}
if (mPuppetWidget) {
mPuppetWidget->Show(false);
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment