Commit 8f5a9a81 authored by Kathleen Brade's avatar Kathleen Brade Committed by Pier Angelo Vendrame
Browse files

BB 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. 

Hide elements on about:logins that mention sync, "Firefox LockWise", and
Mozilla's LockWise mobile apps.

Disable the "Create New Login" button when security.nocertdb is true.
parent 74fab880

browser/components/aboutlogins/AboutLoginsParent.sys.mjs

+2 −0
Original line number Diff line number Diff line
@@ -49,6 +49,7 @@ ChromeUtils.defineLazyGetter(lazy, "AboutLoginsL10n", () => { 
const ABOUT_LOGINS_ORIGIN = "about:logins";

const AUTH_TIMEOUT_MS = 5 * 60 * 1000; // 5 minutes

const PRIMARY_PASSWORD_NOTIFICATION_ID = "primary-password-login-required";

const NOCERTDB_PREF = "security.nocertdb";



// about:logins will always use the privileged content process,

// even if it is disabled for other consumers such as about:newtab.
@@ -324,6 +325,7 @@ export class AboutLoginsParent extends JSWindowActorParent { 
          Services.policies.isAllowed("profileImport") &&

          AppConstants.platform != "linux",

        preselectedLogin: this.preselectedLogin,

        canCreateLogins: !Services.prefs.getBoolPref(NOCERTDB_PREF, false),

      });



      await AboutLogins.sendAllLoginRelatedObjects(

browser/components/aboutlogins/content/aboutLogins.css

+5 −0
Original line number Diff line number Diff line
@@ -68,6 +68,11 @@ login-item[data-editing="true"] + login-intro, 
  display: none;

}



/* Do not promote Mozilla Sync. */

login-intro {

  display: none !important;

}



.heading-wrapper {

  display: flex;

  justify-content: center;

browser/components/aboutlogins/content/aboutLogins.mjs

+1 −0
Original line number Diff line number Diff line
@@ -133,6 +133,7 @@ window.addEventListener("AboutLoginsChromeToContent", event => { 
      gElements.loginList.setSortDirection(event.detail.value.selectedSort);

      document.documentElement.classList.add("initialized");

      gElements.loginList.classList.add("initialized");

      gElements.loginList.canCreateLogins = event.detail.value.canCreateLogins;

      break;

    }

    case "ShowLoginItemError": {

browser/components/aboutlogins/content/components/fxaccounts-button.css

+5 −0
Original line number Diff line number Diff line
@@ -8,6 +8,11 @@ 
  align-items: center;

}



/* Do not promote Mozilla Sync. */

.logged-out-view {

  display: none !important;

}



.fxaccounts-extra-text {

  /* Only show at most 3 lines of text to limit the

     text from overflowing the header. */

browser/components/aboutlogins/content/components/login-command-button.mjs

+4 −1
Original line number Diff line number Diff line
@@ -48,6 +48,9 @@ export class CreateLoginButton extends MozLitElement { 
  static get properties() {

    return {

      disabled: { type: Boolean, reflect: true },

      // Whether the button is disabled no matter if the "disabled" attribute is

      // switched.

      hardDisabled: { type: Boolean, reflect: true },

    };

  }
@@ -62,7 +65,7 @@ export class CreateLoginButton extends MozLitElement { 
        l10nId: "create-login-button",

        variant: "icon-button",

        icon: "chrome://global/skin/icons/plus.svg",

        disabled: this.disabled,

        disabled: this.disabled || this.hardDisabled,

      })}

    `;

  }