Commit a33d5f55 authored by Pier Angelo Vendrame's avatar Pier Angelo Vendrame 🎃
Browse files

fixup! TB 23247: Communicating security expectations for .onion 

TB 45343: Hide the custom roots warning for onion sites.

At the moment, we allow self-signed certificates for onion services.
However, tghere are several warnings we need to hide, as they would be
misleading of the actual situation.

Also, hide any field we get from the certificate, to avoid phishing.

In the future, we may re-evaluate accepting self-certificates from
onion services.
parent 95a61b47

browser/base/content/browser-siteIdentity.js

+13 −1
Changes for browser/base/content/browser-siteIdentity.js: 13 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -1192,7 +1192,11 @@ var gIdentityHandler = { 
      this._updateAttribute(element, "ciphers", ciphers);

      this._updateAttribute(element, "mixedcontent", mixedcontent);

      this._updateAttribute(element, "isbroken", this._isBrokenConnection);

      element.toggleAttribute("customroot", this._hasCustomRoot());

      // tor-browser#45343: hide the custom root warning for Onion sites.

      element.toggleAttribute(

        "customroot",

        this._hasCustomRoot() && !this._uriIsOnionHost

      );

      this._updateAttribute(element, "httpsonlystatus", httpsOnlyStatus);

    }
@@ -1237,6 +1241,14 @@ var gIdentityHandler = { 
      }

    }



    // tor-browser#45343: hide the custom root warning for Onion sites, but also

    // empty the verifier, since it might be a lie.

    if (this._uriIsOnionHost && this._hasCustomRoot()) {

      owner = "";

      supplemental = "";

      verifier = "";

    }



    // Push the appropriate strings out to the UI.

    document.l10n.setAttributes(

      this._identityPopupMainViewHeaderLabel,