Commit b4426c74 authored by Matthew Finkel's avatar Matthew Finkel Committed by Pier Angelo Vendrame
Browse files

TB 40016 [android]: Don't install WebCompat webext. 

Originally, fenix#40016.
parent 6176775f

mobile/android/fenix/.buildconfig.yml

+2 −2
Original line number Diff line number Diff line
@@ -58,8 +58,8 @@ projects: 
    - feature-toolbar

    - feature-top-sites

    - feature-webauthn

    - feature-webcompat

    - feature-webcompat-reporter

#   - feature-webcompat

#   - feature-webcompat-reporter

    - feature-webnotifications

    - lib-crash

    - lib-crash-sentry

mobile/android/fenix/app/build.gradle

+2 −2
Original line number Diff line number Diff line
@@ -639,9 +639,9 @@ dependencies { 
    implementation project(':feature-share')

    implementation project(':feature-accounts-push')

    implementation project(':feature-webauthn')

    implementation project(':feature-webcompat')

//  implementation project(':feature-webcompat')

    implementation project(':feature-webnotifications')

    implementation project(':feature-webcompat-reporter')

//  implementation project(':feature-webcompat-reporter')



    implementation project(':service-pocket')

    implementation project(':service-mars')

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt

+2 −2
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ import mozilla.components.feature.search.ext.waitForSelectedOrDefaultSearchEngin 
import mozilla.components.feature.syncedtabs.commands.GlobalSyncedTabsCommandsProvider

import mozilla.components.feature.top.sites.TopSitesFrecencyConfig

import mozilla.components.feature.top.sites.TopSitesProviderConfig

import mozilla.components.feature.webcompat.reporter.WebCompatReporterFeature

// import mozilla.components.feature.webcompat.reporter.WebCompatReporterFeature

import mozilla.components.lib.crash.CrashReporter

import mozilla.components.service.fxa.manager.SyncEnginesStorage

import mozilla.components.service.sync.logins.LoginsApiException
@@ -709,7 +709,7 @@ open class FenixApplication : LocaleAwareApplication(), Provider { 
                    // TODO: Bug 1953359 - remove the code below in the next release.

                    if (Config.channel.isNightlyOrDebug || Config.channel.isBeta) {

                        logger.debug("Attempting to uninstall the WebCompat Reporter extension")

                        WebCompatReporterFeature.uninstall(components.core.engine)

                        // WebCompatReporterFeature.uninstall(components.core.engine)

                    }

                },

                onUpdatePermissionRequest = components.addonUpdater::onUpdatePermissionRequest,

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/Core.kt

+1 −2
Original line number Diff line number Diff line
@@ -78,7 +78,6 @@ import mozilla.components.feature.session.middleware.undo.UndoMiddleware 
import mozilla.components.feature.sitepermissions.OnDiskSitePermissionsStorage

import mozilla.components.feature.top.sites.DefaultTopSitesStorage

import mozilla.components.feature.top.sites.PinnedSiteStorage

import mozilla.components.feature.webcompat.WebCompatFeature

import mozilla.components.feature.webnotifications.WebNotificationFeature

import mozilla.components.lib.dataprotect.SecureAbove22Preferences

import mozilla.components.service.digitalassetlinks.RelationChecker
@@ -229,7 +228,7 @@ class Core( 
            defaultSettings,

            geckoRuntime,

        ).also {

            WebCompatFeature.install(it)

            // WebCompatFeature.install(it)

            TorBrowserFeatures.install(context, it)

        }

    }

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt

+8 −8
Original line number Diff line number Diff line
@@ -418,13 +418,13 @@ open class DefaultToolbarMenu( 
        }

    }



    private val reportBrokenSite = BrowserMenuImageText(

        label = context.getString(R.string.browser_menu_webcompat_reporter),

        imageResource = R.drawable.mozac_ic_lightbulb_24,

        iconTintColorResource = primaryTextColor(),

    ) {

        onItemTapped.invoke(ToolbarMenu.Item.ReportBrokenSite)

    }

    // private val reportBrokenSite = BrowserMenuImageText(

    //     label = context.getString(R.string.browser_menu_webcompat_reporter),

    //     imageResource = R.drawable.mozac_ic_lightbulb_24,

    //     iconTintColorResource = primaryTextColor(),

    // ) {

    //     onItemTapped.invoke(ToolbarMenu.Item.ReportBrokenSite)

    // }



    @VisibleForTesting(otherwise = PRIVATE)

    val coreMenuItems by lazy {
@@ -446,7 +446,7 @@ open class DefaultToolbarMenu( 
                // openInRegularTabItem.apply { visible = ::shouldShowOpenInRegularTab },

                customizeReaderView.apply { visible = ::shouldShowReaderViewCustomization },

                openInApp.apply { visible = ::shouldShowOpenInApp },

                reportBrokenSite.apply { visible = ::shouldShowWebCompatReporter },

                // reportBrokenSite.apply { visible = ::shouldShowWebCompatReporter },

                BrowserMenuDivider(),

                addToHomeScreenItem.apply { visible = ::canAddToHomescreen },

                addAppToHomeScreenItem.apply { visible = ::canAddAppToHomescreen },