Commit bd5eb1b3 authored by Mellina Yonashiro's avatar Mellina Yonashiro
Browse files

Bug 1537772 - Change wording in UI from `runtime` to `browser` r=jdescottes,flod 

Differential Revision: https://phabricator.services.mozilla.com/D24664

--HG--
extra : moz-landing-system : lando
parent c68614df

devtools/client/aboutdebugging-new/src/components/CompatibilityWarning.js

+3 −3
Original line number Diff line number Diff line
@@ -38,15 +38,15 @@ class CompatibilityWarning extends PureComponent { 
    switch (status) {

      case COMPATIBILITY_STATUS.TOO_OLD:

        statusClassName = "js-compatibility-warning-too-old";

        localizationId = "about-debugging-runtime-version-too-old";

        localizationId = "about-debugging-browser-version-too-old";

        break;

      case COMPATIBILITY_STATUS.TOO_RECENT:

        statusClassName = "js-compatibility-warning-too-recent";

        localizationId = "about-debugging-runtime-version-too-recent";

        localizationId = "about-debugging-browser-version-too-recent";

        break;

      case COMPATIBILITY_STATUS.TOO_OLD_67_DEBUGGER:

        statusClassName = "js-compatibility-warning-too-old-67-debugger";

        localizationId = "about-debugging-runtime-version-too-old-67-debugger";

        localizationId = "about-debugging-browser-version-too-old-67-debugger";

        break;

    }

devtools/client/aboutdebugging-new/src/components/sidebar/SidebarRuntimeItem.js

+1 −1
Original line number Diff line number Diff line
@@ -55,7 +55,7 @@ class SidebarRuntimeItem extends PureComponent { 
    const { deviceName, getString, isUnknown, name } = this.props;



    const displayName = isUnknown ?

      getString("about-debugging-sidebar-runtime-item-waiting-for-runtime") : name;

      getString("about-debugging-sidebar-runtime-item-waiting-for-browser") : name;



    const localizationId = deviceName

      ? "about-debugging-sidebar-runtime-item-name"

devtools/client/aboutdebugging-new/src/middleware/process-component-data.js

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ function toMainProcessComponentData(process) { 
  const id = process.processFront.actorID;

  const icon = "chrome://devtools/skin/images/settings.svg";

  const name = l10n.getString("about-debugging-main-process-name");

  const description = l10n.getString("about-debugging-main-process-description");

  const description = l10n.getString("about-debugging-main-process-description2");



  return {

    name,

devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_process_main.js

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ add_task(async function() { 
  info("Check debug target item of the main process");

  const mainProcessItem = findDebugTargetByText(MAIN_PROCESS_NAME, document);

  ok(mainProcessItem, "Debug target item of the main process should display");

  ok(mainProcessItem.textContent.includes("Main Process for the target runtime"),

  ok(mainProcessItem.textContent.includes("Main Process for the target browser"),

     "Debug target item of the main process should contains the description");



  info("Inspect main process");

devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_sidebar_usb_unknown_runtime.js

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ add_task(async function() { 
  const usbRuntimeSidebarItem = findSidebarItemByText("test device name", document);



  const itemText = usbRuntimeSidebarItem.textContent;

  ok(itemText.includes("Waiting for runtime"), "Sidebar item shows Waiting for runtime");

  ok(itemText.includes("Waiting for browser"), "Sidebar item shows Waiting for browser");

  ok(!itemText.includes(RUNTIME_NAME), "Sidebar item does not show the runtime name");



  const hasConnectButton = usbRuntimeSidebarItem.querySelector(".js-connect-button");