Bug 1683658 - Associate the pages-per-sheet label with the select/picker. r=mstriemer, a=jcristau

Differential Revision: https://phabricator.services.mozilla.com/D101410

toolkit/components/printing/content/print.html

@@ -169,7 +169,7 @@
             </section>
 
             <section id="pages-per-sheet" class="section-block" hidden>
-              <label id="pages-per-sheet-label" class="block-label" data-l10n-id="printui-pages-per-sheet"></label>
+              <label id="pages-per-sheet-label" for="pages-per-sheet-picker" class="block-label" data-l10n-id="printui-pages-per-sheet"></label>
               <select is="setting-select" id="pages-per-sheet-picker" class="row" data-setting-name="numPagesPerSheet">
                 <option value="1">1</option>
                 <option value="4">4</option>

toolkit/components/printing/tests/browser.ini

@@ -30,6 +30,7 @@ skip-if = (verify && (os == 'mac')) # bug 1675609
 [browser_print_page_range.js]
 [browser_print_scaling.js]
 [browser_sheet_count.js]
+[browser_ui_labels.js]
 [browser_window_print.js]
 support-files =
   file_window_print.html

toolkit/components/printing/tests/browser_ui_labels.js

+/* Any copyright is dedicated to the Public Domain.
+   http://creativecommons.org/publicdomain/zero/1.0/ */
+
+"use strict";
+
+add_task(async function test_FormFieldLabels() {
+  await PrintHelper.withTestPage(async helper => {
+    await helper.startPrint();
+
+    let fields = Array.from(helper.get("print").elements);
+    for (let field of fields) {
+      if (field.localName == "button") {
+        continue;
+      }
+      ok(
+        field.labels.length ||
+          field.hasAttribute("aria-label") ||
+          field.hasAttribute("aria-labelledby"),
+        `Field ${field.localName}#${field.id} should be labelled`
+      );
+    }
+  });
+});