Commit c17eea11 authored by Gijs Kruitbosch's avatar Gijs Kruitbosch
Browse files

Bug 1547496 - remove warning for minimum font sizes being big as internal...

Bug 1547496 - remove warning for minimum font sizes being big as internal pages are no longer affected, r=mconley,flod

This warning was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1047586 .
As a result of https://bugzilla.mozilla.org/show_bug.cgi?id=1528712 , internal pages
are no longer affected by this change. Instead, they obey the OS font size
configuration, in which we cannot warn. So let's remove the now-inaccurate warning dialog.

Differential Revision: https://phabricator.services.mozilla.com/D29218

--HG--
extra : moz-landing-system : lando
parent ef27eb34
......@@ -91,30 +91,4 @@ var gFontsDialog = {
var useDocumentFonts = document.getElementById("useDocumentFonts");
return useDocumentFonts.checked ? 1 : 0;
},
async confirmMinSizeChange() {
let menulist = document.getElementById("minSize");
let preference = menulist.getAttribute("preference");
let defaultValue = Preferences.get(preference).valueFromPreferences;
let oldValue = Preferences.get(preference).value;
let newValue = menulist.value;
if (newValue <= 24 || newValue == defaultValue) {
return;
}
let [title, warningMessage, confirmLabel] = await document.l10n.formatValues([
{id: "fonts-very-large-warning-title"},
{id: "fonts-very-large-warning-message"},
{id: "fonts-very-large-warning-accept"},
]);
let {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
let flags = Services.prompt.BUTTON_POS_1 * Services.prompt.BUTTON_TITLE_CANCEL |
Services.prompt.BUTTON_POS_0 * Services.prompt.BUTTON_TITLE_IS_STRING |
Services.prompt.BUTTON_POS_1_DEFAULT;
let buttonChosen = Services.prompt.confirmEx(window, title, warningMessage, flags, confirmLabel, null, "", "", {});
if (buttonChosen != 0) {
menulist.value = oldValue;
}
},
};
......@@ -205,7 +205,7 @@
<label data-l10n-id="fonts-minsize" control="minSize"/>
<!-- Please don't remove the wrapping hbox/vbox/box for these elements. It's used to properly compute the search tooltip position. -->
<hbox>
<menulist id="minSize" oncommand="gFontsDialog.confirmMinSizeChange();">
<menulist id="minSize">
<menupopup>
<menuitem value="0" data-l10n-id="fonts-minsize-none"/>
<menuitem value="9" label="9"/>
......
......@@ -152,10 +152,6 @@ fonts-languages-fallback-name-vietnamese =
fonts-languages-fallback-name-other =
.label = Other (incl. Western European)
fonts-very-large-warning-title = Large minimum font size
fonts-very-large-warning-message = You have selected a very large minimum font size (more than 24 pixels). This may make it difficult or impossible to use some important configuration pages like this one.
fonts-very-large-warning-accept = Keep my changes anyway
# Variables:
# $name {string, "Arial"} - Name of the default font
fonts-label-default =
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment