Commit c6b63cee authored by Daisuke Akatsuka's avatar Daisuke Akatsuka
Browse files

Bug 1749740: Add a tooltip for the X close button. r=adw, a=RyanVM 

Differential Revision: https://phabricator.services.mozilla.com/D135755
parent e88ab3da

browser/components/urlbar/content/firefoxSuggest.ftl

+3 −0
Original line number Diff line number Diff line
@@ -110,6 +110,9 @@ firefox-suggest-onboarding-introduction-title-7 = 


##



firefox-suggest-onboarding-introduction-close-button =

  .title = Close



firefox-suggest-onboarding-introduction-next-button-1 = Find out how

firefox-suggest-onboarding-introduction-next-button-2 = Find out more

browser/components/urlbar/content/quicksuggestOnboarding.html

+2 −1
Original line number Diff line number Diff line
@@ -22,8 +22,9 @@ 
        aria-labelledby="introduction-title">

    <section id="introduction-section">

      <button id="onboardingClose"

              class="ghost-button"

              tabindex="2"

              class="ghost-button">

              data-l10n-id="firefox-suggest-onboarding-introduction-close-button">

        <img src="chrome://global/skin/icons/close.svg" />

      </button>

      <span class="logo" role="presentation"></span>

browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_onboardingDialog.js

+2 −1
Original line number Diff line number Diff line
@@ -176,9 +176,10 @@ add_task(async function close() { 
      info("Calling showOnboardingDialog");

      const { win, maybeShowPromise } = await showOnboardingDialog();



      info("Check the visibility of the close button");

      info("Check the status of the close button");

      const closeButton = win.document.getElementById("onboardingClose");

      Assert.ok(BrowserTestUtils.is_visible(closeButton));

      Assert.equal(closeButton.getAttribute("title"), "Close");



      info("Click on the close button");

      closeButton.click();