Commit cc120aa3 authored by Markus Stange's avatar Markus Stange
Browse files

Bug 1573343 - Make the aInvalidRegion parameter of EndRemoteDrawing a const... 

Bug 1573343 - Make the aInvalidRegion parameter of EndRemoteDrawing a const reference rather than a regular reference. r=mattwoodrow

There's no point in mutating it, and nobody does.

Differential Revision: https://phabricator.services.mozilla.com/D41679

--HG--
extra : moz-landing-system : lando
parent 9fd442a1

widget/CompositorWidget.h

+3 −2
Original line number Diff line number Diff line
@@ -162,8 +162,9 @@ class CompositorWidget { 
   * after each composition.

   */

  virtual void EndRemoteDrawing() {}

  virtual void EndRemoteDrawingInRegion(gfx::DrawTarget* aDrawTarget,

                                        LayoutDeviceIntRegion& aInvalidRegion) {

  virtual void EndRemoteDrawingInRegion(

      gfx::DrawTarget* aDrawTarget,

      const LayoutDeviceIntRegion& aInvalidRegion) {

    EndRemoteDrawing();

  }

widget/InProcessCompositorWidget.cpp

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ void InProcessCompositorWidget::EndRemoteDrawing() { 
}



void InProcessCompositorWidget::EndRemoteDrawingInRegion(

    gfx::DrawTarget* aDrawTarget, LayoutDeviceIntRegion& aInvalidRegion) {

    gfx::DrawTarget* aDrawTarget, const LayoutDeviceIntRegion& aInvalidRegion) {

  mWidget->EndRemoteDrawingInRegion(aDrawTarget, aInvalidRegion);

}

widget/InProcessCompositorWidget.h

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ class InProcessCompositorWidget : public CompositorWidget { 
  virtual void EndRemoteDrawing() override;

  virtual void EndRemoteDrawingInRegion(

      gfx::DrawTarget* aDrawTarget,

      LayoutDeviceIntRegion& aInvalidRegion) override;

      const LayoutDeviceIntRegion& aInvalidRegion) override;

  virtual void CleanupRemoteDrawing() override;

  virtual void CleanupWindowEffects() override;

  virtual bool InitCompositor(layers::Compositor* aCompositor) override;

widget/gtk/GtkCompositorWidget.cpp

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ GtkCompositorWidget::StartRemoteDrawingInRegion( 
}



void GtkCompositorWidget::EndRemoteDrawingInRegion(

    gfx::DrawTarget* aDrawTarget, LayoutDeviceIntRegion& aInvalidRegion) {

    gfx::DrawTarget* aDrawTarget, const LayoutDeviceIntRegion& aInvalidRegion) {

  mProvider.EndRemoteDrawingInRegion(aDrawTarget, aInvalidRegion);

}

widget/gtk/GtkCompositorWidget.h

+3 −2
Original line number Diff line number Diff line
@@ -50,8 +50,9 @@ class GtkCompositorWidget : public CompositorWidget, 
  already_AddRefed<gfx::DrawTarget> StartRemoteDrawingInRegion(

      LayoutDeviceIntRegion& aInvalidRegion,

      layers::BufferMode* aBufferMode) override;

  void EndRemoteDrawingInRegion(gfx::DrawTarget* aDrawTarget,

                                LayoutDeviceIntRegion& aInvalidRegion) override;

  void EndRemoteDrawingInRegion(

      gfx::DrawTarget* aDrawTarget,

      const LayoutDeviceIntRegion& aInvalidRegion) override;

  uintptr_t GetWidgetKey() override;



  LayoutDeviceIntSize GetClientSize() override;