Commit d2d045a3 authored by clairehurst's avatar clairehurst 🌱 Committed by Pier Angelo Vendrame
Browse files

TB 44653: [android] Disable 'Allow search suggestions in private sessions'... 

TB 44653: [android] Disable 'Allow search suggestions in private sessions' prompt presented in RR 148 android
parent 5c0bd259

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/FenixSearchMiddleware.kt

+1 −6
Changes for mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/FenixSearchMiddleware.kt: 1 added line, 6 removed lines.
Original line number Diff line number Diff line
@@ -246,12 +246,7 @@ class FenixSearchMiddleware( 


        store.dispatch(SearchSuggestionsVisibilityUpdated(shouldShowSuggestions))



        val showPrivatePrompt = with(store.state) {

            !settings.showSearchSuggestionsInPrivateOnboardingFinished &&

                    browsingModeManager.mode.isPrivate &&

                    !isSearchSuggestionsFeatureEnabled() &&

                    query.isNotBlank() && url != query

        }

        val showPrivatePrompt = false



        store.dispatch(

            SearchFragmentAction.AllowSearchSuggestionsInPrivateModePrompt(

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarComposable.kt

+1 −1
Changes for mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarComposable.kt: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -162,7 +162,7 @@ class AwesomeBarComposable( 
        }



        if (isSearchActive) {

            if (state.showSearchSuggestionsHint) {

            if (false) {

                PrivateSuggestionsCard(

                    onSearchSuggestionsInPrivateModeAllowed = {

                       components.settings.shouldShowSearchSuggestionsInPrivate = true

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt

+1 −4
Changes for mobile/android/fenix/app/src/main/java/org/mozilla/fenix/utils/Settings.kt: 1 added line, 4 removed lines.
Original line number Diff line number Diff line
@@ -1707,10 +1707,7 @@ class Settings( 
        default = false,

    )



    var showSearchSuggestionsInPrivateOnboardingFinished by booleanPreference(

        appContext.getPreferenceKey(R.string.pref_key_show_search_suggestions_in_private_onboarding),

        default = false,

    )

    var showSearchSuggestionsInPrivateOnboardingFinished = false



    fun incrementVisitedInstallableCount() = pwaInstallableVisitCount.increment()