Commit d3189080 authored by Andrea Marchesini's avatar Andrea Marchesini Committed by amarchesini@mozilla.com
Browse files

Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests,... 

Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau

Differential Revision: https://phabricator.services.mozilla.com/D248600
parent 79464402

browser/base/content/test/sanitize/head.js

+2 −2
Original line number Diff line number Diff line
@@ -69,7 +69,7 @@ function createHostCookie(host, originAttributes) { 
    false,

    Date.now() + 24000 * 60 * 60,

    originAttributes,

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTPS

  );

  is(cv.result, Ci.nsICookieValidation.eOK, "Valid cookie");
@@ -86,7 +86,7 @@ function createDomainCookie(host, originAttributes) { 
    false,

    Date.now() + 24000 * 60 * 60,

    originAttributes,

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTPS

  );

  is(cv.result, Ci.nsICookieValidation.eOK, "Valid cookie");

browser/components/backup/tests/marionette/test_backup.py

+1 −1
Original line number Diff line number Diff line
@@ -316,7 +316,7 @@ class BackupTest(MarionetteTestCase): 
              false,

              Date.now() / 1000 + 1,

              {},

              Ci.nsICookie.SAMESITE_NONE,

              Ci.nsICookie.SAMESITE_UNSET,

              Ci.nsICookie.SCHEME_HTTP

            );

          })().then(outerResolve);

browser/components/backup/tests/xpcshell/test_BackupService_regeneration.js

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ function addTestCookie(isSessionCookie) { 
    isSessionCookie,

    Date.now() / 1000 + 1,

    COOKIE_ORIGIN_ATTRIBUTES,

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTP

  );

  Assert.equal(cv.result, Ci.nsICookieValidation.eOK);

browser/components/downloads/test/browser/browser_downloads_jsonview.js

+1 −1
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ add_task(async function test_save_jsonview() { 
    false,

    false,

    false,

    Number.MAX_SAFE_INTEGER,

    Date.now() + 24000 * 60 * 60,

    {},

    Ci.nsICookie.SAMESITE_LAX,

    Ci.nsICookie.SCHEME_HTTPS

browser/components/enterprisepolicies/tests/xpcshell/test_clear_blocked_cookies.js

+5 −5
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ add_task(async function setup() { 
    false,

    expiry,

    {},

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTPS

  );

  Assert.equal(cv.result, Ci.nsICookieValidation.eOK);
@@ -32,7 +32,7 @@ add_task(async function setup() { 
    false,

    expiry,

    {},

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTP

  );

  Assert.equal(cv.result, Ci.nsICookieValidation.eOK);
@@ -47,7 +47,7 @@ add_task(async function setup() { 
    false,

    expiry,

    {},

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTPS

  );

  Assert.equal(cv.result, Ci.nsICookieValidation.eOK);
@@ -62,7 +62,7 @@ add_task(async function setup() { 
    false,

    expiry,

    {},

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTP

  );

  Assert.equal(cv.result, Ci.nsICookieValidation.eOK);
@@ -77,7 +77,7 @@ add_task(async function setup() { 
    false,

    expiry,

    {},

    Ci.nsICookie.SAMESITE_NONE,

    Ci.nsICookie.SAMESITE_UNSET,

    Ci.nsICookie.SCHEME_HTTPS

  );

  Assert.equal(cv.result, Ci.nsICookieValidation.eOK);