Commit d81b0bfd authored by Emilio Cobos Álvarez's avatar Emilio Cobos Álvarez
Browse files

Bug 1835407 - Remove useless check in style sharing cache. r=dholbert 

Useless by the reason described at the end of the comment, we no longer
have such a flag.

Differential Revision: https://phabricator.services.mozilla.com/D179269
parent 216d1c4c

servo/components/style/sharing/mod.rs

+0 −16
Original line number Diff line number Diff line
@@ -879,22 +879,6 @@ impl<E: TElement> StyleSharingCache<E> { 
            if target.local_name() != candidate.element.local_name() {

                return None;

            }

            // Rule nodes and styles are computed independent of the element's

            // actual visitedness, but at the end of the cascade (in

            // `adjust_for_visited`) we do store the visitedness as a flag in

            // style.  (This is a subtle change from initial visited work that

            // landed when computed values were fused, see

            // https://bugzilla.mozilla.org/show_bug.cgi?id=1381635.)

            // So at the moment, we need to additionally compare visitedness,

            // since that is not accounted for by rule nodes alone.

            // FIXME(jryans): This seems like it breaks the constant time

            // requirements of visited, assuming we get a cache hit on only one

            // of unvisited vs. visited.

            // TODO(emilio): We no longer have such a flag, remove this check.

            if target.is_visited_link() != candidate.element.is_visited_link() {

                return None;

            }



            Some(data.share_primary_style())

        })

    }