Commit dd862a51 authored by Mike Perry's avatar Mike Perry Committed by Matthew Finkel
Browse files

Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing 

eBay and Amazon don't treat Tor users very well. Accounts often get locked and
payments reversed.

Also:
Bug 16322: Update DuckDuckGo search engine

We are replacing the clearnet URL with an onion service one (thanks to a
patch by a cypherpunk) and are removing the duplicated DDG search
engine. Duplicating DDG happend due to bug 1061736 where Mozilla
included DDG itself into Firefox. Interestingly, this caused breaking
the DDG search if JavaScript is disabled as the Mozilla engine, which
gets loaded earlier, does not use the html version of the search page.
Moreover, the Mozilla engine tracked where the users were searching from
by adding a respective parameter to the search query. We got rid of that
feature as well.

Also:
This fixes bug 20809: the DuckDuckGo team has changed its server-side
code in a way that lets users with JavaScript enabled use the default
landing page while those without JavaScript available get redirected
directly to the non-JS page. We adapt the search engine URLs
accordingly.

Also fixes bug 29798 by making sure we only specify the Google search
engine we actually ship an .xml file for.

Also regression tests.
parent ad100055

browser/components/search/extensions/ddg-onion/favicon.ico

0 → 100644
+973 B
Loading image diff...

browser/components/search/extensions/ddg-onion/manifest.json

0 → 100644
+26 −0
Original line number Diff line number Diff line 
{

  "name": "DuckDuckGoOnion",

  "description": "Duck Duck Go Onion",

  "manifest_version": 2,

  "version": "1.0",

  "applications": {

    "gecko": {

      "id": "ddg-onion@search.mozilla.org"

    }

  },

  "hidden": true,

  "icons": {

    "16": "favicon.ico"

  },

  "web_accessible_resources": [

    "favicon.ico"

  ],

  "chrome_settings_overrides": {

    "search_provider": {

      "name": "DuckDuckGoOnion",

      "search_url": "https://3g2upl4pq6kufc4m.onion",

      "search_form": "https://3g2upl4pq6kufc4m.onion/?q={searchTerms}",

      "search_url_get_params": "q={searchTerms}"

    }

  }

}
 
 No newline at end of file

browser/components/search/extensions/ddg/favicon.ico

deleted100644 → 0
−5.3 KiB
Loading image diff...

browser/components/search/extensions/ddg/favicon.png

0 → 100644
+1.12 KiB
Loading image diff...

browser/components/search/extensions/ddg/manifest.json

+3 −35
Original line number Diff line number Diff line
@@ -10,50 +10,18 @@ 
  },

  "hidden": true,

  "icons": {

    "16": "favicon.ico"

    "16": "favicon.png"

  },

  "web_accessible_resources": [

    "favicon.ico"

    "favicon.png"

  ],

  "chrome_settings_overrides": {

    "search_provider": {

      "keyword": ["@duckduckgo", "@ddg"],

      "name": "DuckDuckGo",

      "search_url": "https://duckduckgo.com/",

      "search_url": "https://duckduckgo.com",

      "search_form": "https://duckduckgo.com/?q={searchTerms}",

      "search_url_get_params": "q={searchTerms}",

      "params": [

        {

          "name": "t",

          "condition": "purpose",

          "purpose": "contextmenu",

          "value": "ffcm"

        },

        {

          "name": "t",

          "condition": "purpose",

          "purpose": "keyword",

          "value": "ffab"

        },

        {

          "name": "t",

          "condition": "purpose",

          "purpose": "searchbar",

          "value": "ffsb"

        },

        {

          "name": "t",

          "condition": "purpose",

          "purpose": "homepage",

          "value": "ffhp"

        },

        {

          "name": "t",

          "condition": "purpose",

          "purpose": "newtab",

          "value": "ffnt"

        }

      ],

      "suggest_url": "https://ac.duckduckgo.com/ac/",

      "suggest_url_get_params": "q={searchTerms}&type=list"

    }