Commit e0d23fa8 authored by Richard Pospesel's avatar Richard Pospesel Committed by Pier Angelo Vendrame
Browse files

BB 42037: Disable about:firefoxview page

parent c68e5633

browser/base/content/browser.js

+5 −0
Original line number Diff line number Diff line
@@ -5346,6 +5346,11 @@ var FirefoxViewHandler = { 
    }

  },

  openTab(section) {

    if (AppConstants.BASE_BROWSER_VERSION) {

      // about:firefoxview is disabled. tor-browser#42037.

      return;

    }



    if (!CustomizableUI.getPlacementOfWidget(this.BUTTON_ID)) {

      CustomizableUI.addWidgetToArea(

        this.BUTTON_ID,

browser/components/about/AboutRedirector.cpp

+0 −3
Original line number Diff line number Diff line
@@ -75,9 +75,6 @@ static const RedirEntry kRedirMap[] = { 
         nsIAboutModule::URI_CAN_LOAD_IN_PRIVILEGEDABOUT_PROCESS |

         nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT |

         nsIAboutModule::IS_SECURE_CHROME_UI},

    {"firefoxview", "chrome://browser/content/firefoxview/firefoxview.html",

     nsIAboutModule::ALLOW_SCRIPT | nsIAboutModule::IS_SECURE_CHROME_UI |

         nsIAboutModule::HIDE_FROM_ABOUTABOUT},

    {"policies", "chrome://browser/content/policies/aboutPolicies.html",

     nsIAboutModule::ALLOW_SCRIPT | nsIAboutModule::IS_SECURE_CHROME_UI},

    {"privatebrowsing", "chrome://browser/content/aboutPrivateBrowsing.html",

browser/components/about/components.conf

+0 −1
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ pages = [ 
    'framecrashed',

    'logins',

    'loginsimportreport',

    'firefoxview',

    'messagepreview',

    'policies',

    'preferences',

browser/components/moz.build

+0 −1
Original line number Diff line number Diff line
@@ -39,7 +39,6 @@ DIRS += [ 
    "downloads",

    "enterprisepolicies",

    "extensions",

    "firefoxview",

    # Exclude "genai" component. tor-browser#44045.

    "ipprotection",

    "messagepreview",

browser/themes/shared/tabbrowser/tabs.css

+13 −3
Original line number Diff line number Diff line
@@ -1913,14 +1913,24 @@ tab-group { 
  color-scheme: var(--tab-selected-color-scheme);

}



:root:not([privatebrowsingmode]) :is(toolbarbutton, toolbarpaletteitem) ~ #tabbrowser-tabs,

:root[privatebrowsingmode] :is(toolbarbutton:not(#firefox-view-button), toolbarpaletteitem:not(#wrapper-firefox-view-button)) ~ #tabbrowser-tabs {

/* about:firefoxview is disabled in Base Browser. See tor-browser#42037.

 * Therefore we always hide #firefox-view-button, regardless of private

 * browsing. Here we only want to draw the border if there is a non-hidden

 * toolbar item before the tabs.

 * NOTE: Expect merge conflict from bugzilla bug 1917595 and bug 1917599. In

 * these cases we want to keep our selector as-is. */

:root :is(toolbarbutton:not(#firefox-view-button), toolbarpaletteitem:not(#wrapper-firefox-view-button)) ~ #tabbrowser-tabs {

  border-inline-start: var(--tabstrip-inner-border);

  padding-inline-start: 2px;

  margin-inline-start: 2px;

}



:root[privatebrowsingmode] :is(#firefox-view-button, #menu_openFirefoxView) {

/* about:firefoxview is disabled in Base Browser. Always hide the toolbar button

 * and menu item regardless of private browsing. See tor-browser#42037.

 * NOTE: Expect merge conflict from bugzilla bug 1903812 and bug 1917599. In

 * these cases we want to keep our selector as-is. */

#firefox-view-button,

#menu_openFirefoxView {

  display: none;

}