Commit e44cf8eb authored by Emilio Cobos Álvarez's avatar Emilio Cobos Álvarez Committed by ealvarez@mozilla.com
Browse files

Bug 1967551 - Remove native tabbox support.... 

Bug 1967551 - Remove native tabbox support. r=desktop-theme-reviewers,mac-reviewers,win-reviewers,tabbrowser-reviewers,gstoll,mstange,dao

Eventually I want to simplify a lot of how the theming code deals with
overriding border / padding, and this helps with that.

Since bug 1765076 this isn't used anywhere, so I think simplifying this
is the right trade-off. Thunderbird also doesn't use it.

Differential Revision: https://phabricator.services.mozilla.com/D250314
parent e2e0c44c

browser/themes/osx/browser.css

+0 −22
Original line number Diff line number Diff line
@@ -191,28 +191,6 @@ 


.tabbrowser-tab {

  border: none;



  /* FIXME: Are these styles really needed nowadays? */

  &:is([visuallyselected], [multiselected]) {

    /* overriding tabbox.css */

    text-shadow: inherit;



    @media (prefers-color-scheme: light) {

      :root:not([lwtheme]) & {

        /* overriding tabbox.css */

        color: hsl(240, 5%, 5%);

      }

    }

  }

}



#tabbrowser-tabs {

  /* overriding tabbox.css */

  font: message-box;

  align-items: stretch;

  margin-bottom: 0;

  position: static;

  z-index: auto;

}



/* Bookmark drag and drop styles */

browser/themes/shared/tabbrowser/tabs.css

+3 −1
Original line number Diff line number Diff line
@@ -119,6 +119,9 @@ 
}



#tabbrowser-tabs {

  /* Overriding tabbox.css */

  border: 0;



  /* Use a bigger flex value than the searchbar to prevent it from

   * taking all the toolbar space. */

  flex: 1000 1000;
@@ -1572,7 +1575,6 @@ tab-group { 
  flex-direction: column;

  align-content: flex-start;

  grid-gap: var(--space-small);

  padding: 0; /* override tabbox.css on macOS */



  &[overflow]::after {

    content: "";

servo/components/style/values/specified/box.rs

+0 −6
Original line number Diff line number Diff line
@@ -1550,12 +1550,6 @@ pub enum Appearance { 
    /// A status bar in a main application window.

    #[parse(condition = "ParserContext::chrome_rules_enabled")]

    Statusbar,

    /// A single tab in a tab widget.

    #[parse(condition = "ParserContext::chrome_rules_enabled")]

    Tab,

    /// The tab panels container.

    #[parse(condition = "ParserContext::chrome_rules_enabled")]

    Tabpanels,

    /// A single toolbar button (with no associated dropdown).

    #[parse(condition = "ParserContext::chrome_rules_enabled")]

    Toolbarbutton,

toolkit/themes/linux/global/jar.mn

+0 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ toolkit.jar: 
   skin/classic/global/autocomplete.css

   skin/classic/global/global.css

   skin/classic/global/richlistbox.css

   skin/classic/global/tabbox.css

   skin/classic/global/toolbar.css



   skin/classic/global/icons/Authentication.png                (icons/Authentication.png)

toolkit/themes/osx/global/jar.mn

+0 −1
Original line number Diff line number Diff line
@@ -10,7 +10,6 @@ toolkit.jar: 
  skin/classic/global/dialog.css

  skin/classic/global/global.css

  skin/classic/global/richlistbox.css

  skin/classic/global/tabbox.css

  skin/classic/global/toolbar.css

  skin/classic/global/wizard.css

  skin/classic/global/arrow/panelarrow-vertical.svg                  (arrow/panelarrow-vertical.svg)