Commit e87630dc authored by Geoff Brown's avatar Geoff Brown
Browse files

Bug 1744091 - Update test harnesses to run with fission by default, except on... 

Bug 1744091 - Update test harnesses to run with fission by default, except on android; r=perftest-reviewers,releng-reviewers,jmaher,AlexandruIonescu

Run with fission by default in test harnesses, with --disable-fission available as an
option.
Android mach commands automatically set --disable-fission; this can be over-ridden by
--setpref=fission.autostart=true.
fission.autostart is removed from all test profiles.
No changes to wpt, handled already in bug 1743714.

Differential Revision: https://phabricator.services.mozilla.com/D135137
parent 4f740567

layout/tools/reftest/mach_commands.py

+4 −0
Original line number Diff line number Diff line
@@ -168,6 +168,10 @@ class ReftestRunner(MozbuildObject): 
            args.e10s = False

            print("using e10s=False for non-geckoview app")



        # Disable fission until geckoview supports fission by default.

        # Need fission on Android? Use '--setpref fission.autostart=true'

        args.fission = False



        # A symlink and some path manipulations are required so that test

        # manifests can be found both locally and remotely (via a url)

        # using the same relative path.

layout/tools/reftest/reftestcommandline.py

+4 −4
Original line number Diff line number Diff line
@@ -249,11 +249,11 @@ class ReftestArgumentsParser(argparse.ArgumentParser): 
        )



        self.add_argument(

            "--enable-fission",

            action="store_true",

            default=False,

            "--disable-fission",

            action="store_false",

            default=True,

            dest="fission",

            help="Run tests with fission (site isolation) enabled.",

            help="Run tests with fission (site isolation) disabled.",

        )



        self.add_argument(

layout/tools/reftest/remotereftest.py

+0 −3
Original line number Diff line number Diff line
@@ -429,9 +429,6 @@ class RemoteReftest(RefTest): 
        # browser environment

        env = self.buildBrowserEnv(options, profile.profile)



        self.log.info("Running with e10s: {}".format(options.e10s))

        self.log.info("Running with fission: {}".format(options.fission))



        rpm = RemoteProcessMonitor(

            binary,

            self.device,

layout/tools/reftest/runreftest.py

+6 −3
Original line number Diff line number Diff line
@@ -533,6 +533,12 @@ class RefTest(object): 
            options.extraProfileFiles.append(os.path.join(here, "chrome"))



        self.copyExtraFilesToProfile(options, profile)



        self.log.info(

            "Running with e10s: {}".format(prefs["browser.tabs.remote.autostart"])

        )

        self.log.info("Running with fission: {}".format(prefs["fission.autostart"]))



        return profile



    def environment(self, **kwargs):
@@ -879,9 +885,6 @@ class RefTest(object): 
        # browser environment

        env = self.buildBrowserEnv(options, profile.profile)



        self.log.info("Running with e10s: {}".format(options.e10s))

        self.log.info("Running with fission: {}".format(options.fission))



        def timeoutHandler():

            self.handleTimeout(timeout, proc, options.utilityPath, debuggerInfo)

testing/mochitest/mach_commands.py

+4 −0
Original line number Diff line number Diff line
@@ -174,6 +174,10 @@ class MochitestRunner(MozbuildObject): 
            options.e10s = False

            print("using e10s=False for non-geckoview app")



        # Disable fission until geckoview supports fission by default.

        # Need fission on Android? Use '--setpref fission.autostart=true'

        options.fission = False



        return runtestsremote.run_test_harness(parser, options)



    def run_geckoview_junit_test(self, context, **kwargs):