Commit ece40b9c authored by Jan de Mooij's avatar Jan de Mooij
Browse files

Bug 1832582 part 1 - Remove unused IonBytecodeInfo::modifiesArguments flag. r=iain a=pascalc 

Differential Revision: https://phabricator.services.mozilla.com/D178650
parent 630e8929

js/src/jit/BytecodeAnalysis.cpp

+0 −4
Original line number Diff line number Diff line
@@ -252,10 +252,6 @@ IonBytecodeInfo js::jit::AnalyzeBytecodeForIon(JSContext* cx, 


  for (const BytecodeLocation& location : iterator) {

    switch (location.getOp()) {

      case JSOp::SetArg:

        result.modifiesArguments = true;

        break;



      case JSOp::GetName:

      case JSOp::BindName:

      case JSOp::BindVar:

js/src/jit/JitScript.h

+0 −4
Original line number Diff line number Diff line
@@ -57,7 +57,6 @@ class JitZone; 
// in JitScript.

struct IonBytecodeInfo {

  bool usesEnvironmentChain = false;

  bool modifiesArguments = false;

};



// Magic BaselineScript value indicating Baseline compilation has been disabled.
@@ -430,9 +429,6 @@ class alignas(uintptr_t) JitScript final : public TrailingArray { 


  EnvironmentObject* templateEnvironment() const { return templateEnv_.ref(); }



  bool modifiesArguments() const {

    return cachedIonBytecodeInfo().modifiesArguments;

  }

  bool usesEnvironmentChain() const {

    return cachedIonBytecodeInfo().usesEnvironmentChain;

  }

js/src/jit/WarpBuilder.cpp

+0 −2
Original line number Diff line number Diff line
@@ -928,8 +928,6 @@ bool WarpBuilder::build_GetFrameArg(BytecodeLocation loc) { 
}



bool WarpBuilder::build_SetArg(BytecodeLocation loc) {

  MOZ_ASSERT(script_->jitScript()->modifiesArguments());



  uint32_t arg = loc.arg();

  MDefinition* val = current->peek(-1);