Commit f3998136 authored by Geoff Brown's avatar Geoff Brown
Browse files

Bug 1520374 - Simplify error message for "Could not install python package"; r=aryx 

Information like the pip path, package name, etc is useful for debugging, but
not for bug classification: Let's try to collect all such failures in one
"Could not install python package" bug. The full command line and retry
attempt history is still retrievable from the log, for debugging purposes.
parent dab3fdbe

testing/mozharness/mozharness/base/python.py

+1 −3
Original line number Diff line number Diff line
@@ -283,7 +283,6 @@ class VirtualenvMixin(object): 
        if not module and len(requirements) == 1:

            cwd = os.path.dirname(requirements[0])



        quoted_command = subprocess.list2cmdline(command)

        # Allow for errors while building modules, but require a

        # return status of 0.

        self.retry(
@@ -293,8 +292,7 @@ class VirtualenvMixin(object): 
            good_statuses=(0,),

            error_level=WARNING if optional else FATAL,

            error_message=(

                'Could not install python package: '

                + quoted_command + ' failed after %(attempts)d tries!'

                'Could not install python package: failed all attempts.'

            ),

            args=[command, ],

            kwargs={