Commit f80662b1 authored by Andrew Halberstadt's avatar Andrew Halberstadt
Browse files

Bug 1585702 - [lint] Remove temporary hacks now that 'null character' issue is fixed, r=gbrown

Depends on D48113

Differential Revision: https://phabricator.services.mozilla.com/D48209

--HG--
extra : moz-landing-system : lando
parent cb2eb806
......@@ -90,15 +90,6 @@ def lint(paths, config, binary=None, fix=None, setup=None, **lintargs):
orig = signal.signal(signal.SIGINT, signal.SIG_IGN)
proc = ProcessHandler(cmd_args, env=os.environ, stream=None,
shell=shell, universal_newlines=True)
if sys.platform == 'win32':
# Workaround for bug 1585702. According to the win32 docs,
# CreateProcess will use the calling process's env by default. Since we
# are passing in `os.environ` wholesale anyway, setting the env to
# `None` shouldn't make a difference. An alternative workaround would
# be to stop using mozprocess here and use subprocess directly.
proc.env = None
proc.run()
signal.signal(signal.SIGINT, orig)
......
......@@ -39,15 +39,6 @@ def lint(files, config, **kwargs):
proc = ProcessHandler(cmd, env=os.environ, processOutputLine=process_line,
universal_newlines=True)
if sys.platform == 'win32':
# Workaround for bug 1585702. According to the win32 docs,
# CreateProcess will use the calling process's env by default. Since we
# are passing in `os.environ` wholesale anyway, setting the env to
# `None` shouldn't make a difference. An alternative workaround would
# be to stop using mozprocess here and use subprocess directly.
proc.env = None
proc.run()
try:
proc.wait()
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment