- 22 Nov, 2019 9 commits
-
-
Cosmin Sabou authored
Backed out 4 changesets (bug 1570792, bug 1593358, bug 1575905) for causing bug 1593402 to near permafail. CLOSED TREE Backed out changeset 43490702945f (bug 1593358) Backed out changeset cf2f28971e64 (bug 1570792) Backed out changeset 67f284b0e4c2 (bug 1575905) Backed out changeset 13d8e61774f1 (bug 1575905) --HG-- extra : amend_source : 9541e3e941e7b62095715bb4859991bd48ea0489 extra : histedit_source : 51dd3724c2e8b806b2c9e531aa14119ff38f37e4
-
Cosmin Sabou authored
Backed out changeset e9d1379c65f5 (bug 1585904) for browser-chrome failures on browser_pageinfo_security. --HG-- extra : histedit_source : 70a6520faf1fe6c83ae6cba3781d534cc3ae81b6
-
Andrew Halberstadt authored
Differential Revision: https://phabricator.services.mozilla.com/D54369 --HG-- extra : histedit_source : 6728719847f307627f3ff10535169ee71354b14b
-
Stephen Donner authored
Bug 1589267 - Add conditioned-profile support for desktop Firefox in Browsertime; follow-up fix to include missing raptor.py. Differential Revision: https://phabricator.services.mozilla.com/D54378 --HG-- extra : histedit_source : 82d5f3e9ed43f75a2e50fdd220c53142b18f3797
-
Drew Willcoxon authored
Differential Revision: https://phabricator.services.mozilla.com/D54025 --HG-- extra : source : 4126c23bb67c7a950f3683cd4490320ad464d58a
-
Steve Fink authored
Differential Revision: https://phabricator.services.mozilla.com/D54335 --HG-- extra : moz-landing-system : lando
-
Punam Dahiya authored
Bug 1595842 - Import settings wizard dynamic triplets onboarding card for chrome switchers r=fluent-reviewers,k88hudson,flod Differential Revision: https://phabricator.services.mozilla.com/D54176 --HG-- extra : moz-landing-system : lando
-
Dão Gottwald authored
Differential Revision: https://phabricator.services.mozilla.com/D54163 --HG-- extra : moz-landing-system : lando
-
emcminn authored
Differential Revision: https://phabricator.services.mozilla.com/D54354 --HG-- extra : moz-landing-system : lando
-
- 21 Nov, 2019 1 commit
-
-
Andrew Halberstadt authored
Bug 1596426 - [mozbuild] Add a 'manifest_relpath' key to all tests in the TestManifestBackend, r=froydnj I would prefer if this (and the other keys there) were added by the ReftestManifest object instead: https://searchfox.org/mozilla-central/rev/652014ca1183c56bc5f04daf01af180d4e50a91c/layout/tools/reftest/reftest/__init__.py#39 But since there is already precedent here, it's easiest to tag 'manifest_relpath' along with the others. Bug 1590388 will likely handle cleaning all this up. Differential Revision: https://phabricator.services.mozilla.com/D53970 --HG-- extra : moz-landing-system : lando
-
- 22 Nov, 2019 21 commits
-
-
Michael Froman authored
Also, make sure it is disabled for MinGW builds because of Bug 1597408. Differential Revision: https://phabricator.services.mozilla.com/D53286 --HG-- extra : moz-landing-system : lando
-
Chris H-C authored
Depends on D53713 Differential Revision: https://phabricator.services.mozilla.com/D53714 --HG-- extra : moz-landing-system : lando
-
Chris H-C authored
Differential Revision: https://phabricator.services.mozilla.com/D53713 --HG-- extra : moz-landing-system : lando
-
Greg Tatum authored
The native allocations feature added stackwalking that can happen anywhere that memory is allocated. This means that stackwalking happens in places where the execution already has a very large execution stack. Stackwalking was relying on stack-allocated buffers used for merging stacks. This was taking up 64kb of stack space. On Linux, this was causing a stack overflow, as there is only 256kb of stack space. I encountered a crash while using GDB. Using pointer arithmetic, I determined that the stack size before stack walking was around 20kb, and during stackwalking, we overflowed the stack (>256kb). The largest culprit was the JS::ProfilingFrameIterator::Frame jsFrames[MAX_JS_FRAMES]. In addition, Bug 1468789 added another member to the Frame class, also increasing the size of the stack allocation. I changed the implementation to allocate some memory on the CorePS class, and share that with every stackwalk that happens. I tested this loading a large news site, and didn't get any crashes. Differential Revision: https://phabricator.services.mozilla.com/D54072 --HG-- extra : moz-landing-system : lando
-
Chris Manchester authored
Differential Revision: https://phabricator.services.mozilla.com/D54060 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
Differential Revision: https://phabricator.services.mozilla.com/D53169 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
Bug 1568903 - Part 10: Update test_xrayToJS to handle the new AggregateError object and the Promise method. r=peterv,jorendorff Differential Revision: https://phabricator.services.mozilla.com/D51660 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
As with AggregateError, `Promise.any` is only enabled in Nightly. Now that everything is in place, the actual `Promise.any` implementation is relatively straight forward. The only tricky part is probably just the `ThrowAggregateError` function, when the async stack is created to give a better stack trace. Differential Revision: https://phabricator.services.mozilla.com/D51659 --HG-- rename : js/src/jit-test/tests/promise/promise-race-with-non-default-resolving.js => js/src/jit-test/tests/promise/promise-any-with-non-default-resolving.js extra : moz-landing-system : lando
-
André Bargull authored
Bug 1568903 - Part 8: Add separate struct to work with Promise combinator elements arrays. r=jorendorff Adds a separate struct to hold the elements arrays and to apply wrapping and unwrapping at the correct points. This will let us avoid copying this code another time for the `Promise.any` proposal. Differential Revision: https://phabricator.services.mozilla.com/D51658 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
Bug 1568903 - Part 7: Add function to check if Promise combinator element function was already called. r=jorendorff The first five steps in each Promise combinator element function are always the same. Add a helper function for this task to reduce more code duplication. Differential Revision: https://phabricator.services.mozilla.com/D51656 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
Moves the `NewNativeFunction` and the two `setExtendedSlot` calls into a helper function to reduce code duplication. Differential Revision: https://phabricator.services.mozilla.com/D51655 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
The draft proposal calls `Promise.all`, `Promise.allSettled`, `Promise.any`, and `Promise.race` "Promise combinators". Let's reuse that name to avoid having to spell each function name in shared functions. For example instead of `CommonStaticAllRace`, or soon `CommonStaticAllRaceAny`, we get `CommonPromiseCombinator`. - `PromiseAllDataHolder` is currently used for `Promise.all` and `Promise.allSettled`, and soon also for `Promise.any`. Rename it to `PromiseCombinatorDataHolder` to express that different Promise combinators use this object. Differential Revision: https://phabricator.services.mozilla.com/D51654 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
Adds AggregateError, but only enables it for Nightly builds, because the draft proposal is still incomplete, so it doesn't make sense to let this feature ride the trains at this moment. - The `other_error_properties` array was changed to individual static variables, because AggregateError has more than three properties, which prevents it to be stored in `JSPropertySpec[][3]`. - `AggregateErrorObject` can't use the normal `ErrorObject` class, because it needs an additional slot for the [[AggregateErrors]]. - For similar reasons it can't use the shared `Error` constructor function, because the `AggregateError` constructor has an additional `errors` iterable argument which it needs to process. Differential Revision: https://phabricator.services.mozilla.com/D51653 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
Update the #includes after moving the code in part 2. Differential Revision: https://phabricator.services.mozilla.com/D51652 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
The ErrorObject classes are already declared in ErrorObject.h, so it seems useful to also move their definitions into the corresponding cpp file. Also adds `js::CaptureStack` to jsexn.h so it can be called from ErrorObject.cpp and to remove the duplicated implementation in JSContext.cpp. Differential Revision: https://phabricator.services.mozilla.com/D51651 --HG-- extra : moz-landing-system : lando
-
André Bargull authored
GlobalObject.h had an unnecessary #include for ErrorObject.h, which led to recompiling more or less all of SpiderMonkey when modifying ErrorObject.h, because GlobalObject.h is (transitively) included in most files. Differential Revision: https://phabricator.services.mozilla.com/D51649 --HG-- extra : moz-landing-system : lando
-
Benjamin De Kosnik authored
Bug 1580077 - Exfiltrate selected histograms for performance metrics via geckoview_streaming. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D54046 --HG-- extra : moz-landing-system : lando
-
Cosmin Sabou authored
Backed out changeset 4126c23bb67c (bug 1598107) for causing browser chrome failures on browser_bug399606.js. CLOSED TREE
-
Noemi Erli authored
Backed out changeset 8cdae49ab472 (bug 1598539) for causing build bustages in EditorBase.cpp CLOSED TREE
-
Carolina authored
Differential Revision: https://phabricator.services.mozilla.com/D50110 --HG-- extra : moz-landing-system : lando
-
Andrew Halberstadt authored
As a side-effect this will also update runtime data for all suites using '--chunk-by-runtime'. This change simultaneously: 1. Stores runtime data from all suites 2. Stores runtime data from all tests (no more percentile) 3. Stores distinct data for android, unix (osx/linux) and windows 4. Reduces the size of 'testing/runtimes' from 408k -> 168k The chunks look more balanced from my unscientific glance (especially on Windows). Differential Revision: https://phabricator.services.mozilla.com/D53702 --HG-- extra : moz-landing-system : lando
-
- 20 Nov, 2019 1 commit
-
-
Andrew Halberstadt authored
Bug 1583364 - Update testing/runtimes/writeruntimes script to write info at the manifest level, r=gbrown The new format will be: { <path/to/manifest.ini>: <average duration> } Differential Revision: https://phabricator.services.mozilla.com/D53701 --HG-- extra : moz-landing-system : lando
-
- 19 Nov, 2019 3 commits
-
-
Andrew Halberstadt authored
The script should just do the thing that we want. Providing options just increases the chance of user error. I don't see any need to specify either of these things. Depends on D53699 Differential Revision: https://phabricator.services.mozilla.com/D53700 --HG-- extra : moz-landing-system : lando
-
Andrew Halberstadt authored
The main motivation here was to gain access to the mach enviroment for the future refactor. Depends on D53698 Differential Revision: https://phabricator.services.mozilla.com/D53699 --HG-- rename : testing/runtimes/writeruntimes.py => testing/runtimes/writeruntimes extra : moz-landing-system : lando
-
Andrew Halberstadt authored
Bug 1583364 - Create a 'build_flavor' key mapping 'moztest.resolve.TEST_SUITES' to their build flavor, r=gbrown Build flavors are defined in 'python/mozbuild/mozbuild/testing.py'. This change is needed by D52729 but it's also a good way to tell which suites are integrated into the TestManifestBackend in the build system. So I'm landing it here instead. Depends on D53030 Differential Revision: https://phabricator.services.mozilla.com/D53698 --HG-- extra : moz-landing-system : lando
-
- 22 Nov, 2019 5 commits
-
-
Drew Willcoxon authored
Differential Revision: https://phabricator.services.mozilla.com/D54025 --HG-- extra : moz-landing-system : lando
-
Andreas Pehrson authored
Bug 1536156 - Make VideoFrameContainer::ClearFutureFrames keep the current frame instead of the first frame. r=padenot Depends on D54117 Differential Revision: https://phabricator.services.mozilla.com/D54301 --HG-- extra : moz-landing-system : lando
-
Andreas Pehrson authored
Differential Revision: https://phabricator.services.mozilla.com/D54117 --HG-- extra : moz-landing-system : lando
-
Andreas Pehrson authored
Unlink must not cause an AddRef on the unlinked object, or it is at risk of leaking. See 1593739 for an example of where this happens. EndCloningVisually is dangerous in that it tries to do more than just unlink the video element. It does AddRef in NotifyUAWidgetSetupOrChange, so that must be avoided. Previous patches to this bug make sure that MediaDecoder shutdown takes care of clearing the secondary video container in the MediaDecoder stack, so this is not actually necessary anymore. Differential Revision: https://phabricator.services.mozilla.com/D53832 --HG-- extra : moz-landing-system : lando
-
Andreas Pehrson authored
Differential Revision: https://phabricator.services.mozilla.com/D53733 --HG-- extra : moz-landing-system : lando
-