1. 05 Feb, 2021 40 commits
    • Chun-Min Chang's avatar
      Bug 1650281 - P1: Widen `gCombinedSizes` once the buffers grow r=gerald · 270e2ce9
      Chun-Min Chang authored and Matthew Finkel's avatar Matthew Finkel committed
      The `gCombinedSizes` need to be enlarged once the inner buffer within
      `MemoryBlockCache` grows. Otherwise, when the `MemoryBlockCache` is
      released, subtracting the buffer-size of the `MemoryBlockCache` from
      `gCombinedSizes` lead to a underflow.
      
      Differential Revision: https://phabricator.services.mozilla.com/D84273
      270e2ce9
    • Kathleen Brade's avatar
      Bug 40002: Remove about:pioneer · cc5b0ae5
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Firefox Pioneer is an opt-in program in which people volunteer to
      participate in studies that collect detailed, sensitive data about
      how they use their browser.
      cc5b0ae5
    • Alex Catarineu's avatar
      Bug 40073: Disable remote Public Suffix List fetching · 1629c3f2
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
      fetching the Public Suffix List via RemoteSettings and replacing the default
      one at runtime, which we do not want.
      1629c3f2
    • Alex Catarineu's avatar
      Bug 40025: Remove Mozilla add-on install permissions · 1716e41e
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      1716e41e
    • Kathleen Brade's avatar
      Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. · 89d53477
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Hide elements on about:logins that mention sync, "Firefox LockWise", and
      Mozilla's LockWise mobile apps.
      
      Disable the "Create New Login" button when security.nocertdb is true.
      89d53477
    • Kathleen Brade's avatar
      Bug 32418: Allow updates to be disabled via an enterprise policy. · 94913d00
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Restrict the Enterprise Policies mechanism to only consult a
      policies.json file (avoiding the Windows Registry and macOS's
      file system attributes).
      
      Add a few disabledByPolicy() checks to the update service to
      avoid extraneous (and potentially confusing) log messages when
      updates are disabled by policy.
      
      Sample content for distribution/policies.json:
      {
        "policies": {
          "DisableAppUpdate": true
        }
      }
      
      On Linux, avoid reading policies from /etc/firefox/policies/policies.json
      94913d00
    • Alex Catarineu's avatar
      Bug 21952: Implement Onion-Location · fe826fc7
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Whenever a valid Onion-Location HTTP header (or corresponding HTML
      <meta> http-equiv attribute) is found in a document load, we either
      redirect to it (if the user opted-in via preference) or notify the
      presence of an onionsite alternative with a badge in the urlbar.
      fe826fc7
    • Alex Catarineu's avatar
      Bug 28005: Implement .onion alias urlbar rewrites · cb132169
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      A custom HTTPS Everywhere update channel is installed,
      which provides rules for locally redirecting some memorable
      .tor.onion URLs to non-memorable .onion URLs.
      
      When these redirects occur, we also rewrite the URL in the urlbar
      to display the human-memorable hostname instead of the actual
      .onion.
      
      Bug 34196: Update site info URL with the onion name
      cb132169
    • Alex Catarineu's avatar
      Bug 33342: Avoid disconnect search addon error after removal. · 19021b06
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      We removed the addon in #32767, but it was still being loaded
      from addonStartup.json.lz4 and throwing an error on startup
      because its resource: location is not available anymore.
      19021b06
    • Matthew Finkel's avatar
      Bug 28125 - Prevent non-Necko network connections · ed6ab267
      Matthew Finkel authored and Matthew Finkel's avatar Matthew Finkel committed
      ed6ab267
    • Matthew Finkel's avatar
      Bug 25741 - TBA: Disable GeckoNetworkManager · 5ddaf16e
      Matthew Finkel authored and Matthew Finkel's avatar Matthew Finkel committed
      The browser should not need information related to the network
      interface or network state, tor should take care of that.
      5ddaf16e
    • Amogh Pradeep's avatar
      Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. · 148e5986
      Amogh Pradeep authored and Matthew Finkel's avatar Matthew Finkel committed
      See Bug 1357997 for partial uplift.
      
      Also:
      Bug 28051 - Use our Orbot for proxying our connections
      
      Bug 31144 - ESR68 Network Code Review
      148e5986
    • Matthew Finkel's avatar
      Bug 24796 - Comment out excess permissions from GeckoView · 96c6a291
      Matthew Finkel authored and Matthew Finkel's avatar Matthew Finkel committed
      The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
      manifest, so we can't use the ifdef preprocessor guards around the
      permissions we do not want. Commenting the permissions is the
      next-best-thing.
      96c6a291
    • Georg Koppen's avatar
      Bug 32658: Create a new MAR signing key · 52970808
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      It's time for our rotation again: Move the backup key in the front
      position and add a new backup key.
      
      squash! Bug 32658: Create a new MAR signing key
      
      Bug 33803: Move our primary nightly MAR signing key to tor-browser
      
      Bug 33803: Add a secondary nightly MAR signing key
      52970808
    • Kathleen Brade's avatar
      Bug 30237: Add v3 onion services client authentication prompt · d73b5c17
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      When Tor informs the browser that client authentication is needed,
      temporarily load about:blank instead of about:neterror and prompt
      for the user's key.
      
      If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
      control port command to add the key (via Torbutton's control port
      module) and reload the page.
      
      If the user cancels the prompt, display the standard about:neterror
      "Unable to connect" page. This requires a small change to
      browser/actors/NetErrorChild.jsm to account for the fact that the
      docShell no longer has the failedChannel information. The failedChannel
      is used to extract TLS-related error info, which is not applicable
      in the case of a canceled .onion authentication prompt.
      
      Add a leaveOpen option to PopupNotifications.show so we can display
      error messages within the popup notification doorhanger without
      closing the prompt.
      
      Add support for onion services strings to the TorStrings module.
      
      Add support for Tor extended...
      d73b5c17
    • Richard Pospesel's avatar
      Bug 32220: Improve the letterboxing experience · b909879e
      Richard Pospesel authored and Matthew Finkel's avatar Matthew Finkel committed
      CSS and JS changes to alter the UX surrounding letterboxing. The
      browser element containing page content is now anchored to the bottom
      of the toolbar, and the remaining letterbox margin is the same color
      as the firefox chrome. The letterbox margin and border are tied to
      the currently selected theme.
      
      Also adds a 'needsLetterbox' property to tabbrowser.xml to fix a race
      condition present when using the 'isEmpty' property. Using 'isEmpty'
      as a proxy for 'needsLetterbox' resulted in over-zealous/unnecessary
      letterboxing of about:blank tabs.
      b909879e
    • Alex Catarineu's avatar
      Bug 27604: Fix addon issues when moving TB directory · 521891b8
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      521891b8
    • Alex Catarineu's avatar
      Bug 31740: Remove some unnecessary RemoteSettings instances · 81d4dc11
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      More concretely, SearchService.jsm 'hijack-blocklists' and
      url-classifier-skip-urls.
      
      Avoid creating instance for 'anti-tracking-url-decoration'.
      
      If prefs are disabling their usage, avoid creating instances for
      'cert-revocations' and 'intermediates'.
      
      Do not ship JSON dumps for collections we do not expect to need. For
      the ones in the 'main' bucket, this prevents them from being synced
      unnecessarily (the code in remote-settings does so for collections
      in the main bucket for which a dump or local data exists). For the
      collections in the other buckets, we just save some size by not
      shipping their dumps.
      
      We also clear the collections database on the v2 -> v3 migration.
      81d4dc11
    • Alex Catarineu's avatar
      Bug 32092: Fix Tor Browser Support link in preferences · afe22acb
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      afe22acb
    • Richard Pospesel's avatar
      Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#tor · d0efd661
      Richard Pospesel authored and Matthew Finkel's avatar Matthew Finkel committed
      This patch adds a new about:preferences#tor page which allows modifying
      bridge, proxy, and firewall settings from within Tor Browser. All of the
      functionality present in tor-launcher's Network Configuration panel is
      present:
      
       - Setting built-in bridges
       - Requesting bridges from BridgeDB via moat
       - Using user-provided bridges
       - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
       - Setting firewall ports
       - Viewing and Copying Tor's logs
       - The Networking Settings in General preferences has been removed
      d0efd661
    • Alex Catarineu's avatar
      Bug 13543: Spoof smooth and powerEfficient for Media Capabilities · 13c80ca7
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      13c80ca7
    • Kathleen Brade's avatar
      Bug 31607: App menu items stop working on macOS · 30eb4ced
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Avoid re-creating the hidden window, since this causes the nsMenuBarX
      object that is associated with the app menu to be freed (which in
      turn causes all of the app menu items to stop working).
      
      More detail: There should only be one hidden window.
      XREMain::XRE_mainRun() contains an explicit call to create the
      hidden window and that is the normal path by which it is created.
      However, when Tor Launcher's wizard/progress window is opened during
      startup, a hidden window is created earlier as a side effect of
      calls to nsAppShellService::GetHiddenWindow(). Then, when
      XREMain::XRE_mainRun() creates its hidden window, the original one
      is freed which also causes the app menu's nsMenuBarX object which
      is associated with that window to be destroyed. When that happens,
      the menuGroupOwner property within each Cocoa menu items's MenuItemInfo
      object is cleared. This breaks the link that is necessary for
      NativeMenuItemTarget's menuItemHit method to dispatch a menu item
      event.
      30eb4ced
    • Kathleen Brade's avatar
      Bug 26961: New user onboarding. · 701a0d6f
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Reuse the Firefox onboarding mechanism with minimal changes.
      Localizable strings are pulled in from Torbutton (if Torbutton is
        not installed, we lack about:tor and no tour will be shown).
      Replace SVG images with PNGs (see bug 27002),
      For defense in depth, omit include OnboardingTelemetry.jsm entirely.
      Added support for the following UITour page event:
        torBrowserOpenSecuritySettings
      
      Also fix bug 27403: the onboarding bubble is not always displayed.
      
      Arthur suggested to make the onboarding bubble visible on displays with
      less than 960px width available, so we choose 200px instead.
      
      Also fix bug 28628: Change onboarding Security panel to open new
      Security Level panel.
      
      Also fix bug 27484: Improve navigation within onboarding.
      
      Bug 27082: enable a limited UITour
      
      Disallow access to UITour functionality from all pages other than
        about:home, about:newtab, and about:tor.
      Implement a whitelist mechanism for page actions.
      
      Bug 26962 - implement new features onboarding (part 1...
      701a0d6f
    • Alex Catarineu's avatar
      Bring back old Firefox onboarding · 9d7b5f70
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"
      
      This reverts commit f7ffd78b.
      
      Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
      
      This reverts commit 057fe36f.
      
      Bug 28822: Convert onboarding to webextension
      
      Partially revert 1564367 (controlCenter in UITour.jsm)
      9d7b5f70
    • Alex Catarineu's avatar
      Bug 27511: Add new identity button to toolbar · 4d961f3a
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Also added 'New circuit for this site' button to CustomizableUI, but
      not visible by default.
      4d961f3a
    • Alex Catarineu's avatar
      Bug 31575: Replace Firefox Home (newtab) with about:tor · 132042b8
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Avoid loading AboutNewTab in BrowserGlue.jsm in order
      to avoid several network requests that we do not need. Besides,
      about:newtab will now point to about:blank or about:tor (depending
      on browser.newtabpage.enabled) and about:home will point to
      about:tor.
      132042b8
    • Alex Catarineu's avatar
      Bug 26345: Hide tracking protection UI · 501bd1f0
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      501bd1f0
    • Alex Catarineu's avatar
    • Georg Koppen's avatar
      Bug 30541: Disable WebGL readPixel() for web content · 9aeddd0b
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      9aeddd0b
    • Richard Pospesel's avatar
      Bug 23247: Communicating security expectations for .onion · 51631259
      Richard Pospesel authored and Matthew Finkel's avatar Matthew Finkel committed
      Encrypting pages hosted on Onion Services with SSL/TLS is redundant
      (in terms of hiding content) as all traffic within the Tor network is
      already fully encrypted.  Therefore, serving HTTP pages from an Onion
      Service is more or less fine.
      
      Prior to this patch, Tor Browser would mostly treat pages delivered
      via Onion Services as well as pages delivered in the ordinary fashion
      over the internet in the same way.  This created some inconsistencies
      in behaviour and misinformation presented to the user relating to the
      security of pages delivered via Onion Services:
      
       - HTTP Onion Service pages did not have any 'lock' icon indicating
         the site was secure
       - HTTP Onion Service pages would be marked as unencrypted in the Page
         Info screen
       - Mixed-mode content restrictions did not apply to HTTP Onion Service
         pages embedding Non-Onion HTTP content
      
      This patch fixes the above issues, and also adds several new 'Onion'
      icons to the mix to indicate all of the various permutations of Onion
      Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
      
      Strings for Onion Service Page Info page are pulled from Torbutton's
      localization strings.
      51631259
    • Alex Catarineu's avatar
      Bug 28369: Stop shipping pingsender executable · 1ed238ea
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      1ed238ea
    • Arthur Edelstein's avatar
      Bug 26353: Prevent speculative connect that violated FPI. · 78a902b2
      Arthur Edelstein authored and Matthew Finkel's avatar Matthew Finkel committed
      Connections were observed in the catch-all circuit when
      the user entered an https or http URL in the URL bar, or
      typed a search term.
      78a902b2
    • Richard Pospesel's avatar
      Bug 25658: Replace security slider with security level UI · b1fab128
      Richard Pospesel authored and Matthew Finkel's avatar Matthew Finkel committed
      This patch adds a new 'securitylevel' component to Tor Browser intended
      to replace the torbutton 'Security Slider'.
      
      This component adds a new Security Level toolbar button which visually
      indicates the current global security level via icon (as defined by the
      extensions.torbutton.security_slider pref), a drop-down hanger with a
      short description of the current security level, and a new section in
      the about:preferences#privacy page where users can change their current
      security level. In addition, the hanger and the preferences page will
      show a visual warning when the user has modified prefs associated with
      the security level and provide a one-click 'Restore Defaults' button to
      get the user back on recommended settings.
      
      Strings used by this patch are pulled from the torbutton extension, but
      en-US defaults are provided if there is an error loading from the
      extension. With this patch applied, the usual work-flow of "./mach build
      && ./mach run" work as expected, even if the torbutton extension is
      disabled.
      b1fab128
    • Igor Oliveira's avatar
      Bug 23104: Add a default line height compensation · 3faddde7
      Igor Oliveira authored and Matthew Finkel's avatar Matthew Finkel committed
      Many fonts have issues with their vertical metrics. they
      are used to influence the height of ascenders and depth
      of descenders. Gecko uses it to calculate the line height
      (font height + ascender + descender), however because of
      that idiosyncratic behavior across multiple operating
      systems, it can be used to identify the user's OS.
      
      The solution proposed in the patch uses a default factor
      to be multiplied with the font size, simulating the concept
      of ascender and descender. This way all operating
      systems will have the same line height only and only if the
      frame is outside the chrome.
      3faddde7
    • Georg Koppen's avatar
      Bug 21830: Copying large text from web console leaks to /tmp · 2b27c665
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      Patch written by Neill Miller
      2b27c665
    • Kathleen Brade's avatar
      Bug 21431: Clean-up system extensions shipped in Firefox · 5b960b35
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Only ship the pdfjs extension.
      5b960b35
    • Georg Koppen's avatar
      Bug 16285: Exclude ClearKey system for now · 6806086a
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      In the past the ClearKey system had not been compiled when specifying
      --disable-eme. But that changed and it is even bundled nowadays (see:
      Mozilla's bug 1300654). We don't want to ship it right now as the use
      case for it is not really visible while the code had security
      vulnerabilities in the past.
      6806086a
    • boklm's avatar
      Bug 21907: Fix runtime error on CentOS 6 · 977f50ff
      boklm authored and Matthew Finkel's avatar Matthew Finkel committed
      In Mozilla bug 1324780, support for building with glib 2.28 (the version
      available in CentOS 6) was added. However we are building on Debian
      Wheezy which has glib 2.32. We fix that by backing out all glib > 2.28
      code paths.
      977f50ff
    • Mike Perry's avatar
      Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing · ce59b465
      Mike Perry authored and Matthew Finkel's avatar Matthew Finkel committed
      eBay and Amazon don't treat Tor users very well. Accounts often get locked and
      payments reversed.
      
      Also:
      Bug 16322: Update DuckDuckGo search engine
      
      We are replacing the clearnet URL with an onion service one (thanks to a
      patch by a cypherpunk) and are removing the duplicated DDG search
      engine. Duplicating DDG happend due to bug 1061736 where Mozilla
      included DDG itself into Firefox. Interestingly, this caused breaking
      the DDG search if JavaScript is disabled as the Mozilla engine, which
      gets loaded earlier, does not use the html version of the search page.
      Moreover, the Mozilla engine tracked where the users were searching from
      by adding a respective parameter to the search query. We got rid of that
      feature as well.
      
      Also:
      This fixes bug 20809: the DuckDuckGo team has changed its server-side
      code in a way that lets users with JavaScript enabled use the default
      landing page while those without JavaScript available get red...
      ce59b465
    • Kathleen Brade's avatar
      Bug 16940: After update, load local change notes. · 61b1ed0f
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Add an about:tbupdate page that displays the first section from
      TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
      post-update page (typically our blog entry for the release).
      
      Always load about:tbupdate in a content process, but implement the
      code that reads the file system (changelog) in the chrome process
      for compatibility with future sandboxing efforts.
      
      Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
      changelog page that is designed to be displayed via a link that is on
      about:tor.
      61b1ed0f