1. 31 May, 2020 1 commit
  2. 29 May, 2020 1 commit
  3. 25 May, 2020 1 commit
  4. 21 May, 2020 2 commits
  5. 20 May, 2020 1 commit
    • Emilio Cobos Álvarez's avatar
      Bug 1639262 - Avoid duplicate entries in the stylesheet cache.... · a147afc0
      Emilio Cobos Álvarez authored
      Bug 1639262 - Avoid duplicate entries in the stylesheet cache. r=nordzilla,firefox-style-system-reviewers
      
      When the loader finds an already-complete stylesheet, it will call
      PostLoadEvent to fire the load event of the relevant <link> element,
      etc.
      
      For that, it'll mint a SheetLoadData, with various fields hard-coded.
      That causes us to eventually insert the sheet in mCompleteSheets, but
      with a different key, which means we'll end up with two copies of the
      same stylesheet in the cache, than when reporting memory we'll report
      twice.
      
      Fix it by constructing the right load data a bit sooner, and add an
      assertion to ensure this doesn't happen anymore.
      
      Differential Revision: https://phabricator.services.mozilla.com/D76000
      a147afc0
  6. 19 May, 2020 1 commit
  7. 12 May, 2020 5 commits
  8. 17 Mar, 2020 1 commit
  9. 20 Jan, 2020 2 commits
    • Emilio Cobos Álvarez's avatar
      Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj · 256c124f
      Emilio Cobos Álvarez authored
      This was done by:
      
      This was done by applying:
      
      ```
      diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
      index 789affde7bbf..fe33c4c7d4d1 100644
      --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
      +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
      @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
               from subprocess import Popen, PIPE, check_output, CalledProcessError
      
               diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
      -        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
      +        args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']
      
               if not output_file:
                   args.append("-i")
      ```
      
      Then running `./mach clang-format -c <commit-hash>`
      
      Then undoing that patch.
      
      Then running check_spidermonkey...
      256c124f
    • Emilio Cobos Álvarez's avatar
      Bug 1609996 - Remove mozilla/Move.h. r=froydnj · aa3a6957
      Emilio Cobos Álvarez authored
      rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'
      
      Further manual fixups and cleanups to the include order incoming.
      
      Differential Revision: https://phabricator.services.mozilla.com/D60323
      
      --HG--
      extra : moz-landing-system : lando
      aa3a6957
  10. 13 Jan, 2020 1 commit
  11. 30 Nov, 2019 1 commit
  12. 29 Nov, 2019 1 commit
  13. 27 Nov, 2019 1 commit
  14. 21 Aug, 2019 1 commit
  15. 16 Aug, 2019 5 commits
  16. 13 Aug, 2019 3 commits
  17. 16 Jul, 2019 1 commit
  18. 25 Apr, 2019 1 commit
  19. 19 Apr, 2019 2 commits
  20. 18 Apr, 2019 1 commit
  21. 03 Jan, 2019 1 commit
    • Emilio Cobos Álvarez's avatar
      Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug · d2ed2608
      Emilio Cobos Álvarez authored
      Summary: Really sorry for the size of the patch. It's mostly automatic
      s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to
      add the right namespacing and such.
      
      Overall it's not a very interesting patch I think.
      
      nsDocument.cpp turns into Document.cpp, nsIDocument.h into Document.h and
      nsIDocumentInlines.h into DocumentInlines.h.
      
      I also changed a bunch of nsCOMPtr usage to RefPtr, but not all of it.
      
      While fixing up some of the bits I also removed some unneeded OwnerDoc() null
      checks and such, but I didn't do anything riskier than that.
      d2ed2608
  22. 30 Nov, 2018 1 commit
  23. 14 Oct, 2018 1 commit
  24. 20 Sep, 2018 1 commit
    • Nathan Froyd's avatar
      Bug 1415980 - make hash keys movable and not copyable; r=erahm · e7b3b314
      Nathan Froyd authored
      Everything that goes in a PLDHashtable (and its derivatives, like
      nsTHashtable) needs to inherit from PLDHashEntryHdr. But through a lack
      of enforcement, copy constructors for these derived classes didn't
      explicitly invoke the copy constructor for PLDHashEntryHdr (and the
      compiler didn't invoke the copy constructor for us). Instead,
      PLDHashTable explicitly copied around the bits that the copy constructor
      would have.
      
      The current setup has two problems:
      
      1) Derived classes should be using move construction, not copy
         construction, since anything that's shuffling hash table keys/entries
         around will be using move construction.
      
      2) Derived classes should take responsibility for transferring bits of
         superclass state around, and not rely on something else to handle that.
      
      The second point is not a huge problem for PLDHashTable (PLDHashTable
      only has to copy PLDHashEntryHdr's bits in a single place), but future
      hash table implementations that might move entries around more
      aggressively would have to insert compensation code all over the
      place. Additionally, if moving entries is implemented via memcpy (which
      is quite common), PLDHashTable copying around bits *again* is
      inefficient.
      
      Let's fix all these problems in one go, by:
      
      1) Explicitly declaring the set of constructors that PLDHashEntryHdr
         implements (and does not implement). In particular, the copy
         constructor is deleted, so any derived classes that attempt to make
         themselves copyable will be detected at compile time: the compiler
         will complain that the superclass type is not copyable.
      
      This change on its own will result in many compiler errors, so...
      
      2) Change any derived classes to implement move constructors instead of
         copy constructors. Note that some of these move constructors are,
         strictly speaking, unnecessary, since the relevant classes are moved
         via memcpy in nsTHashtable and its derivatives.
      e7b3b314
  25. 17 Sep, 2018 2 commits
  26. 28 Jul, 2018 1 commit