- 17 Mar, 2021 1 commit
-
-
Encrypting pages hosted on Onion Services with SSL/TLS is redundant (in terms of hiding content) as all traffic within the Tor network is already fully encrypted. Therefore, serving HTTP pages from an Onion Service is more or less fine. Prior to this patch, Tor Browser would mostly treat pages delivered via Onion Services as well as pages delivered in the ordinary fashion over the internet in the same way. This created some inconsistencies in behaviour and misinformation presented to the user relating to the security of pages delivered via Onion Services: - HTTP Onion Service pages did not have any 'lock' icon indicating the site was secure - HTTP Onion Service pages would be marked as unencrypted in the Page Info screen - Mixed-mode content restrictions did not apply to HTTP Onion Service pages embedding Non-Onion HTTP content This patch fixes the above issues, and also adds several new 'Onion' icons to the mix to indicate all of the various permutations of Onion Services hosted HTTP or HTTPS pages with HTTP or HTTPS content. Strings for Onion Service Page Info page are pulled from Torbutton's localization strings.
-
- 28 May, 2020 1 commit
-
-
Razvan Maries authored
Backed out changeset 9643bf18ac31 (bug 1638711) Backed out changeset 3d06b48e2e3a (bug 1638711) Backed out changeset c2a1461890c3 (bug 1638711) Backed out changeset 9eda9f6c5877 (bug 1638711) Backed out changeset f776c30279f3 (bug 1638711) Backed out changeset b34546384903 (bug 1638711) Backed out changeset 47da03dd8365 (bug 1638711)
-
- 27 May, 2020 5 commits
-
-
Matt Woodrow authored
Differential Revision: https://phabricator.services.mozilla.com/D75720
-
Dorel Luca authored
Backed out 6 changesets (bug 1638711) for Geckoview failures in NavigationDelegateTest.loadUriReferrerSessionFileUrl.CLOSED TREE Backed out changeset 22a7b8f16c44 (bug 1638711) Backed out changeset 75d97b8df5ba (bug 1638711) Backed out changeset 254871b49de9 (bug 1638711) Backed out changeset 97d1d2390586 (bug 1638711) Backed out changeset bebe76fca022 (bug 1638711) Backed out changeset 164b842bea99 (bug 1638711)
-
Matt Woodrow authored
Differential Revision: https://phabricator.services.mozilla.com/D75720
-
Matt Woodrow authored
Bug 1631405 - Run nsMixedContentBlocker::AsyncOnChannelRedirect checks in the parent for documents, since this is now supported correctly. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D75449
-
Matt Woodrow authored
Bug 1631405 - Move nsISecureBrowserUI to be owned by the canonical browsing context instead of docshell. r=nika,ckerschb,Gijs,webcompat-reviewers,twisniewski This removes all docshell nsISecureBrowserUI and mixed content properties, and moves them into CanonicalBrowsingContext/WindowGlobalParent. It makes the mixed content blocker just compute the state for the current load, and then send the results to the parent process, where we update the security state accordingly. I think we could in the future remove onSecurityChange entirely, and instead just fire an event to the <browser> element notifying it of changes to the queryable securityUI. Unfortunately we have a lot of existing code that depends on specific ordering between onSecurityChange and onLocationChange, so I had to hook into the RemoteWebProgress implementation in BrowserParent to mimic the same timings. Differential Revision: https://phabricator.services.mozilla.com/D75447
-
- 26 May, 2020 3 commits
-
-
Bogdan Tara authored
Backed out changeset 9963cc0b23cb (bug 1631405) Backed out changeset 469ac933ed7c (bug 1631405) Backed out changeset 0c5f55864268 (bug 1631405) Backed out changeset 20dcbcc2f3b8 (bug 1631405)
-
Matt Woodrow authored
Bug 1631405 - Run nsMixedContentBlocker::AsyncOnChannelRedirect checks in the parent for documents, since this is now supported correctly. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D75449
-
Matt Woodrow authored
Bug 1631405 - Move nsISecureBrowserUI to be owned by the canonical browsing context instead of docshell. r=nika,ckerschb,Gijs,webcompat-reviewers,twisniewski This removes all docshell nsISecureBrowserUI and mixed content properties, and moves them into CanonicalBrowsingContext/WindowGlobalParent. It makes the mixed content blocker just compute the state for the current load, and then send the results to the parent process, where we update the security state accordingly. I think we could in the future remove onSecurityChange entirely, and instead just fire an event to the <browser> element notifying it of changes to the queryable securityUI. Unfortunately we have a lot of existing code that depends on specific ordering between onSecurityChange and onLocationChange, so I had to hook into the RemoteWebProgress implementation in BrowserParent to mimic the same timings. Differential Revision: https://phabricator.services.mozilla.com/D75447
-
- 13 May, 2020 1 commit
-
-
Narcis Beleuzu authored
Backed out changeset 5633cc2aaa9b (bug 1637487) Backed out changeset c4f0c757cae0 (bug 1637487) Backed out changeset 65bb1114df87 (bug 1637487) Backed out changeset 1a64ef10e773 (bug 1637487) Backed out changeset d1709ebb7f46 (bug 1637487) Backed out changeset 286e5ee6517f (bug 1637487) Backed out changeset 83362625c297 (bug 1637487) Backed out changeset ab9df2f2d11f (bug 1637487) Backed out changeset b83f49bc11b0 (bug 1637487)
-
- 14 May, 2020 9 commits
-
-
Matt Woodrow authored
Bug 1637487 - Store mixed content security flags as a flags word on Document instead of bools. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D75026
-
Matt Woodrow authored
Differential Revision: https://phabricator.services.mozilla.com/D75025
-
Matt Woodrow authored
Differential Revision: https://phabricator.services.mozilla.com/D75024
-
Matt Woodrow authored
Differential Revision: https://phabricator.services.mozilla.com/D75023
-
Matt Woodrow authored
Factor out broken flag clearing Differential Revision: https://phabricator.services.mozilla.com/D75022
-
Matt Woodrow authored
Differential Revision: https://phabricator.services.mozilla.com/D75021
-
Matt Woodrow authored
Bug 1637487 - Flatten the mixed content event runner into the calling code, so it's no longer needed. r=ckerschb This looks like it was necessary a long time ago, but now just runs the same calls as the calling code, so unnecessarily splits the logic into two. Differential Revision: https://phabricator.services.mozilla.com/D75020
-
Matt Woodrow authored
Bug 1637487 - Refactor calls to OnSecurityChange to all be a single call at the end of ShouldLoad. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D75019
-
Matt Woodrow authored
We previously were checking the nsresult inconsistently. Differential Revision: https://phabricator.services.mozilla.com/D75018
-
- 13 May, 2020 10 commits
-
-
Matt Woodrow authored
Bug 1637487 - Store mixed content security flags as a flags word on Document instead of bools. r=ckerschb Depends on D75025 Differential Revision: https://phabricator.services.mozilla.com/D75026
-
Matt Woodrow authored
Depends on D75024 Differential Revision: https://phabricator.services.mozilla.com/D75025
-
Matt Woodrow authored
Depends on D75023 Differential Revision: https://phabricator.services.mozilla.com/D75024
-
Matt Woodrow authored
Depends on D75022 Differential Revision: https://phabricator.services.mozilla.com/D75023
-
Matt Woodrow authored
Factor out broken flag clearing Depends on D75021 Differential Revision: https://phabricator.services.mozilla.com/D75022
-
Matt Woodrow authored
Depends on D75020 Differential Revision: https://phabricator.services.mozilla.com/D75021
-
Matt Woodrow authored
Bug 1637487 - Flatten the mixed content event runner into the calling code, so it's no longer needed. r=ckerschb This looks like it was necessary a long time ago, but now just runs the same calls as the calling code, so unnecessarily splits the logic into two. Depends on D75019 Differential Revision: https://phabricator.services.mozilla.com/D75020
-
Matt Woodrow authored
Bug 1637487 - Refactor calls to OnSecurityChange to all be a single call at the end of ShouldLoad. r=ckerschb Depends on D75018 Differential Revision: https://phabricator.services.mozilla.com/D75019
-
Matt Woodrow authored
We previously were checking the nsresult inconsistently. Differential Revision: https://phabricator.services.mozilla.com/D75018
-
Christoph Kerschbaumer authored
Differential Revision: https://phabricator.services.mozilla.com/D74835
-
- 12 May, 2020 1 commit
-
-
Christoph Kerschbaumer authored
Bug 1637193: Warn not only once but every time we are loading mixed object subrequest including the soon to be blocked URI. r=baku Differential Revision: https://phabricator.services.mozilla.com/D74824
-
- 11 May, 2020 1 commit
-
-
Christoph Kerschbaumer authored
Differential Revision: https://phabricator.services.mozilla.com/D74269
-
- 08 May, 2020 4 commits
-
-
Csoregi Natalia authored
Backed out changeset 59a45d8c0fbb (bug 1635365) for browser-chrome failures on browser_bug902156.js. CLOSED TREE
-
Christoph Kerschbaumer authored
Differential Revision: https://phabricator.services.mozilla.com/D74269
-
Matt Woodrow authored
Bug 1635992 - Use LoadInfo and WindowContext in nsMixedContentBlocker instead of the docshell and Document. r=ckerschb Differential Revision: https://phabricator.services.mozilla.com/D74169
-
Matt Woodrow authored
Differential Revision: https://phabricator.services.mozilla.com/D74168
-
- 07 May, 2020 2 commits
-
-
Christoph Kerschbaumer authored
Bug 1632160: Remove GetAllowMixedContentAndConnectionData from nsIDocShell and expose similar functionality on BrowsingContext. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D72901
-
Christoph Kerschbaumer authored
Bug 1635788: Use WindowID instead of rootDoc when logging mixed content messages to the console.r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D74047
-
- 06 May, 2020 2 commits
-
-
Narcis Beleuzu authored
Backed out changeset 9da3ff68132f (bug 1632160) for bc failures on browser_bug1045809.js . CLOSED TREE
-
Christoph Kerschbaumer authored
Bug 1632160: Remove GetAllowMixedContentAndConnectionData from nsIDocShell and expose similar functionality on BrowsingContext. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D72901
-