Skip to content
GitLab
  1. 22 Aug, 2019 4 commits
  3. 21 Aug, 2019 2 commits
    • Thomas Wisniewski's avatar
      Bug 1564594 - Add an Enhanced Search webcompat site patch r=nalexander,denschub · d1694a0f
      Thomas Wisniewski authored 
      This patch ultimately overrides the user-agent which Fennec users send to Google Search pages, choosing a phone- or tablet-specific UA as appropriate.

It involves adding four new metadata keys to the webcompat addon's metadata for user-agent overrides: blocks, permanentPref, experiment, telemetryKey:

- "blocks" specifies URLs for which any requests should be aborted. This allows us to block the Google service worker for now, as it has caused "content corrupted" issues in the past with other enhanced search addons (see https://github.com/wisniewskit/google-search-fixer/issues/1).
- "permanentPref" specifies an about:config preference, which dictates whether the injection is used. Users may set this to `false` to disable the injection outright, and permanently; `true` or `undefined` values allow the injection to function normally.
- "experiment" specifies the name of the experiment this feature is optionally gated behind. Only a Fennec-specific implementation is provided in this patch. The implementation simply queries Switchboard to determine if the experiment is active.
- "telemetryKey" specifies which telemetry key should be flipped to "true" when this injection runs. We will use this to note whether enhanced search has actually been enabled for this profile. Only a Fennec-specific implementation is given in this patch, which actually just sets a Fennec Shared Preference, which Fennec's core telemetry ping later reads in Java to know what the ping should contain.

Differential Revision: https://phabricator.services.mozilla.com/D41074

--HG--
extra : moz-landing-system : lando
      d1694a0f
    • Nathan Froyd's avatar
      Bug 1575544 - make scalar info constructors constexpr; r=chutten · 70244dab
      Nathan Froyd authored 
      Marking these constructors as `constexpr` encourages the compiler to
constant-initialize most of the `gScalars` array, rather than generating
a giant glob of code to move the (constant) values into the array at
runtime.

Differential Revision: https://phabricator.services.mozilla.com/D42842

--HG--
extra : moz-landing-system : lando
      70244dab
  5. 22 Aug, 2019 12 commits
  7. 21 Aug, 2019 1 commit
  9. 22 Aug, 2019 2 commits
  11. 21 Aug, 2019 1 commit
  13. 22 Aug, 2019 2 commits
    • Tim Huang's avatar
      Bug 1574930 - Part 3: Add a test case for making sure that the track counter... · 02045f09
      Tim Huang authored 
      Bug 1574930 - Part 3: Add a test case for making sure that the track counter displays properly and fix an issue for BrowserTestUtils.waitForAttribute(). r=nhnt11,johannh

This patch adds a test case to check the visibility of the track counter
is correct in different situations, including zero tracker, one tracker
and multiple trackers.

Also, this patch fixes an issue that the
BrowserTestUtils.waitForAttributes() won't work if the waiting
attributes doesn't have a value or has an empty string as its value.
We check the value of the observing attribute to verify if it is
existing, however an empty string will be treated as a false, so it
won't pass the check if the attribute doesn't have a value. Hence, we
should use hasAttribute() instead of getAttribute() to check the
existence of the attribute.

Differential Revision: https://phabricator.services.mozilla.com/D42718

--HG--
extra : moz-landing-system : lando
      02045f09
    • Tim Huang's avatar
      Bug 1574930 - Part 2: Fix the issue the the number of blocked trackers is... · 9fb91092
      Tim Huang authored 
      Bug 1574930 - Part 2: Fix the issue the the number of blocked trackers is still shown if the count is zero. r=nhnt11

By only hiding the tracker counter when the tracker counter is zero and
show the counter always other than that. By doing so,  the counter
would be shown properly according the tracker number.

Differential Revision: https://phabricator.services.mozilla.com/D42717

--HG--
extra : moz-landing-system : lando
      9fb91092
  15. 21 Aug, 2019 1 commit
  17. 22 Aug, 2019 6 commits
  19. 21 Aug, 2019 1 commit
  21. 22 Aug, 2019 6 commits
  23. 21 Aug, 2019 2 commits