Skip to content
GitLab
Switch branch/tag
  1. 11 Jun, 2020 1 commit
  3. 02 Jul, 2020 1 commit
  5. 06 Jul, 2020 1 commit
  7. 29 Jun, 2020 1 commit
  9. 24 Jun, 2020 1 commit
  11. 25 Jun, 2020 1 commit
    • J.C. Jones's avatar
      Bug 1644627 - Set the WebAuthn `appid` client extension result properly... · cecddaae
      J.C. Jones authored 
      Bug 1644627 - Set the WebAuthn `appid` client extension result properly r=bbeurdouche,keeler a=RyanVM

The semantics of what Firefox implemented for the AppID extension for WebAuthn
were wrong. Notably: It was always emitted if the extension were used, and
always set to `true`. The specification has more nuance so that RPs can use
that result to determine what to validate against.

As a reminder since it's been a while, this change has impacts to the WebAuthn
Token Manager layer, so there's duplicative changes in the soft token and in
the HID token, _and the automated tests only test the soft token_. Manual
testing using webauthn.bin.coffee and other test sites are needed to verify
behavior in U2FHIDTokenManager.

Differential Revision: https://phabricator.services.mozilla.com/D79568
      cecddaae
  13. 24 Jun, 2020 1 commit
  15. 22 Jun, 2020 1 commit
  17. 23 Jun, 2020 1 commit
  19. 24 Jun, 2020 2 commits
    • Rob Wu's avatar
      Bug 1635781 - Fully replace the web page's CSP if modified by add-on. r=mixedpuppy, a=RyanVM · 2b9adec7
      Rob Wu authored 
      The original addition of CSP to `headersAlreadySet` in bug 1462989 was
to make sure that CSP response headers from different extensions are
merged as expected. The logic did however not take into account that
unconditionally merging modified headers means that the header would be
merged with the original CSP from the web page, which prevented add-ons
from relaxing a CSP from the web page.

This commit fixes the bug by tracking the CSP status on the
`ResponseHeaderChanger` instance, which is shared by all webRequest
handlers of a single request.

Differential Revision: https://phabricator.services.mozilla.com/D80761
      2b9adec7
    • Rob Wu's avatar
      Bug 1635781 - Fix broken logic in test_ext_webRequest_mergecsp.js. r=mixedpuppy, a=RyanVM · 15f747ab
      Rob Wu authored 
      - Most importantly: Fix the `test_csp` helper to actually replace the
  page's CSP header. The existing tests verify that the web page's CSP
  is still applied, which is trivially true if the helper extension
  appends the CSP instead of replacing it.

- Expand comment on the meaning of the parameters in `test_csp`.

- `sendMessage` is not async, properly await the result.

- Unload extensions before checking assertions, to avoid unhelpful error
  messages about extensions not having been unloaded at the end of the
  test.

- Report which test case is being run to make debugging easier.

Differential Revision: https://phabricator.services.mozilla.com/D80760
      15f747ab
  21. 11 Jun, 2020 1 commit
  23. 24 Jun, 2020 1 commit
  25. 12 Jun, 2020 1 commit
  27. 30 Jun, 2020 1 commit
  29. 25 Jun, 2020 1 commit
  31. 22 Jun, 2020 3 commits
  33. 18 Jun, 2020 2 commits
  35. 15 Jun, 2020 2 commits
  37. 11 Jun, 2020 1 commit
  39. 10 Jun, 2020 1 commit
  41. 08 Jun, 2020 1 commit
  43. 17 Jun, 2020 1 commit
  45. 15 Jun, 2020 1 commit
  47. 10 Jun, 2020 1 commit
  49. 09 Jun, 2020 1 commit
  51. 08 Jun, 2020 1 commit
  53. 04 Jun, 2020 3 commits
  55. 30 Jun, 2020 1 commit
  57. 25 Jun, 2020 1 commit
  59. 26 Jun, 2020 1 commit
  61. 04 Jun, 2020 1 commit
  63. 12 Jun, 2020 1 commit
  65. 30 Jun, 2020 1 commit