- 01 Sep, 2020 3 commits
-
-
Mark Banner authored
Also remove DirectoryProvider as it is now unused. Depends on D88018 Differential Revision: https://phabricator.services.mozilla.com/D88019
-
Mark Banner authored
Depends on D88017 Differential Revision: https://phabricator.services.mozilla.com/D88018
-
Mark Banner authored
Bug 1619926 - Remove legacy search configuration code from the search service. r=daleharvey,geckoview-reviewers,agi Depends on D87894 Differential Revision: https://phabricator.services.mozilla.com/D88017
-
- 02 Sep, 2020 7 commits
-
-
Magnus Melin authored
Differential Revision: https://phabricator.services.mozilla.com/D88541
-
Bob Owen authored
This is then used in the front end to set the option in the settings. Differential Revision: https://phabricator.services.mozilla.com/D89045
-
Jonathan Watt authored
Differential Revision: https://phabricator.services.mozilla.com/D88704
-
Nika Layzell authored
Differential Revision: https://phabricator.services.mozilla.com/D88652
-
Jonathan Watt authored
Bug 1662769. Make PrintSettingsViewProxy.resolvePropertiesForPrinter use the saved printer info. r=mstriemer Differential Revision: https://phabricator.services.mozilla.com/D89154
-
Harry Twyford authored
Summary of changes: 1. Adds an `entry` property to the searchMode object to tag how search mode was entered. 2. Introduces `urlbar.searchmode.*` scalars. These scalars are suffixed with an entry point into search mode, for example `urlbar.searchmode.oneoff`, or `urlbar.searchmode.topsites_urlbar`. Those entry points tell us how search mode is entered most often. The keys for these scalars are strings describing what kind of search mode was entered. In most cases, this will be the name of a search engine, like "Google", or "DuckDuckGo". It may also be one of "history", "bookmarks", or "tabs". We only collect the names of engines that are bundled with Firefox. If the user enters search mode with an engine they installed themselves, we record "other" as the key. 3. Adds a urlbar-searchmode SAP to SEARCH_COUNTS. 4. Adds a browser.engagement.navigation.urlbar_searchmode probe. 5. Adds a urlbar_searchmode SAP to the navigation.search event. Differential Revision: https://phabricator.services.mozilla.com/D87510
-
emcminn authored
Bug 1661744 - Remove hover state from topsites tiles on the import screen of about:welcome r=pdahiya Differential Revision: https://phabricator.services.mozilla.com/D88631
-
- 01 Sep, 2020 1 commit
-
-
Nathan Froyd authored
See https://bugzilla.mozilla.org/show_bug.cgi?id=1656302#c7 for the explanation. Differential Revision: https://phabricator.services.mozilla.com/D89030
-
- 02 Sep, 2020 17 commits
-
-
Razvan Maries authored
-
Razvan Maries authored
-
Ricky Stewart authored
Bug 1662632 - Fix `UnboundLocalError` due to undefined variable `have_clone` in `mach bootstrap` r=froydnj This consolidates the `have_clone` logic in one place unconditionally. After bug 1647792 we're deprecating the use case where `bootstrap` is run without a clone, so that's not a problem. In reality the whole `have_clone` thing isn't necessary any more (`have_clone` is always going to be `True` in practice), but I'll save that for a bigger refactoring. Differential Revision: https://phabricator.services.mozilla.com/D89152
-
Jon Bauman authored
- Enable fallible allocation in mp4parse_capi by default - Switch from local implementation of fallible allocation to using fallible_collections crate - Return error if any of the primary item data is missing Differential Revision: https://phabricator.services.mozilla.com/D89091
-
Tony Crisci authored
Use g_dbus_method_invocation_return_value() to return a reply to DBus clients that call service methods. Sending a reply is required by the DBus specification and failing to do so may cause subtle bugs in clients. Differential Revision: https://phabricator.services.mozilla.com/D88737
-
Nathan Froyd authored
As long as we're following the STL guidelines on how to do iterators, we should be annotating things with the bits that the STL iterator support wants to see. Differential Revision: https://phabricator.services.mozilla.com/D89042
-
Chris H-C authored
Differential Revision: https://phabricator.services.mozilla.com/D89023
-
Gregory Mierzwinski authored
Differential Revision: https://phabricator.services.mozilla.com/D88680
-
Nicolas Chevobbe authored
Move the function taking care of closing the Browser Console to shared-head so we can close it before closing the tabs opened during the test. While attaching the worker, check that the Worker Debugger isn't closed, and if it is, reject the promise. On the target list, catch rejection while attaching and simply bail out so we don't call the rest of the code in onTargetAvailable. Those guards are not enough to prevent any failure while attaching, so we're wrapping calls to `attachAndInitThread`/`_onThreadInitialized` in try/catch blocks to avoid test failures. Differential Revision: https://phabricator.services.mozilla.com/D88766
-
Nicolas Chevobbe authored
At the moment, we don't have any guards in the targetList to _not_ execute the creation/destruction listeners once the toolbox gets destroyed. We only have a stopListening function on the targetList that is called when we close the toolbox, but we can't rely only on that since it's also called when doing a target switch (and working around that is very racy). One solution would be to follow the common pattern we have everywhere by having a destroy method that we would check before trying to call the listeners callback. This might help with intermittent test failures. Differential Revision: https://phabricator.services.mozilla.com/D88765
-
Tom Ritter authored
Differential Revision: https://phabricator.services.mozilla.com/D88994
-
pbz authored
Differential Revision: https://phabricator.services.mozilla.com/D88425
-
pbz authored
Differential Revision: https://phabricator.services.mozilla.com/D88424
-
pbz authored
Bug 1661030 - Extended TabDialogBox with an option to persist dialogs across same origin location change. r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D88423
-
pbz authored
Bug 1661030 - Refactor SubDialog and TabDialogBox to support passing multiple window arguments. r=Gijs,preferences-reviewers This also updates the behavior of the allowDuplicates check: Instead of only checking if the top dialog is a duplicate, it will now check the whole stack and skip the dialog open if a duplicate URL is found. This fixes an issue where callers could alternate between dialogs to bypass the check. Differential Revision: https://phabricator.services.mozilla.com/D88422
-
Nathan Froyd authored
Bug 1662707 - add HasEmptyHeader function and use it in various nsTArray places; r=xpcom-reviewers,sg One small step to removing that ugly `const_cast`. Differential Revision: https://phabricator.services.mozilla.com/D89122
-
James Willcox authored
This also adds a test. Differential Revision: https://phabricator.services.mozilla.com/D89026
-
- 01 Sep, 2020 1 commit
-
-
James Willcox authored
Without this, the asynchronous nature of compositor shutdown causes races if the Android surface is immediately reused with another GeckoSession instance. Differential Revision: https://phabricator.services.mozilla.com/D89025
-
- 02 Sep, 2020 4 commits
-
-
James Willcox authored
Differential Revision: https://phabricator.services.mozilla.com/D89041
-
Razvan Maries authored
-
Joel Maher authored
migrate reftest base tests on windows 10 from aws to hardware Differential Revision: https://phabricator.services.mozilla.com/D89135
-
julianwels authored
Differential Revision: https://phabricator.services.mozilla.com/D88006
-
- 01 Sep, 2020 2 commits
-
-
Kannan Vijayan authored
Differential Revision: https://phabricator.services.mozilla.com/D89071
-
Peter Van der Beken authored
Differential Revision: https://phabricator.services.mozilla.com/D88804
-
- 02 Sep, 2020 2 commits
-
-
Henrik Skupin authored
Bug 1662687 - [puppeteer] Update expectation data for Frame.waitForFunction should work when resolved right before execution context disposal. r=remote-protocol-reviewers,maja_zf Differential Revision: https://phabricator.services.mozilla.com/D89127
-
Hubert Boma Manilla authored
Differential Revision: https://phabricator.services.mozilla.com/D78867
-
- 01 Sep, 2020 1 commit
-
-
Bryce Seager van Dyk authored
Expand the decoder doctor browser chrome test to check that notifications trigger the expected UI behaviour when sent from cross origin iframes. Differential Revision: https://phabricator.services.mozilla.com/D88651
-
- 28 Aug, 2020 1 commit
-
-
Bryce Seager van Dyk authored
Port handling of DecoderDoctor notifications for fission. This is done by moving the observing of 'decoder-doctor-notification' from browser-media.js to fission friendly actors. As browser-media.js had only code related to this patch left it is removed along with references to it. Same with ContentObservers.js. Differential Revision: https://phabricator.services.mozilla.com/D88322
-
- 02 Sep, 2020 1 commit
-
-
Nicklas Boman authored
Differential Revision: https://phabricator.services.mozilla.com/D89013
-