- 30 Apr, 2021 1 commit
-
-
Jamie Nicol authored
Previously we had disabled optimized shaders on Mali-T devices running Android versions up to 5.1, due to broken rendering. We have now had a report of the same issue on Android 7.1. As a precaution, disable optimized shaders for all Mali-T devices regardless of android version. Differential Revision: https://phabricator.services.mozilla.com/D113913
-
- 26 Apr, 2021 1 commit
-
-
Jamie Nicol authored
Bug 1707283 - Disable optimized shaders on Mali T devices running android 5.1 or below. r=nical, a=RyanVM Previously in bug 1689064 we disabled our usage of optimized shaders to work around a driver bug affecting Mali-T6xx devices. It now appears this bug affects Mali-T7xx and T8xx devices too, only on Android versions 5.1 or below. This patch disables shader optimization for all Mali-T devices when the Android version is 5.1 or below. Differential Revision: https://phabricator.services.mozilla.com/D113313
-
- 18 Mar, 2021 1 commit
-
-
Jamie Nicol authored
Bug 1507074 - Don't block webrender due to lack of GL_OES_EGL_image_external_essl3 support. r=aosmond Thanks to the previous patch in this series we can now play video using the non-essl3 GL_OES_EGL_image_external extension, therefore we no longer require the essl3 version. It is assumed that all android devices support GL_OES_EGL_image_external (non-essl3). Even if that is not the case, webrender is no worse off than layers in that regard. Differential Revision: https://phabricator.services.mozilla.com/D108909
-
- 17 Feb, 2021 1 commit
-
-
Jamie Nicol authored
On some Mali devices we have encountered driver crashes caused by calling textureSize(samplerExternalOES) in a shader without also potentially sampling from the texture in the shader. ARM's suggested workaround was to trick the driver in to thinking that the texture may be sampled from (ie by sampling in a branch which is never dynamically taken). This is done by checking the value of a dummy uniform, and sampling the texture if the value is non-default. Using a constant expression did not work because the compiler would optimize the condition (and therefore the sample) away. Also re-enable webrender on Mali-72 and G76 devices, as it was blocked due to this bug. Differential Revision: https://phabricator.services.mozilla.com/D105493
-
- 16 Feb, 2021 3 commits
-
-
Jamie Nicol authored
Note that quite a few Mali-Txxx devices still won't get webrender, due to lack of GL_OES_EGL_image_external_essl3 support. Bug 1507074 tracks lifting this requirement. Depends on D105338 Differential Revision: https://phabricator.services.mozilla.com/D105339
-
Jamie Nicol authored
Webrender has been enabled for most Adreno 5xx and 6xx devices for a while now, but 505 and 506 were held back due to bug 1609191. We were seeing a moderate number of crashes during what we suspected was shader compilation. The crashes on 505 and 506 have all but disappeared. Additionally, after shipping to the wider release audience we saw the same crashes on other 5xx devices, not just 505 and 506, but the numbers were never so high as to be worrying. So we are safe to ship to 505 and 506 as well. Depends on D105337 Differential Revision: https://phabricator.services.mozilla.com/D105338
-
Jamie Nicol authored
It appears to work well based on local testing, so let's enable in on nightly and see if any bugs are reported. Differential Revision: https://phabricator.services.mozilla.com/D105337
-
- 12 Feb, 2021 2 commits
-
-
Jamie Nicol authored
In bug 1688017 we blocked webrender on Mali-G76 devices due to reports of crashes when playing video. Based on more reports by users and further investigation of the crash data, it appears that Mali-G72 GPUs are also affected by the same bug, but only on Android 11 (for both GPUs). Crashes on other Mali GPUs and earlier android versions do exist, but in much lower numbers. Update the block to include G72 as well as G76, but only for Android 11. Differential Revision: https://phabricator.services.mozilla.com/D105047
-
Jamie Nicol authored
In bug 1688017 we blocked webrender on Mali-G76 devices due to reports of crashes when playing video. Based on more reports by users and further investigation of the crash data, it appears that Mali-G72 GPUs are also affected by the same bug, but only on Android 11 (for both GPUs). Crashes on other Mali GPUs and earlier android versions do exist, but in much lower numbers. Update the block to include G72 as well as G76, but only for Android 11. Differential Revision: https://phabricator.services.mozilla.com/D105047
-
- 11 Feb, 2021 4 commits
-
-
Jamie Nicol authored
Webrender's pre-optimized shaders result in completely broken rendering on a Huawei MediaPad M2 (Mali-T628). As a precaution, disable optimized shaders on all Mali-T6xx devices. Differential Revision: https://phabricator.services.mozilla.com/D104752
-
Brindusan Cristian authored
Backed out changeset e602ff8fea83 (bug 1689064) for assertion failures in gfxFeature.cpp. CLOSED TREE
-
Jamie Nicol authored
Webrender's pre-optimized shaders result in completely broken rendering on a Huawei MediaPad M2 (Mali-T628). As a precaution, disable optimized shaders on all Mali-T6xx devices. Differential Revision: https://phabricator.services.mozilla.com/D104752
-
Noemi Erli authored
-
- 10 Feb, 2021 4 commits
-
-
Jamie Nicol authored
Webrender's pre-optimized shaders result in completely broken rendering on a Huawei MediaPad M2 (Mali-T628). As a precaution, disable optimized shaders on all Mali-T6xx devices. Differential Revision: https://phabricator.services.mozilla.com/D104752
-
Jamie Nicol authored
Bug 1691925 - Block webrender on android devices which don't support GL_OES_EGL_image_external_essl3 r=aosmond Currently webrender requires the extension GL_OES_EGL_image_external_essl3 to render video. There exist some older GLES 3 devices which do not support this extension, and attempting to render video on these devices results in a shader compilation error and falling back to OpenGL layers. In bug 1507074 we will implement a long term solution for such devices, but in the meantime block webrender on devices which do not support this extension. Differential Revision: https://phabricator.services.mozilla.com/D104669
-
Narcis Beleuzu authored
-
Jamie Nicol authored
Bug 1691925 - Block webrender on android devices which don't support GL_OES_EGL_image_external_essl3 r=aosmond Currently webrender requires the extension GL_OES_EGL_image_external_essl3 to render video. There exist some older GLES 3 devices which do not support this extension, and attempting to render video on these devices results in a shader compilation error and falling back to OpenGL layers. In bug 1507074 we will implement a long term solution for such devices, but in the meantime block webrender on devices which do not support this extension. Differential Revision: https://phabricator.services.mozilla.com/D104669
-
- 02 Feb, 2021 2 commits
-
-
Jamie Nicol authored
A user reported completely broken rendering on their Mali-G31 device, starting when webrender was enabled. Block webrender on Mali-G31 devices until the cause has been identified and fixed. Differential Revision: https://phabricator.services.mozilla.com/D103748
-
Jamie Nicol authored
A user reported completely broken rendering on their Mali-G31 device, starting when webrender was enabled. Block webrender on Mali-G31 devices until the cause has been identified and fixed. Differential Revision: https://phabricator.services.mozilla.com/D103748
-
- 25 Jan, 2021 1 commit
-
-
Jamie Nicol authored
We're seeing reports of crashes when users attempt to watch video on Mali-G76 devices. Disable webrender for now on Mali-G76 until the underlying problem is identified and fixed. Differential Revision: https://phabricator.services.mozilla.com/D102903
-
- 02 Feb, 2021 1 commit
-
-
Jamie Nicol authored
A user reported completely broken rendering on their Mali-G31 device, starting when webrender was enabled. Block webrender on Mali-G31 devices until the cause has been identified and fixed. Differential Revision: https://phabricator.services.mozilla.com/D103748
-
- 25 Jan, 2021 5 commits
-
-
Jamie Nicol authored
We're seeing reports of crashes when users attempt to watch video on Mali-G76 devices. Disable webrender for now on Mali-G76 until the underlying problem is identified and fixed. Differential Revision: https://phabricator.services.mozilla.com/D102903
-
Andrew Osmond authored
As we make the transition to using EGL over GLX, we will need our detection code to be sufficient without EGL to determine the device in use. This patch makes us always use the EGL testing code over the GLX testing code, regardless of the pref/envvar setting. At the very least, we need to know the vendor ID of the device in use. We can determine this if there is only one GPU on the PCI list, if we get a driver name from Mesa, or if it is a proprietary driver (i.e. NVIDIA) which includes its name in the vendor ID. If we know the vendor ID, we can usually derive the device ID from the PCI list. We now also track which path glxtest took. If we successfully did the test via EGL, then we will allow the pref/envvar to use EGL instead of GLX. If the test reverted to GLX, then it will use GLX regardless of the pref/envvar. This is necessary because we need to know if the libraries are available or not -- some systems may be missing one or the other. Differential Revision: https://phabricator.services.mozilla.com/D102933
-
Noemi Erli authored
Backed out changeset 98349a6be0f6 (bug 1680512) for causing build bustages in GfxInfo.mm CLOSED TREE
-
Andrew Osmond authored
As we make the transition to using EGL over GLX, we will need our detection code to be sufficient without EGL to determine the device in use. This patch makes us always use the EGL testing code over the GLX testing code, regardless of the pref/envvar setting. At the very least, we need to know the vendor ID of the device in use. We can determine this if there is only one GPU on the PCI list, if we get a driver name from Mesa, or if it is a proprietary driver (i.e. NVIDIA) which includes its name in the vendor ID. If we know the vendor ID, we can usually derive the device ID from the PCI list. We now also track which path glxtest took. If we successfully did the test via EGL, then we will allow the pref/envvar to use EGL instead of GLX. If the test reverted to GLX, then it will use GLX regardless of the pref/envvar. This is necessary because we need to know if the libraries are available or not -- some systems may be missing one or the other. Differential Revision: https://phabricator.services.mozilla.com/D102933
-
Jamie Nicol authored
We're seeing reports of crashes when users attempt to watch video on Mali-G76 devices. Disable webrender for now on Mali-G76 until the underlying problem is identified and fixed. Differential Revision: https://phabricator.services.mozilla.com/D102903
-
- 18 Jan, 2021 1 commit
-
-
Robert Mader authored
Bug 1588904 - [Linux/EGL] Use correct rendering device in multi-GPU setup, r=stransky,emilio,jgilbert,geckoview-reviewers,m_kato Fetch the DRM device in the EGL version of glxtest, set it in gfxInfo and pass it to gfxVars. Finally, use it in nsDMABufDevice::Configure(). While on it, also clean up EGL typedefs and defines a bit to match how it's done for GLX. Inspired by and copied from wlroots and Xwayland. Thanks to emersion! Differential Revision: https://phabricator.services.mozilla.com/D98108
-
- 10 Nov, 2020 1 commit
-
-
Jamie Nicol authored
Differential Revision: https://phabricator.services.mozilla.com/D96597
-
- 24 Sep, 2020 1 commit
-
-
sotaro authored
Bug 1665815 - Avoid using scissored glClear() on Android Emulator with SwiftShader r=geckoview-reviewers,jnicol,agi Emulator with SwiftShader is buggy when attempting to clear picture cache textures with a scissor rect set. Differential Revision: https://phabricator.services.mozilla.com/D90644
-
- 17 Sep, 2020 1 commit
-
-
Jamie Nicol authored
Bug 1663355 - Always clear and render entire picture cache tiles on Mali-Gxx. r=gw,geckoview-reviewers,agi On Mali-Gxx there is a driver bug which causes partial updates to offscreen render targets to fail. This was originally encountered in bug 1558374, where we thought that the problem was just to do with scissored glClear()s, so we used a shader to clear the target instead of glClear(). On some sites, however, even this is not enough, and sometimes renderering to the target fails leaving some of the previous content in place. We appear to be able to work around this by ensuring that the entire render target is cleared, by calling glClear() with the scissor test disabled. This means that for picture cache tiles we must ensure the entire valid region is rendered. This patch also reverts the first attempt at a fix from bug 1558374, as it is no longer necessary since the entire target is being cleared. Differential Revision: https://phabricator.services.mozilla.com/D90531
-
- 17 Aug, 2020 1 commit
-
-
Jamie Nicol authored
Differential Revision: https://phabricator.services.mozilla.com/D87320
-
- 06 Aug, 2020 1 commit
-
-
Jamie Nicol authored
Bug 1656554 - Enable webrender on Adreno 5xx GPUs excluding 505 and 506. r=ktaeleman,geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D85740
-
- 20 Oct, 2020 1 commit
-
-
Jamie Nicol authored
Differential Revision: https://phabricator.services.mozilla.com/D94118
-
- 05 Aug, 2020 1 commit
-
-
Jamie Nicol authored
On Mali-G71 and G72 we see artifacts when scrolling around pages, in the form of black squares or bits of content appearing in the wrong location. This appears to be due to a driver bug when calling glClear() to clear a picture cache tile texture with a scissor rect set. We encountered a similar issue on some Intel hardware in bug 1638672, and worked around it by using a custom shader to clear the texture rather than glClear. This change applies this work around to Mali-Gxx devices too. Differential Revision: https://phabricator.services.mozilla.com/D85867
-
- 20 Jul, 2020 1 commit
-
-
Kris Taeleman authored
Bug 1654032 - Enable Webrender on beta/release for Adreno 6xx devices. r=jnicol,geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D84203
-
- 25 Jun, 2020 1 commit
-
-
Daosheng Mu authored
Bug 1602072 - Add a gfxInfo flag determine Firefox is embedded by FxR for telemetry. r=thomasmo,chutten,froydnj,jrmuizel,geckoview-reviewers,rbarker,snorp Differential Revision: https://phabricator.services.mozilla.com/D56233
-
- 23 Jun, 2020 2 commits
-
-
Kartikaya Gupta authored
Differential Revision: https://phabricator.services.mozilla.com/D80449
-
Narcis Beleuzu authored
Backed out 8 changesets (bug 1647225) for xpcshell failures on test_gfxBlacklist_Version.js CLOSED TREE Backed out changeset b6f88195da61 (bug 1647225) Backed out changeset a5b3f54cb5f2 (bug 1647225) Backed out changeset 6a1025189b0e (bug 1647225) Backed out changeset b95de94b444e (bug 1647225) Backed out changeset ed2c7dfd8373 (bug 1647225) Backed out changeset 1adc99494bcb (bug 1647225) Backed out changeset 5d0cf22c335a (bug 1647225) Backed out changeset 956b43a8636f (bug 1647225)
-
- 22 Jun, 2020 1 commit
-
-
Kartikaya Gupta authored
Depends on D80448 Differential Revision: https://phabricator.services.mozilla.com/D80449
-
- 31 Aug, 2020 1 commit
-
-
Sylvestre Ledru authored
# ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D88713
-