1. 05 Dec, 2019 1 commit
  2. 02 Dec, 2019 1 commit
  3. 31 Oct, 2019 1 commit
  4. 24 Oct, 2019 1 commit
  5. 17 Oct, 2019 1 commit
  6. 23 Sep, 2019 1 commit
  7. 11 Oct, 2019 1 commit
    • Kris Maglione's avatar
      Bug 1586911: Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv · b45bfec7
      Kris Maglione authored
      When we have a parser-created iframe which starts out in-process, transitions
      to remote, and then transitions back to in-process, we create separate
      DocShells for the first and last in-process loads. Since both are
      network-created, and have the same child index, they both try to add
      themselves as children to their parent's SHistory at the same index. And since
      the entry for the first DocShell already exists at that index when we try to
      add the second, that triggers an assertion.
      
      This isn't really ideal, but it is expected given the current state of session
      history under Fission. It should hopefully be solved more gracefully when the
      Fission-aware session history rewrite is done, but in the mean time, I think
      we should just ignore the conflict, since it's expected.
      
      Differential Revision: https://phabricator.services.mozilla.com/D48437
      
      --HG--
      extra : moz-landing-system : lando
      b45bfec7
  8. 21 Aug, 2019 1 commit
  9. 12 Jun, 2019 1 commit
  10. 22 May, 2019 1 commit
  11. 15 Apr, 2019 1 commit
    • Anny Gakhokidze's avatar
      Bug 1541515 - Consolidate IPC calls to nsISHEntry inside of... · 68641708
      Anny Gakhokidze authored
      Bug 1541515 - Consolidate IPC calls to nsISHEntry inside of nsDocShell::GetChildSHEntry, r=peterv, r=nika for adding sync IPC messages
      
      Currently, nsDocShell::GetChildSHEntry calls 3 sync IPC calls on nsISHEntry,
      and the method GetChildSHEntry only has one caller. By moving GetChildSHEntry
      method to parent process for nsISHEntry, resulting in a new method
      nsISHEntry::GetChildSHEntry, 3 sync IPC calls can be reduced to 1.
      
      Differential Revision: https://phabricator.services.mozilla.com/D27633
      
      --HG--
      extra : rebase_source : 1e76a1b07d827b35bae7ed6acca25aa8732c9ed0
      extra : source : 34d91f82faa36dd8d8ed721de365122d831f7b25
      extra : histedit_source : 86592bc747d506c546ec660e57087e78b9719cf7
      68641708
  12. 29 Mar, 2019 1 commit
    • Anny Gakhokidze's avatar
      Bug 1539482 - Reduce the number of IPC calls on nsISHEntry in... · ac22fc9f
      Anny Gakhokidze authored
      Bug 1539482 - Reduce the number of IPC calls on nsISHEntry in nsDocShell::LoadHistoryEntry, r=peterv, r=nika for adding sync IPC messages
      
      In nsDocShell::LoadHistoryEntry method, when it gets called
      from parent process, there are 13 sync IPC calls on nsISHEntry
      that retrieve  information from the session history entry and
      create a  doc shell load state object using the retrieved
      information.  By adding a new method 'CreateLoadInfo'on nsISHEntry,
      inside of which the doc shell load state object will be
      created (with appropriate data filled out) and returned,
      we eliminate 12 sync IPC call, resulting in just 1 IPC call
      to nsISHEntry::CreateLoadInfo.
      
      Differential Revision: https://phabricator.services.mozilla.com/D26042
      
      --HG--
      extra : rebase_source : a4e1fa52932fd5caabb59bd133e9fbee7f4d0e4a
      extra : amend_source : f4d9f01afac0337808ba347eb997ce83e6ae1488
      extra : source : 6ad53b35c7b4be933a3db1e1d45fa3da8a57abad
      extra : histedit_source : c08d0cebcc11a3a4f64d01566cb62d9a334a12ec
      ac22fc9f
  13. 26 Mar, 2019 2 commits
    • Anny Gakhokidze's avatar
      Bug 1539238 - Modify nsSHEntry::Create to consolidate setter calls on... · e5cb284f
      Anny Gakhokidze authored
      Bug 1539238 - Modify nsSHEntry::Create to consolidate setter calls on nsSHEntry in nsDocShell::AddToSessionHistory, r=peterv
      
      nsDocShell is the only consumer of nsISHEntry::Create, and
      in AddToSessionHistory method, after calling nsISHEntry::Create,
      it calls 8 setter methods on nsISHEntry, which results in a
      total of 9 sync IPC calls.
      
      With the proposed solution of setting everything via
      nsISHEntry::Create, we get a total of 1 sync IPC call.
      
      Differential Revision: https://phabricator.services.mozilla.com/D24979
      
      --HG--
      extra : rebase_source : af9c75043260a6333d789d3ca882173703f7bc29
      extra : amend_source : 334281153e24f9e9f0abac3983d32fb99dae6995
      extra : source : a8eed7c5d12c49366ad8acd706fa0e8464ed8549
      extra : histedit_source : 653daabf83d43571803a1e33c95a4804e4275e7d
      e5cb284f
    • Anny Gakhokidze's avatar
      Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in... · b0a8f8d7
      Anny Gakhokidze authored
      Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::AddToSessionHistory by adding nsSHEntry::ClearEntry method, r=peterv, r=nika for adding sync IPC messages
      
      Currently, nsDocShell repeatedly calls nsISHEntry::GetChildAt and
      nsISHEntry::RemoveChild  in nsDocShell::AddToSessionHistory,
      which results in twice as many IPC calls as the number of children
      a session history entry has. Additionally, there is one extra
      IPC sync call to nsISHEntry::AbandonBFCacheEntry after the loop.
      
      With the proposed solution, there will only be 1 sync IPC call.
      
      Differential Revision: https://phabricator.services.mozilla.com/D24978
      
      --HG--
      extra : rebase_source : ab98af417bcb28fdfcb1a115473b505fa8a70aa1
      extra : source : 0270d6b952ffa1704690c777c55fcaed30125b38
      extra : histedit_source : 9a031cb921ad8efa1bd96f7342e08337f3c0ca8a
      b0a8f8d7
  14. 04 Apr, 2019 1 commit
  15. 05 Mar, 2019 1 commit
  16. 01 Mar, 2019 1 commit
  17. 21 Feb, 2019 1 commit
  18. 12 Feb, 2019 1 commit
  19. 30 Nov, 2018 1 commit
  20. 30 Oct, 2018 1 commit
    • Kyle Machulis's avatar
      Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState; r=bz, nika · 6d3b4e74
      Kyle Machulis authored
      Creates the nsDocShellLoadState object, which is basically
      nsDocShellLoadInfo plus a few extra fields to make it usable as a
      single argument to nsDocShell::LoadURI (and eventually
      nsDocShell::InternalLoad).
      
      Subframe history handling is a huge logic block in
      nsDocShell::LoadURI, which is only used on history loads. This patch
      also extracts the logic out into its own function to make the body of
      LoadURI clearer.
      6d3b4e74
  21. 29 Oct, 2018 1 commit
  22. 26 Oct, 2018 1 commit
    • Kyle Machulis's avatar
      Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika · ca0550b3
      Kyle Machulis authored
      Creates the nsDocShellLoadState object, which is basically
      nsDocShellLoadInfo plus a few extra fields to make it usable as a
      single argument to nsDocShell::LoadURI (and eventually
      nsDocShell::InternalLoad).
      
      Subframe history handling is a huge logic block in
      nsDocShell::LoadURI, which is only used on history loads. This patch
      also extracts the logic out into its own function to make the body of
      LoadURI clearer.
      
      Differential Revision: https://phabricator.services.mozilla.com/D6944
      
      --HG--
      rename : docshell/base/nsDocShellLoadInfo.cpp => docshell/base/nsDocShellLoadState.cpp
      rename : docshell/base/nsDocShellLoadInfo.h => docshell/base/nsDocShellLoadState.h
      extra : moz-landing-system : lando
      ca0550b3
  23. 19 Oct, 2018 1 commit
  24. 18 Oct, 2018 1 commit
    • Kyle Machulis's avatar
      Bug 1492648 - Move from nsDocShellLoadInfo to nsDocShellLoadState r=bzbarsky,nika · 0bb3246a
      Kyle Machulis authored
      Creates the nsDocShellLoadState object, which is basically
      nsDocShellLoadInfo plus a few extra fields to make it usable as a
      single argument to nsDocShell::LoadURI (and eventually
      nsDocShell::InternalLoad).
      
      Subframe history handling is a huge logic block in
      nsDocShell::LoadURI, which is only used on history loads. This patch
      also extracts the logic out into its own function to make the body of
      LoadURI clearer.
      
      Differential Revision: https://phabricator.services.mozilla.com/D6944
      
      --HG--
      rename : docshell/base/nsDocShellLoadInfo.cpp => docshell/base/nsDocShellLoadState.cpp
      rename : docshell/base/nsDocShellLoadInfo.h => docshell/base/nsDocShellLoadState.h
      extra : moz-landing-system : lando
      0bb3246a
  25. 14 Sep, 2018 1 commit
  26. 12 Sep, 2018 2 commits
    • Nicholas Nethercote's avatar
      Bug 1490858 - Simplify some nsISHEntry attributes. r=nika · eb5daf71
      Nicholas Nethercote authored
      Both nsISHEntry.URI and nsISHEntry isSubFrame are readonly, but also have a
      setter. This is silly, so this patch removes the setter and makes them
      modifiable.
      
      The patch also renames nsISHEntry.setAsHistoryLoad() as setLoadTypeAsHistory(),
      which makes it clearer that it modifies the loadType attribute.
      
      --HG--
      extra : rebase_source : 7772e2c1d90d4fd9f462f20c777d6eacc65801c5
      eb5daf71
    • Nicholas Nethercote's avatar
      Bug 1490858 - Streamline nsISHEntry a little more. r=nika · f659c0df
      Nicholas Nethercote authored
      By marking some C++-only nsISHistory methods as [noscript] or [noscript,
      notxpcom].
      
      --HG--
      extra : rebase_source : 1216e755a227fd13f01057afd71ea082a2a79ad7
      f659c0df
  27. 07 Sep, 2018 1 commit
    • Nicholas Nethercote's avatar
      Bug 1490858 - Make most nsISHEntry attributes infallible. r=nika · f9b2172b
      Nicholas Nethercote authored
      The patch also removes some NS_ENSURE_ARG_POINTER checks from these attributes'
      getters. Most of these getters already lack such checks, and as long as the
      infallible getters are used a non-null pointer is guaranteed. In the worst case
      we'll safely null-crash anyway.
      
      --HG--
      extra : rebase_source : 87d4f7fccfa7ffb605c514cf8c2abd270a13b24a
      f9b2172b
  28. 04 Sep, 2018 1 commit
  29. 05 Sep, 2018 1 commit
  30. 22 Aug, 2018 2 commits
  31. 12 Jul, 2018 2 commits
  32. 10 Apr, 2018 1 commit
  33. 01 Nov, 2017 1 commit
  34. 23 Oct, 2017 1 commit
  35. 17 Oct, 2017 1 commit
  36. 22 Sep, 2017 1 commit