Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop

Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D2428

--HG--
extra : moz-landing-system : lando

Bug 1483786 - Add aOptions object param to 'replaceTabsWithWindow' function in browser/base/content/tabbrowser.js file. r=jaws

replaceTabsWithWindow calls replaceTabWithWindow to create a new window window with a first tab.
But unlike the later function, the former cited function don't take an object param (aOptions) containing informations such as the mouse position (which helps set the new window position).
To adress the issue, we added support for passing an option param to replaceTabsWithWindow which just transferts the param to replaceTabWithWindow.

Differential Revision: https://phabricator.services.mozilla.com/D4735

--HG--
extra : moz-landing-system : lando

Bug 1487402 - Selection should stop notifying AutoCopyListener of selection changes after unlinked r=smaug

This is a regression of bug 1486370.

Unlink of Selection removes all nsISelectionListener first, then, it removes
all its ranges since it does not want to notify the changes anymore.

After bug 1486370, Selection starts to store only bool flag whether it should
notify AutoCopyListener of selection changes. So, unless it sets the bool flag
to false in Unlink, it'll notify selection change caused by Unlink.

Differential Revision: https://phabricator.services.mozilla.com/D4690

--HG--
extra : moz-landing-system : lando

This does a few things that should help:

(1) Run the timeout only after resize events have stopped.

(2) Increase the timeout from 30ms to 100ms.  It doesn't need to be so fast.

(3) Add a parameter to formatValue that bypasses actually formatting the value and instead only ensures the host is visible.  There's no need in this case to keep removing the formatting and then adding it back.  Having a "formatValue" method take a parameter to skip formatting is kind of weird, though.  At first I tried factoring out the make-host-visible part, but that requires also factoring out all the logic that determines whether the value is a formattable URL, and that ended up being ugly.  I'm open to better ideas.

Based on an earlier patch by Marco Bonardo <mbonardo@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D4502

--HG--
extra : moz-landing-system : lando

It's unused.

The patch also renames nsIExternalSharingAppService.idl as
nsISharingHandlerApp.idl, because the only thing left in the file is the
declaration of nsISharingHandlerApp.

--HG--
rename : uriloader/exthandler/nsIExternalSharingAppService.idl => uriloader/exthandler/nsISharingHandlerApp.idl
extra : rebase_source : c1375d75f3c824c9fadd4164201a7e78c7227020

Those mozconfigs do things in common that are already in
mozconfig.linux. Let's just use that.

This will make the build have the binutils toolchain in PATH rather than
passing it to CC/CXX, which is better because it also makes the build
use tools such as ar, ranlib, objcopy from the binutils toolchain,
rather than the old system ones.

Differential Revision: https://phabricator.services.mozilla.com/D4649

The frame for a background image should be associated with the image
request. This was done on the non-WebRender path in
nsCSSRendering::PaintStyleImageLayerWithSC but otherwise missing for the
WebRender path. This is important because the association is what allows
the FRAME_UPDATE from imagelib to cause a repaint. Without it, it will
manifest as incomplete or missing background images, in particular after
the background image SourceSurface has been released to save memory.

When the frame updates for an animated image, it will trigger
nsImageBoxFrame::OnFrameUpdate to be called. We did not change this for
WebRender, and thus it was missing similar checks added to
nsImageFrame::InvalidateSelf as originally added in bug 1382985. This
caused us to ignore the frame update, and thus the animation never
appeared to progress.

Also added line breaks to make the file more readable (while making the diff
harder to review).

--HG--
extra : source : 7b2d3f4315562ef9197b3b22bdb5c9f9f7df1bdf

--HG--
extra : source : c3120123a0908882d906d236a8ee6c442cf61502

--HG--
extra : source : ddb335eedf66c8605a5c3f5c7b8748f1304fe304

This simply applies the file other-licenses/7zstub/mozila_customizations.diff,
which did not need to be changed in this patch series because it applies cleanly
to the LZMA SDK code, which is organized in the same way as the 7-zip code.

--HG--
extra : source : a6abc1d22d6c01e3fa07f52e468bb045630a3a1d

--HG--
extra : source : 75e2ff0c912d095abc2b27bbb24b3399153f2505

--HG--
extra : source : 138ba76674c6f9d8f280f55dc12bf10b8ccfc989

This does not change the outward behavior of LossyUTF8ToUTF16(). Both
ToNewUnicode() and CopyASCIItoUTF16() convert from Latin1 to UTF-16.

MozReview-Commit-ID: 8SDgvoGaN4A

Differential Revision: https://phabricator.services.mozilla.com/D4639

--HG--
extra : moz-landing-system : lando

Explicitly specify which load we're waiting for to avoid intermittent oranges

Differential Revision: https://phabricator.services.mozilla.com/D4692

--HG--
extra : moz-landing-system : lando

The fix for bug 1482810 requires an upstream change to the cc crate: if CFLAGS is defined, then don't enable warnings by default.  That change was included in cc crate version 1.0.23, and this change vendors that version of the cc crate into mozilla-central.

MozReview-Commit-ID: Krfrs1dSN9d

Differential Revision: https://phabricator.services.mozilla.com/D4699

--HG--
extra : moz-landing-system : lando

In conjunction with the cc crate changes in https://github.com/alexcrichton/cc-rs/pull/342 (which I'll land in https://phabricator.services.mozilla.com/D4699), this hides warnings generated by C code in Rust crates (by removing warnings flags from CFLAGS when compiling Rust libraries).

MozReview-Commit-ID: 9CZgLGbWjbA

Differential Revision: https://phabricator.services.mozilla.com/D3939

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D4686

--HG--
extra : moz-landing-system : lando

Bug 1487437: Only show a space for a pending icon if it started loading while the throbber was showing. r=dao.

This stops us from showing a pending space when an icon is added after loading is
complete causing us to shift the title when both pending and previous icon are
shown.

Differential Revision: https://phabricator.services.mozilla.com/D4694

--HG--
extra : moz-landing-system : lando

This warning spam happens particularly with WebRTC, but I can see it
happening for any third-party software whose use of WINVER and friends
conflicts with our own.  Let's just change mozilla-config.h to avoid
defining these macros if they're already defined via the command line.

Bug 1487309 - Improve AssignLiteral() and AppendLiteral() documentation to talk about u"" literals. r=froydnj

MozReview-Commit-ID: 60NCtRgKRcn

Differential Revision: https://phabricator.services.mozilla.com/D4641

--HG--
extra : moz-landing-system : lando

Backed out changeset fc437d64c831 (bug 1486556) for breaking coordination between record/replay system and helper threads.

--HG--
extra : rebase_source : 6fd771863bd14d659661553667396458c9c24eec

The old code assumes that it's OK to use nsAString::BeginWriting() to write
past the string's logical length if the string has enough capacity. This is
bogus, because the string doesn't know of data written past its logical
length.

The BulkWrite API has been created precisely for this purpose and allows
orderly capacity-aware low-level writes to the string.

MozReview-Commit-ID: BYQHl8Z9Fbd

Differential Revision: https://phabricator.services.mozilla.com/D3886

--HG--
extra : moz-landing-system : lando