Bug 1597211 - Use InitializedOnce to reduce statefulness of Cursor class. r=dom-workers-and-storage-reviewers,asuth

Differential Revision: https://phabricator.services.mozilla.com/D53951

--HG--
extra : moz-landing-system : lando

Bug 1597211 - Use EmplaceBack instead of AppendResult, and use return value rather than output parameter. r=dom-workers-and-storage-reviewers,ytausky

Differential Revision: https://phabricator.services.mozilla.com/D53938

--HG--
extra : moz-landing-system : lando

Bug 1597211 - Calculate size of individual cursor response entries. r=dom-workers-and-storage-reviewers,ytausky

Differential Revision: https://phabricator.services.mozilla.com/D53937

--HG--
extra : moz-landing-system : lando

Bug 1597211 - Stop processing entries when maximum message size has been exceeded. r=dom-workers-and-storage-reviewers,ytausky

Differential Revision: https://phabricator.services.mozilla.com/D53936

--HG--
extra : moz-landing-system : lando

Bug 1597211 - Adjust parameters and return types to allow passing response size information. r=dom-workers-and-storage-reviewers,ytausky

Differential Revision: https://phabricator.services.mozilla.com/D53935

--HG--
extra : moz-landing-system : lando

Bug 1598164 - Fixed log messages, use serial number of transaction. r=dom-workers-and-storage-reviewers,janv

Differential Revision: https://phabricator.services.mozilla.com/D54963

--HG--
extra : moz-landing-system : lando

Bug 1600906 - Make use of FlippedOnce in VersionChangeTransaction. r=dom-workers-and-storage-reviewers,ytausky

Depends on D55081

Differential Revision: https://phabricator.services.mozilla.com/D55674

--HG--
extra : moz-landing-system : lando

Bug 1600906 - Make use of FlippedOnce in ThreadRunnable. r=dom-workers-and-storage-reviewers,ytausky

Depends on D55680

Differential Revision: https://phabricator.services.mozilla.com/D55681

--HG--
extra : moz-landing-system : lando

Depends on D55679

Differential Revision: https://phabricator.services.mozilla.com/D55680

--HG--
extra : moz-landing-system : lando

Depends on D55678

Differential Revision: https://phabricator.services.mozilla.com/D55679

--HG--
extra : moz-landing-system : lando

Bug 1600906 - Make use of FlippedOnce in ConnectionPool. r=dom-workers-and-storage-reviewers,ytausky

Depends on D55677

Differential Revision: https://phabricator.services.mozilla.com/D55678

--HG--
extra : moz-landing-system : lando

Bug 1600906 - Make use of FlippedOnce in FullObjectStoreMetadata. r=dom-workers-and-storage-reviewers,ytausky

Depends on D55676

Differential Revision: https://phabricator.services.mozilla.com/D55677

--HG--
extra : moz-landing-system : lando

Bug 1600906 - Make use of FlippedOnce in FullIndexMetadata. r=dom-workers-and-storage-reviewers,ytausky

Depends on D55675

Differential Revision: https://phabricator.services.mozilla.com/D55676

--HG--
extra : moz-landing-system : lando

Depends on D55674

Differential Revision: https://phabricator.services.mozilla.com/D55675

--HG--
extra : moz-landing-system : lando

The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55442

--HG--
extra : moz-landing-system : lando

Bug 1596395 - Avoid copying of tokenizer token sub-strings. r=dom-workers-and-storage-reviewers,edenchuang

Differential Revision: https://phabricator.services.mozilla.com/D53013

--HG--
extra : moz-landing-system : lando

Bug 1597191 - Do not fail cursor operation when processing preloaded entries. r=dom-workers-and-storage-reviewers,asuth

Differential Revision: https://phabricator.services.mozilla.com/D53803

--HG--
extra : moz-landing-system : lando

Bug 1597191 - Remove duplication between OpenOp::Do*DatabaseWork functions. r=dom-workers-and-storage-reviewers,ytausky

Differential Revision: https://phabricator.services.mozilla.com/D53802

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D53801

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D53800

--HG--
extra : moz-landing-system : lando

Bug 1597191 - Pull up SendSuccessResult to CursorOpBase to remove code duplication. r=dom-workers-and-storage-reviewers,edenchuang,asuth

Differential Revision: https://phabricator.services.mozilla.com/D53799

--HG--
extra : moz-landing-system : lando

Bug 1597191 - Removed code duplication between response type cases. r=dom-workers-and-storage-reviewers,asuth

Differential Revision: https://phabricator.services.mozilla.com/D53798

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D54321

--HG--
extra : moz-landing-system : lando

Bug 1592934 - Refactor some storage initialization methods before adding new telemetry probes; r=ttung

Differential Revision: https://phabricator.services.mozilla.com/D54307

--HG--
extra : moz-landing-system : lando

Reverts regression introduced by 449a5f02a960116e0f901ae3570170ab642ecea0.

Differential Revision: https://phabricator.services.mozilla.com/D54497

--HG--
extra : moz-landing-system : lando

Bug 1598610 - Unify initialization of TransactionDatabaseOperationBase members by members initializers. r=dom-workers-and-storage-reviewers,janv

Depends on D54280

Differential Revision: https://phabricator.services.mozilla.com/D54284

--HG--
extra : moz-landing-system : lando

Bug 1598610 - Always initialize TransactionDatabaseOperationBase::mWaitingForContinue. r=dom-workers-and-storage-reviewers,janv

Differential Revision: https://phabricator.services.mozilla.com/D54280

--HG--
extra : moz-landing-system : lando

Assertions on the type of an IPDL-defined union before accessing it are redundant,
since the generated accessors already contain a MOZ_RELEASE_ASSERT for checking
the type. Redundant assertions unnecessarily clutter the code, so they are removed.

Differential Revision: https://phabricator.services.mozilla.com/D53797

--HG--
extra : moz-landing-system : lando

Bug 1597038 - Fix crash in Cursor::SendResponseInternal with nsresult response type and non-empty files. r=dom-workers-and-storage-reviewers,ttung

Differential Revision: https://phabricator.services.mozilla.com/D53393

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D51571

--HG--
extra : moz-landing-system : lando

Bug 1168606 - Replace custom for loops over hashtables by range-based for/STL algorithms. r=ttung,asuth

Differential Revision: https://phabricator.services.mozilla.com/D45506

--HG--
extra : moz-landing-system : lando

Bug 1168606 - Replace pseudo-move constructor of StructuredCloneReadInfo by explicit DeserializeStructuredCloneReadInfo function. r=ttung,asuth

Differential Revision: https://phabricator.services.mozilla.com/D46593

--HG--
extra : moz-landing-system : lando

Depends on D44443

Differential Revision: https://phabricator.services.mozilla.com/D45308

--HG--
extra : moz-landing-system : lando

Depends on D44377

Differential Revision: https://phabricator.services.mozilla.com/D44443

--HG--
extra : moz-landing-system : lando

Bug 1168606 - Reduced duplication for handling sort key comparisons in SQL queries and improved type-safety. r=ttung,asuth

Depends on D44009

Differential Revision: https://phabricator.services.mozilla.com/D44377

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D44009

--HG--
extra : moz-landing-system : lando

Depends on D43252

Differential Revision: https://phabricator.services.mozilla.com/D43461

--HG--
extra : moz-landing-system : lando

Bug 1168606 - Send extra records with every ObjectStoreCursorResponse if enabled by pref. r=ttung,asuth

Differential Revision: https://phabricator.services.mozilla.com/D43252

--HG--
extra : moz-landing-system : lando

There were 3 checks for this preference.  Prior to bug 1079355 which ignored the
pref for system principals, the checks were all straightforward pref checks.

The conditionals are somewhat confusing as written.  The main idea is the code
inside the blocks only executes if:
- The preference is disabled.
- The RV was success (we don't want to steal error handling, just prevent
  success.)
- We're not dealing with the system principal.

As such, I'm removing the full conditional blocks.

Differential Revision: https://phabricator.services.mozilla.com/D51672

--HG--
extra : moz-landing-system : lando