1. 07 Mar, 2019 1 commit
  2. 06 Mar, 2019 2 commits
  3. 22 Feb, 2019 1 commit
  4. 06 Mar, 2019 7 commits
  5. 05 Mar, 2019 1 commit
  6. 06 Mar, 2019 1 commit
    • dlee's avatar
      Bug 1353956 - P4. Add header and CRC32 checksum to SafeBrowsing V4 prefix files. r=gcp · 7bc29f97
      dlee authored
      After this patch, we may have the following files in SafeBrowsing
      directory:
      - (v2) .sbstore  : Store V2 chunkdata, for update, MD5 integrity check
                         while load
      - (v2) .pset     : Store V2 prefixset, for lookup, load upon startup, no
                        integrity check
      - (v4) .metadata : Store V4 state, for update, no integrity check
      - (v4) .vlpset   : Store V4 prefixset, for lookup, load upon startup,
                         CRC32 integrity check
      - (v4) .pset     : V4 prefix set before this patch, should be removed
      
      The magic string is also added to ".vlpset" header so we can add
      a telemetry to see if sanity check is good enough for prefix set
      integrity check (The telemetry is not yet added). If yes, we can remove
      the CRC32 in the future for even better performance.
      
      Differential Revision: https://phabricator.services.mozilla.com/D21463
      
      --HG--
      extra : moz-landing-system : lando
      7bc29f97
  7. 04 Mar, 2019 1 commit
    • Dimi Lee's avatar
      Bug 1353956 - P3. Separate file processing and prefix data processing for... · b8f59ed8
      Dimi Lee authored
      Bug 1353956 - P3. Separate file processing and prefix data processing for SafeBrowsing prefix set. r=gcp
      
      SafeBrowsing prefix files LOAD/SAVE operations are handled in xxxPrefixSet.cpp.
      It would be more clear if xxxPrefixSet.cpp only processes prefix data,
      while LookupCacheV2/LookupCacheV4 which use prefix set process file.
      
      This patch doesn't change any behavior, testcases need to update because
      the LookupCache & xxxPrefixSet APIs are changed.
      
      Differential Revision: https://phabricator.services.mozilla.com/D21462
      
      --HG--
      extra : moz-landing-system : lando
      b8f59ed8
  8. 28 Feb, 2019 2 commits
    • dlee's avatar
      Bug 1353956 - P2. Do not use SHA-256 while loading the V4 prefix files. r=gcp · d253a723
      dlee authored
      SHA256 is an expensive operation, we should avoid using them if
      possible. SafeBrowsing prefix files are loaded during startup and
      verify integrity with SHA256 which may affect the performance
      especially on the low-end device.
      
      This patch simply removes the SHA256 integrity check. CRC32 version
      integrity check will be introduced in the other patch.
      
      This patch also changes the behavior of recording
      "Telemetry::URLCLASSIFIER_VLPS_LOAD_CORRUPT" a little bit.
      It used to records only once per session(during startup, the first
      time we load prefix set), now it records per update.
      
      Differential Revision: https://phabricator.services.mozilla.com/D21461
      
      --HG--
      extra : moz-landing-system : lando
      d253a723
    • Dimi Lee's avatar
      Bug 1353956 - P1. Rename checksum used in SafeBrowsing V4 to SHA256. r=gcp · 10329322
      Dimi Lee authored
      SafeBrowsing V4 protocol use SHA-256 as the checksum to check integrity
      of update data and also the integrity of prefix files.
      
      SafeBrowsing V2 HashStore use MD5 as the checksum to check integrity of
      .sbstore
      
      Since we are going to use CRC32 as the integrity check of V4 prefix files,
      I think rename V4 "checksum" to SHA256 can improve readability.
      
      Differential Revision: https://phabricator.services.mozilla.com/D21460
      
      --HG--
      extra : moz-landing-system : lando
      10329322
  9. 06 Mar, 2019 18 commits
  10. 05 Mar, 2019 1 commit
  11. 06 Mar, 2019 4 commits
  12. 05 Mar, 2019 1 commit
    • Mike Hommey's avatar
      Bug 1530908 - Use a transform for try --artifact instead of a morph. r=tomprince · 39a1a320
      Mike Hommey authored
      While the morph was changing the treeherder symbol to `Ba` for all jobs,
      doing so with a transform fails because of the conflicting symbol check
      (as multiple jobs in the same category would end up with `Ba`). So
      instead, we append `a` to the existing symbol.
      
      We also change the documentation wrt templates for try pushes, as the
      artifact template is now essentially gone (although technically, mach
      try will still set params['templates']['artifacts']['enabled'] for now,
      and the template still exists, albeit empty).
      
      Differential Revision: https://phabricator.services.mozilla.com/D22054
      
      --HG--
      extra : moz-landing-system : lando
      39a1a320