1. 05 Feb, 2021 40 commits
    • Kathleen Brade's avatar
      Bug 26961: New user onboarding. · 701a0d6f
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Reuse the Firefox onboarding mechanism with minimal changes.
      Localizable strings are pulled in from Torbutton (if Torbutton is
        not installed, we lack about:tor and no tour will be shown).
      Replace SVG images with PNGs (see bug 27002),
      For defense in depth, omit include OnboardingTelemetry.jsm entirely.
      Added support for the following UITour page event:
        torBrowserOpenSecuritySettings
      
      Also fix bug 27403: the onboarding bubble is not always displayed.
      
      Arthur suggested to make the onboarding bubble visible on displays with
      less than 960px width available, so we choose 200px instead.
      
      Also fix bug 28628: Change onboarding Security panel to open new
      Security Level panel.
      
      Also fix bug 27484: Improve navigation within onboarding.
      
      Bug 27082: enable a limited UITour
      
      Disallow access to UITour functionality from all pages other than
        about:home, about:newtab, and about:tor.
      Implement a whitelist mechanism for page actions.
      
      Bug 26962 - implement new features onboarding (part 1...
      701a0d6f
    • Alex Catarineu's avatar
      Bring back old Firefox onboarding · 9d7b5f70
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"
      
      This reverts commit f7ffd78b.
      
      Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
      
      This reverts commit 057fe36f.
      
      Bug 28822: Convert onboarding to webextension
      
      Partially revert 1564367 (controlCenter in UITour.jsm)
      9d7b5f70
    • Alex Catarineu's avatar
      Bug 27511: Add new identity button to toolbar · 4d961f3a
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Also added 'New circuit for this site' button to CustomizableUI, but
      not visible by default.
      4d961f3a
    • Alex Catarineu's avatar
      Bug 31575: Replace Firefox Home (newtab) with about:tor · 132042b8
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Avoid loading AboutNewTab in BrowserGlue.jsm in order
      to avoid several network requests that we do not need. Besides,
      about:newtab will now point to about:blank or about:tor (depending
      on browser.newtabpage.enabled) and about:home will point to
      about:tor.
      132042b8
    • Alex Catarineu's avatar
      Bug 26345: Hide tracking protection UI · 501bd1f0
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      501bd1f0
    • Alex Catarineu's avatar
    • Georg Koppen's avatar
      Bug 30541: Disable WebGL readPixel() for web content · 9aeddd0b
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      9aeddd0b
    • Richard Pospesel's avatar
      Bug 23247: Communicating security expectations for .onion · 51631259
      Richard Pospesel authored and Matthew Finkel's avatar Matthew Finkel committed
      Encrypting pages hosted on Onion Services with SSL/TLS is redundant
      (in terms of hiding content) as all traffic within the Tor network is
      already fully encrypted.  Therefore, serving HTTP pages from an Onion
      Service is more or less fine.
      
      Prior to this patch, Tor Browser would mostly treat pages delivered
      via Onion Services as well as pages delivered in the ordinary fashion
      over the internet in the same way.  This created some inconsistencies
      in behaviour and misinformation presented to the user relating to the
      security of pages delivered via Onion Services:
      
       - HTTP Onion Service pages did not have any 'lock' icon indicating
         the site was secure
       - HTTP Onion Service pages would be marked as unencrypted in the Page
         Info screen
       - Mixed-mode content restrictions did not apply to HTTP Onion Service
         pages embedding Non-Onion HTTP content
      
      This patch fixes the above issues, and also adds several new 'Onion'
      icons to the mix to indicate all of the various permutations of Onion
      Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
      
      Strings for Onion Service Page Info page are pulled from Torbutton's
      localization strings.
      51631259
    • Alex Catarineu's avatar
      Bug 28369: Stop shipping pingsender executable · 1ed238ea
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      1ed238ea
    • Arthur Edelstein's avatar
      Bug 26353: Prevent speculative connect that violated FPI. · 78a902b2
      Arthur Edelstein authored and Matthew Finkel's avatar Matthew Finkel committed
      Connections were observed in the catch-all circuit when
      the user entered an https or http URL in the URL bar, or
      typed a search term.
      78a902b2
    • Richard Pospesel's avatar
      Bug 25658: Replace security slider with security level UI · b1fab128
      Richard Pospesel authored and Matthew Finkel's avatar Matthew Finkel committed
      This patch adds a new 'securitylevel' component to Tor Browser intended
      to replace the torbutton 'Security Slider'.
      
      This component adds a new Security Level toolbar button which visually
      indicates the current global security level via icon (as defined by the
      extensions.torbutton.security_slider pref), a drop-down hanger with a
      short description of the current security level, and a new section in
      the about:preferences#privacy page where users can change their current
      security level. In addition, the hanger and the preferences page will
      show a visual warning when the user has modified prefs associated with
      the security level and provide a one-click 'Restore Defaults' button to
      get the user back on recommended settings.
      
      Strings used by this patch are pulled from the torbutton extension, but
      en-US defaults are provided if there is an error loading from the
      extension. With this patch applied, the usual work-flow of "./mach build
      && ./mach run" work as expected, even if the torbutton extension is
      disabled.
      b1fab128
    • Igor Oliveira's avatar
      Bug 23104: Add a default line height compensation · 3faddde7
      Igor Oliveira authored and Matthew Finkel's avatar Matthew Finkel committed
      Many fonts have issues with their vertical metrics. they
      are used to influence the height of ascenders and depth
      of descenders. Gecko uses it to calculate the line height
      (font height + ascender + descender), however because of
      that idiosyncratic behavior across multiple operating
      systems, it can be used to identify the user's OS.
      
      The solution proposed in the patch uses a default factor
      to be multiplied with the font size, simulating the concept
      of ascender and descender. This way all operating
      systems will have the same line height only and only if the
      frame is outside the chrome.
      3faddde7
    • Georg Koppen's avatar
      Bug 21830: Copying large text from web console leaks to /tmp · 2b27c665
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      Patch written by Neill Miller
      2b27c665
    • Kathleen Brade's avatar
      Bug 21431: Clean-up system extensions shipped in Firefox · 5b960b35
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Only ship the pdfjs extension.
      5b960b35
    • Georg Koppen's avatar
      Bug 16285: Exclude ClearKey system for now · 6806086a
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      In the past the ClearKey system had not been compiled when specifying
      --disable-eme. But that changed and it is even bundled nowadays (see:
      Mozilla's bug 1300654). We don't want to ship it right now as the use
      case for it is not really visible while the code had security
      vulnerabilities in the past.
      6806086a
    • boklm's avatar
      Bug 21907: Fix runtime error on CentOS 6 · 977f50ff
      boklm authored and Matthew Finkel's avatar Matthew Finkel committed
      In Mozilla bug 1324780, support for building with glib 2.28 (the version
      available in CentOS 6) was added. However we are building on Debian
      Wheezy which has glib 2.32. We fix that by backing out all glib > 2.28
      code paths.
      977f50ff
    • Mike Perry's avatar
      Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing · ce59b465
      Mike Perry authored and Matthew Finkel's avatar Matthew Finkel committed
      eBay and Amazon don't treat Tor users very well. Accounts often get locked and
      payments reversed.
      
      Also:
      Bug 16322: Update DuckDuckGo search engine
      
      We are replacing the clearnet URL with an onion service one (thanks to a
      patch by a cypherpunk) and are removing the duplicated DDG search
      engine. Duplicating DDG happend due to bug 1061736 where Mozilla
      included DDG itself into Firefox. Interestingly, this caused breaking
      the DDG search if JavaScript is disabled as the Mozilla engine, which
      gets loaded earlier, does not use the html version of the search page.
      Moreover, the Mozilla engine tracked where the users were searching from
      by adding a respective parameter to the search query. We got rid of that
      feature as well.
      
      Also:
      This fixes bug 20809: the DuckDuckGo team has changed its server-side
      code in a way that lets users with JavaScript enabled use the default
      landing page while those without JavaScript available get red...
      ce59b465
    • Kathleen Brade's avatar
      Bug 16940: After update, load local change notes. · 61b1ed0f
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Add an about:tbupdate page that displays the first section from
      TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
      post-update page (typically our blog entry for the release).
      
      Always load about:tbupdate in a content process, but implement the
      code that reads the file system (changelog) in the chrome process
      for compatibility with future sandboxing efforts.
      
      Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
      changelog page that is designed to be displayed via a link that is on
      about:tor.
      61b1ed0f
    • Kathleen Brade's avatar
      Bug 13379: Sign our MAR files. · 1d7d3075
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Configure with --enable-verify-mar (when updating, require a valid
        signature on the MAR file before it is applied).
      Use the Tor Browser version instead of the Firefox version inside the
        MAR file info block (necessary to prevent downgrade attacks).
      Use NSS on all platforms for checking MAR signatures (instead of using
        OS-native APIs, which Mozilla does on Mac OS and Windows). So that the
        NSS and NSPR libraries the updater depends on can be found at runtime,
        we add the firefox directory to the shared library search path on macOS.
        On Linux, rpath is used by Mozilla to solve that problem, but that
        approach won't work on macOS because the updater executable is copied
        during the update process to a location that is under TorBrowser-Data,
        and the location of TorBrowser-Data varies.
      
      Also includes the fix for bug 18900.
      1d7d3075
    • Kathleen Brade's avatar
      Bug 4234: Use the Firefox Update Process for Tor Browser. · ffb33c63
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      The following files are never updated:
        TorBrowser/Data/Browser/profiles.ini
        TorBrowser/Data/Browser/profile.default/bookmarks.html
        TorBrowser/Data/Tor/torrc
      Mac OS: Store update metadata under TorBrowser/UpdateInfo.
      Removed the %OS_VERSION% component from the update URL (13047) and
        added support for minSupportedOSVersion, an attribute of the
        <update> element that may be used to trigger Firefox's
        "unsupported platform" behavior.
      Hide the "What's new" links (set app.releaseNotesURL value to about:blank).
      Windows: disable "runas" code path in updater (15201).
      Windows: avoid writing to the registry (16236).
      Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
        16014, 16909, 24476, and 25909.
      
      Also fix Bug 26049: reduce the delay before the update prompt is displayed.
      Instead of Firefox's 2 days, we use 1 hour (after which time the update
      doorhanger will be displayed).
      
      Also fix bug 27221: purge the startup cache if the Tor Br...
      ffb33c63
    • Kathleen Brade's avatar
      Bug 19121: reinstate the update.xml hash check · 59696f4f
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Revert most changes from Mozilla Bug 1373267 "Remove hashFunction and
      hashValue attributes from nsIUpdatePatch and code related to these
      attributes." Changes to the tests were not reverted; the tests have
      been changed significantly and we do not run automated updater tests
      for Tor Browser at this time.
      
      Also partial revert of commit f1241db6.
      
      Revert the nsUpdateService.js changes from Mozilla Bug 862173 "don't
      verify mar file hash when using mar signing to verify the mar file
      (lessens main thread I/O)."
      
      Changes to the tests were not reverted; the tests have been changed
      significantly and we do not run automated updater tests for
      Tor Browser at this time.
      
      We kept the addition to the AppConstants API in case other JS code
      references it in the future.
      59696f4f
    • teor's avatar
      Bug 21724: Make Firefox and Tor Browser distinct macOS apps · 2ddadfa3
      teor authored and Matthew Finkel's avatar Matthew Finkel committed
      When macOS opens a document or selects a default browser, it sometimes
      uses the CFBundleSignature. Changing from the Firefox MOZB signature to
      a different signature TORB allows macOS to distinguish between Firefox
      and Tor Browser.
      2ddadfa3
    • Kathleen Brade's avatar
      Bug 11641: change TBB directory structure to be more like Firefox's · 92d325f3
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Unless the -osint command line flag is used, the browser now defaults
      to the equivalent of -no-remote.  There is a new -allow-remote flag that
      may be used to restore the original (Firefox-like) default behavior.
      92d325f3
    • Kathleen Brade's avatar
      Bug 19273: Avoid JavaScript patching of the external app helper dialog. · a21b8be4
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      When handling an external URI or downloading a file, invoke Torbutton's
      external app blocker component (which will present a download warning
      dialog unless the user has checked the "Automatically download files
      from now on" box).
      
      For e10s compatibility, avoid using a modal dialog and instead use
      a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton
      to indicate the user's desire to cancel or continue each request.
      
      Other bugs fixed:
       Bug 21766: Crash with e10s enabled while trying to download a file
       Bug 21886: Download is stalled in non-e10s mode
       Bug 22471: Downloading files via the PDF viewer download button is broken
       Bug 22472: Fix FTP downloads when external helper app dialog is shown
       Bug 22610: Avoid crashes when canceling external helper app downloads
       Bug 22618: Downloading pdf file via file:/// is stalling
      a21b8be4
    • Georg Koppen's avatar
      Bug 18821: Disable libmdns for Android and Desktop · f879b33b
      Georg Koppen authored and Matthew Finkel's avatar Matthew Finkel committed
      There should be no need to remove the OS X support introduced in
      https://bugzilla.mozilla.org/show_bug.cgi?id=1225726 as enabling this
      is governed by a preference (which is actually set to `false`). However,
      we remove it at build time as well (defense in depth).
      
      This is basically a backout of the relevant passages of
      https://hg.mozilla.org/mozilla-central/rev/6bfb430de85d,
      https://hg.mozilla.org/mozilla-central/rev/609b337bf7ab and
      https://hg.mozilla.org/mozilla-central/rev/8e092ec5fbbd.
      
      Fixed bug 21861 (Disable additional mDNS code to avoid proxy bypasses)
      as well.
      f879b33b
    • Kathleen Brade's avatar
      Bug 18800: Remove localhost DNS lookup in nsProfileLock.cpp · 81ffeeab
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Instead of using the local computer's IP address within
      symlink-based profile lock signatures, always use 127.0.0.1.
      81ffeeab
    • Kathleen Brade's avatar
      Bug 16620: Clear window.name when no referrer sent · 8b334c91
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Convert JS implementation (within Torbutton) to a C++ browser patch.
      8b334c91
    • Mike Perry's avatar
      Bug 2176: Rebrand Firefox to TorBrowser · 1d73f90a
      Mike Perry authored and Matthew Finkel's avatar Matthew Finkel committed
      See also Bugs #5194, #7187, #8115, #8219.
      
      This patch does some basic renaming of Firefox to TorBrowser. The rest of the
      branding is done by images and icons.
      
      Also fix bug 27905.
      
      Bug 25702: Update Tor Browser icon to follow design guidelines
      
      - Updated all of the branding in /browser/branding/official with new 'stable'
      icon series.
      - Updated /extensions/onboarding/content/img/tor-watermark.png with new icon and
      add the source svg in the same directory
      - Copied /browser/branding/official over /browser/branding/nightly and the new
      /browser/branding/alpha directories. Replaced content with 'nightly' and
      'alpha' icon series.
      Updated VisualElements_70.png and VisualElements_150.png with updated icons in
      each branding directory (fixes #22654)
      - Updated firefox.VisualElementsManfiest.xml with updated colors in each
      branding directory
      - Updated content/identity-icons-brand.svg with Tor Browser icon (fixes #28111)
      - Added firefox.svg to each branding directory from which all the other icons
      are derived (apart from document.icns and document.ico)
      - Added default256.png and default512.png icons
      - Updated aboutTBUpdate.css to point to branding-aware icon128.png and removed
      original icon
      - Use the Tor Browser icon within devtools/client/themes/images/.
      
      Bug 30631: Blurry Tor Browser icon on macOS app switcher
      
      It would seem the png2icns tool does not generate correct icns files and
      so on macOS the larger icons were missing resulting in blurry icons in
      the OS chrome. Regenerated the padded icons in a macOS VM using
      iconutil.
      
      Bug 28196: preparations for using torbutton tor-browser-brand.ftl
      
      A small change to Fluent FileSource class is required so that we
      can register a new source without its supported locales being
      counted as available locales for the browser.
      
      Bug 31803: Replaced about:debugging logo with flat version
      1d73f90a
    • Kathleen Brade's avatar
      Bug 13252: Do not store data in the app bundle · f798e224
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      When --enable-tor-browser-data-outside-app-dir is enabled,
      all user data is stored in a directory named
      TorBrowser-Data which is located next to the application directory.
      
      Display an informative error message if the TorBrowser-Data
      directory cannot be created due to an "access denied" or a
      "read only volume" error.
      
      On Mac OS, add support for the --invisible command line option which
      is used by the meek-http-helper to avoid showing an icon for the
      helper browser on the dock.
      f798e224
    • Kathleen Brade's avatar
      Bug 14631: Improve profile access error messages. · 803035d9
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Instead of always reporting that the profile is locked, display specific
      messages for "access denied" and "read-only file system".
      
      To allow for localization, get profile-related error strings from Torbutton.
      Use app display name ("Tor Browser") in profile-related error alerts.
      803035d9
    • Kathleen Brade's avatar
      Bug 9173: Change the default Firefox profile directory to be TBB-relative. · 748ca8d7
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      This should eliminate our need to rely on a wrapper script that
      sets /Users/arthur and launches Firefox with -profile.
      748ca8d7
    • Mike Perry's avatar
      Bug 13028: Prevent potential proxy bypass cases. · 6f5926b6
      Mike Perry authored and Matthew Finkel's avatar Matthew Finkel committed
      It looks like these cases should only be invoked in the NSS command line
      tools, and not the browser, but I decided to patch them anyway because there
      literally is a maze of network function pointers being passed around, and it's
      very hard to tell if some random code might not pass in the proper proxied
      versions of the networking code here by accident.
      6f5926b6
    • Kathleen Brade's avatar
      Bug 16439: Remove screencasting code · f21dd37d
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      We avoid including the screencasting code on mobile (it got ripped out
      for desktop in bug 1393582) by simply excluding the related JS modules
      from Tor Browser.
      f21dd37d
    • Mike Perry's avatar
      Bug 12974: Disable NTLM and Negotiate HTTP Auth · d85027a9
      Mike Perry authored and Matthew Finkel's avatar Matthew Finkel committed
      This is technically an embargoed Mozilla bug, so I probably shouldn't provide
      too many details.
      
      Suffice to say that NTLM and Negotiate auth are bad for Tor users, and I doubt
      very many (or any of them) actually need it.
      
      The Mozilla bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1046421
      d85027a9
    • Mike Perry's avatar
      Bug 3547: Block all plugins. · e23a9714
      Mike Perry authored and Matthew Finkel's avatar Matthew Finkel committed
      We cannot use the @mozilla.org/extensions/blocklist;1 service, because we
      actually want to stop plugins from ever entering the browser's process space
      and/or executing code (for example, AV plugins that collect statistics/analyse
      urls, magical toolbars that phone home or "help" the user, skype buttons that
      ruin our day, and censorship filters). Hence we rolled our own.
      
      See https://trac.torproject.org/projects/tor/ticket/3547#comment:6 for musings
      on a better way. Until then, it is delta-darwinism for us.
      e23a9714
    • Alex Catarineu's avatar
      Add TorStrings module for localization · 4ca5efac
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      4ca5efac
    • Alex Catarineu's avatar
      Bug 10760: Integrate TorButton to TorBrowser core · 0d118990
      Alex Catarineu authored and Matthew Finkel's avatar Matthew Finkel committed
      Because of the non-restartless nature of Torbutton, it required
      a two-stage installation process. On mobile, it was a problem,
      because it was not loading when the user opened the browser for
      the first time.
      
      Moving it to tor-browser and making it a system extension allows it
      to load when the user opens the browser for first time.
      
      Additionally, this patch also fixes Bug 27611.
      
      Bug 26321: New Circuit and New Identity menu items
      
      Bug 14392: Make about:tor behave like other initial pages.
      
      Bug 25013: Add torbutton as a tor-browser submodule
      0d118990
    • Kathleen Brade's avatar
      Bug 28044: Integrate Tor Launcher into tor-browser · 3935f960
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Build and package Tor Launcher as part of the browser (similar to
      how pdfjs is handled).
      
      If a Tor Launcher extension is present in the user's profile, it is
      removed.
      3935f960
    • Arthur Edelstein's avatar
      Bug 12620: TorBrowser regression tests · 4d2af2a5
      Arthur Edelstein authored and Matthew Finkel's avatar Matthew Finkel committed
      Regression tests for Bug #2950: Make Permissions Manager memory-only
      
      Regression tests for TB4: Tor Browser's Firefox preference overrides.
      
      Note: many more functional tests could be made here
      
      Regression tests for #2874: Block Components.interfaces from content
      
      Bug 18923: Add a script to run all Tor Browser specific tests
      
      Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
      4d2af2a5
    • Mike Perry's avatar
      TB4: Tor Browser's Firefox preference overrides. · 0098c38f
      Mike Perry authored and Matthew Finkel's avatar Matthew Finkel committed
      This hack directly includes our preference changes in omni.ja.
      
      Bug 18292: Staged updates fail on Windows
      
      Temporarily disable staged updates on Windows.
      
      Bug 18297: Use separate Noto JP,KR,SC,TC fonts
      
      Bug 23404: Add Noto Sans Buginese to the macOS whitelist
      
      Bug 23745: Set dom.indexedDB.enabled = true
      
      Bug 13575: Disable randomised Firefox HTTP cache decay user tests.
      (Fernando Fernandez Mancera <ffmancera@riseup.net>)
      
      Bug 17252: Enable session identifiers with FPI
      
      Session tickets and session identifiers were isolated
      by OriginAttributes, so we can re-enable them by
      allowing the default value (true) of
      "security.ssl.disable_session_identifiers".
      
      The pref "security.enable_tls_session_tickets" is obsolete
      (removed in https://bugzilla.mozilla.org/917049)
      
      Bug 14952: Enable http/2 and AltSvc
      
      In Firefox, SPDY/HTTP2 now uses Origin Attributes for
      isolation of connections, push streams, origin frames, etc.
      That means we get first-party isolation provided
      "pr...
      0098c38f