1. 06 Dec, 2020 1 commit
  2. 30 Mar, 2019 1 commit
  3. 06 Jan, 2019 1 commit
  4. 03 Dec, 2018 3 commits
  5. 11 Nov, 2018 1 commit
  6. 10 Nov, 2018 2 commits
  7. 07 Nov, 2018 1 commit
  8. 09 Sep, 2018 1 commit
  9. 28 Aug, 2018 1 commit
  10. 19 Jul, 2018 1 commit
  11. 09 Jul, 2018 1 commit
  12. 27 Jun, 2018 1 commit
  13. 06 Jun, 2018 1 commit
    • Emilio Cobos Álvarez's avatar
      Bug 1466645: Remove PropertyId::name. r=xidorn · 27fa0a2a
      Emilio Cobos Álvarez authored
      It's only used for the error path in property parsing, so most of the time is
      not useful.
      
      Use the just-introduced NonCustomPropertyId::name to preserve the alias name,
      which we were doing by passing the name around.
      
      MozReview-Commit-ID: 46xxZKCoeBB
      27fa0a2a
  14. 21 Jun, 2018 1 commit
    • Emilio Cobos Álvarez's avatar
      Bug 1469957: Move the error reporter into ParserContext. r=xidorn · 621ad140
      Emilio Cobos Álvarez authored
      Summary:
      This should make it easier to report errors, and also reduce codesize.
      
      The reason this was so generic is that error reporting was unconditionally
      enabled and was super-hot, but now that's no longer the case after bug 1452143,
      so we can afford the virtual call in the "error reporting enabled" case.
      
      This opens the possibility of simplifying a lot the error setup as well, though
      this patch doesn't do it.
      
      Test Plan: No behavior change, so no new tests.
      
      Reviewers: xidorn
      
      Bug #: 1469957
      
      Differential Revision: https://phabricator.services.mozilla.com/D1734
      
      MozReview-Commit-ID: F3wTdhX9MB5
      621ad140
  15. 01 Jun, 2018 1 commit
  16. 05 May, 2018 1 commit
  17. 11 Apr, 2018 1 commit
    • Bobby Holley's avatar
      servo: Merge #20603 - Run rustfmt on selectors, servo_arc, and style (from... · b515de0c
      Bobby Holley authored
      servo: Merge #20603 - Run rustfmt on selectors, servo_arc, and style (from bholley:rustfmt_style); r=Manishearth
      
      Now that rustfmt is getting close to stable, and work on the style system has died down a bit, it seemed like an opportune time to auto-format the style crates.
      
      The first commit disables import reordering, since tidy and rustfmt don't currently agree on the correct ordering. The second commit does a bunch of manual fixups such that the output of rustfmt passes tidy. The third commit runs rustfmt on the three aforementioned crate.
      
      There are a few dozen warnings in the style crate about lines longer than 100 characters. It would be good to fix these, but I don't have time for that now.
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 9a900ef019cd643bff961d7b20db6da69f3edb29
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 2b228d52a084bc832444ac686290840c4369f98d
      b515de0c
  18. 11 Mar, 2018 1 commit
    • Florian Wagner's avatar
      servo: Merge #20185 - Make KeyframesPercentage::parse faster (from Beta-Alf:master); r=emilio · 22de4016
      Florian Wagner authored
      Minor refactoring of the parsing of keyframes.
      
      ---
      <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
      - [X] `./mach build -d` does not report any errors
      - [X] `./mach test-tidy` does not report any errors
      - [X] These changes fix  #20179 (github issue number if applicable).
      
      <!-- Either: -->
      - [ ] There are tests for these changes OR
      - [X] These changes do not require tests because it is a minor refactor so tests are already in place. The original Issue explicitly says so.
      
      <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
      
      <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 29e10d4f88a7564f4d6a4496d3d1be5949962f8a
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : cf1ac3eb68cdf37d44f5c1e0a9e478f2a23bc3d8
      22de4016
  19. 06 Mar, 2018 1 commit
  20. 03 Mar, 2018 1 commit
  21. 23 Jan, 2018 1 commit
  22. 21 Nov, 2017 1 commit
    • Emilio Cobos Álvarez's avatar
      servo: Merge #19317 - style: Move property allowance tests to... · 9f3b446b
      Emilio Cobos Álvarez authored
      servo: Merge #19317 - style: Move property allowance tests to PropertyId::parse_into (from emilio:property-allowed-in); r=SimonSapin
      
      It's not only more consistent (since we have a proper ParserContext there), but
      also fixes a bunch of bugs where Gecko accidentally exposes and allows setting
      internal state because of conversions from nsCSSPropertyID to PropertyId.
      
      This adds the extra complexity of caring about aliases for longer, but that's
      probably not a big deal in practice, since we have PropertyDeclarationId.
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 3864f320e8c6ff707d5b11fe46d67c0677cd112a
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 41922d46e6c30b5ec9f5adebceac0978ab35b6e0
      9f3b446b
  23. 30 Oct, 2017 1 commit
  24. 18 Oct, 2017 1 commit
    • Nicholas Nethercote's avatar
      servo: Merge #18938 - Replace all uses of the `heapsize` crate with... · 5a629429
      Nicholas Nethercote authored
      servo: Merge #18938 - Replace all uses of the `heapsize` crate with `malloc_size_of` (from nnethercote:bug-1409255); r=SimonSapin
      
      Servo currently uses `heapsize`, but Stylo/Gecko use `malloc_size_of`.
      `malloc_size_of` is better -- it handles various cases that `heapsize` does not
      -- so this patch changes Servo to use `malloc_size_of`.
      
      This patch makes the following changes to the `malloc_size_of` crate.
      
      - Adds `MallocSizeOf` trait implementations for numerous types, some built-in
        (e.g. `VecDeque`), some external and Servo-only (e.g. `string_cache`).
      
      - Makes `enclosing_size_of_op` optional, because vanilla jemalloc doesn't
        support that operation.
      
      - For `HashSet`/`HashMap`, falls back to a computed estimate when
        `enclosing_size_of_op` isn't available.
      
      - Adds an extern "C" `malloc_size_of` function that does the actual heap
        measurement; this is based on the same functions from the `heapsize` crate.
      
      This patch makes the following changes elsewhere.
      
      - Converts all the uses of `heapsize` to instead use `malloc_size_of`.
      
      - Disables the "heapsize"/"heap_size" feature for the external crates that
        provide it.
      
      - Removes the `HeapSizeOf` implementation from `hashglobe`.
      
      - Adds `ignore` annotations to a few `Rc`/`Arc`, because `malloc_size_of`
        doesn't derive those types, unlike `heapsize`.
      
      <!-- Please describe your changes on the following line: -->
      
      ---
      <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
      - [X] `./mach build -d` does not report any errors
      - [X] `./mach test-tidy` does not report any errors
      - [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1409255
      
      <!-- Either: -->
      - [ ] There are tests for these changes OR
      - [ ] These changes do not require tests because testing is on the Gecko side.
      
      <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
      
      <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 4c538b642e4bdfbf42c522c5a59c258a6d14546e
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : f9a6feed1088d0b0be2b55d7f0c2ec9c594ac33b
      5a629429
  25. 14 Oct, 2017 1 commit
  26. 10 Oct, 2017 1 commit
  27. 29 Sep, 2017 1 commit
    • Emilio Cobos Álvarez's avatar
      servo: Merge #18604 - style: Cleanup the animated value setup (from... · 8562ff5f
      Emilio Cobos Álvarez authored
      servo: Merge #18604 - style: Cleanup the animated value setup (from emilio:animated-value-cleanup); r=nox
      
      We have three different enums to represent slightly different things. Reuse them
      properly, and kill some code in the animated_properties module while at it.
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 9ffd2b8c9e2b897f12daa5eac48a76a0c10c60c9
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : dd97b322e75cdcdf26f991e11da85056aad56cc6
      8562ff5f
  28. 11 Sep, 2017 1 commit
  29. 12 Sep, 2017 2 commits
    • Nicholas Nethercote's avatar
      servo: Merge #18452 - Overhaul MallocSizeOf and related things (from... · 43983aa5
      Nicholas Nethercote authored
      servo: Merge #18452 - Overhaul MallocSizeOf and related things (from nnethercote:bug-1398737); r=jdm
      
      This patch makes the MallocSizeOf stuff in Stylo work more like the HeapSizeOf
      stuff already in Servo, except better. In particular, it adds deriving support
      for MallocSizeOf, which will make it easier to improve coverage.
      
      The patch does the following.
      
      - Combines servo/components/style/stylesheets/memory.rs and the heapsize crate
        into a new crate, malloc_size_of.
      
      - Forks the heapsize_derive crate, calling it malloc_size_of, so that
        MallocSizeOf can be derived.
      
      - Both the new crates have MIT/Apache licenses, like heapsize, in case they are
        incorporated into heapsize in the future.
      
      - Renames the methods within MallocSizeOf and the related traits so they are
        more concise.
      
      - Removes MallocSizeOfWithGuard.
      
      - Adds `derive(MallocSizeOf)` to a lot of types, in some cases replacing an
        equivalent or almost-equivalent hand-written implementation.
      
      - Adds stuff so that Rc/Arc can be handled properly.
      
      <!-- Please describe your changes on the following line: -->
      
      ---
      <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
      - [X] `./mach build -d` does not report any errors
      - [X] `./mach test-tidy` does not report any errors
      - [ ] These changes fix #__ (github issue number if applicable).
      
      <!-- Either: -->
      - [ ] There are tests for these changes OR
      - [X] These changes do not require tests because tested on Gecko side.
      
      <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
      
      <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 7f4cb1861b172423781a369b2decca6c65d60546
      
      --HG--
      rename : servo/components/hashglobe/LICENSE-APACHE => servo/components/malloc_size_of/LICENSE-APACHE
      rename : servo/components/hashglobe/LICENSE-MIT => servo/components/malloc_size_of/LICENSE-MIT
      rename : servo/components/jstraceable_derive/Cargo.toml => servo/components/malloc_size_of_derive/Cargo.toml
      rename : servo/components/hashglobe/LICENSE-APACHE => servo/components/malloc_size_of_derive/LICENSE-APACHE
      rename : servo/components/hashglobe/LICENSE-MIT => servo/components/malloc_size_of_derive/LICENSE-MIT
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : a8254c4ae15901b764d918355e900a1e74d6eb03
      43983aa5
    • Tom Tromey's avatar
      servo: Merge #18449 - Remove get_location_with_offset (from... · eb5a0d0b
      Tom Tromey authored
      servo: Merge #18449 - Remove get_location_with_offset (from tromey:remove-get_location_with_offset); r=jdm
      
      Now that rust-cssparser reports 1-based locations, bump the required
      cssparser version and remove get_location_with_offset.  Previously,
      some code paths were not calling get_location_with_offset; see
      https://bugzilla.mozilla.org/show_bug.cgi?id=1398869 for some
      background.
      
      ---
      <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
      - [x] `./mach build -d` does not report any errors
      - [x] `./mach test-tidy` does not report any errors
      - [x] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1398869 (github issue number if applicable).
      
      <!-- Either: -->
      - [ ] There are tests for these changes OR
      - [x] These changes do not require tests because tests are in rust-cssparser and/or M-C
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 7746896bc4cf5a2a6dc78c00f643e4cff8e49da4
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 919aeee03abfd07cd5dbcc9d478dd98cc76f054e
      eb5a0d0b
  30. 01 Sep, 2017 1 commit
    • Xidorn Quan's avatar
      servo: Merge #18336 - Parse at-rule without block in two stages (from... · 08057f5e
      Xidorn Quan authored
      servo: Merge #18336 - Parse at-rule without block in two stages (from upsuper:two-stage-at-rule); r=SimonSapin
      
      This is the Servo side change necessary for servo/rust-cssparser#180.
      
      ----
      
      This also pulls in other changes from cssparser 0.20.0.
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: f2e5b4992658db504db0f6176d3bfa580ced6fd0
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 9c1767c636a6585ed1d552ae8c26376547d2f2fc
      08057f5e
  31. 04 Sep, 2017 1 commit
    • Simon Sapin's avatar
      servo: Merge #18355 - Reduce usage of fmt in serialization and error reporting... · c9fdb7e6
      Simon Sapin authored
      servo: Merge #18355 - Reduce usage of fmt in serialization and error reporting (from servo:no-fmt); r=emilio
      
      `format!` and `write!` create a somewhat-heavyweight `Formatting` struct and use dynamic dispatch to call into impls of `Dispaly` and related traits. The former also allocates an intermediate string that is sometimes unnecessary.
      
      I started looking into this from https://bugzilla.mozilla.org/show_bug.cgi?id=1355599, but I expect the impact there will be small to insignificant. It might be a slightly less so on parsing (error reporting).
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: c60dd53210745d9d8e7d3a5ca0310370a33553f4
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : d58ba91509b981489459b891f7632d035a43a7de
      c9fdb7e6
  32. 05 Sep, 2017 1 commit
    • Jeremy Chen's avatar
      servo: Merge #18365 - stylo: Store location information for keyframe rules... · 7cc52b70
      Jeremy Chen authored
      servo: Merge #18365 - stylo: Store location information for keyframe rules (from chenpighead:stylo-keyframe-location); r=upsuper,emilio
      
      So far, we only store location info for the whole Keyframes block, not for each
      of the keyframe rule. Without this info, the devtool can't present the rules
      on the devtool panel properly.
      
      In this patch, we collect the source location info while parsing keyframe selector.
      The binding function, Servo_KeyframesRule_GetKeyframe, is also fixed (and renamed
      to Servo_KeyframesRule_GetKeyframeAt to match the fix) to accept line and column
      parameters from Gecko, so we can pass/set them with the source location from Servo.
      
      This is the servo part of [Bug 1394994](https://bugzilla.mozilla.org/show_bug.cgi?id=1394994).
      
      - [X] `./mach build -d` does not report any errors
      - [X] `./mach test-tidy` does not report any errors
      - [X] These changes fix [Bug 1394994](https://bugzilla.mozilla.org/show_bug.cgi?id=1394994)
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: f648e12935cb94405a815216391f2527912ba4c2
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 17bc4073e4d17b26e9d8c07a8ed4b996cfe1612f
      7cc52b70
  33. 24 Aug, 2017 1 commit
  34. 23 Aug, 2017 1 commit
    • Clément DAVID's avatar
      servo: Merge #18179 - Automatically verify that derive() lists are... · 14926dcf
      Clément DAVID authored
      servo: Merge #18179 - Automatically verify that derive() lists are alphabetically ordered #… (from davidcl:master); r=jdm
      
      <!-- Please describe your changes on the following line: -->
      Automatically verify that derive() lists are alphabetically ordered #18172
      
      ---
      <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
      - [X] `./mach build -d` does not report any errors
      - [X] `./mach test-tidy` does not report any errors
      - [X] These changes fix #18172 (github issue number if applicable).
      
      <!-- Either: -->
      - [X] There are tests for these changes OR
      - [ ] These changes do not require tests because _____
      
      <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
      
      <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
      
      Source-Repo: https://github.com/servo/servo
      Source-Revision: 474369618965569407d127b1e8c481e757cc59d3
      
      --HG--
      extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
      extra : subtree_revision : 421aa68def8e17f70580477a4203494db3b69382
      14926dcf
  35. 05 Sep, 2017 1 commit
  36. 19 Oct, 2017 1 commit