1. 02 Sep, 2020 2 commits
    • Nicolas Chevobbe's avatar
      Bug 1660466 - Fix attaching target/thread test intermittents. r=jdescottes, a=RyanVM · 7c81f0a2
      Nicolas Chevobbe authored
      Move the function taking care of closing the Browser Console to shared-head so
      we can close it before closing the tabs opened during the test.
      
      While attaching the worker, check that the Worker Debugger isn't closed, and
      if it is, reject the promise. On the target list, catch rejection while attaching
      and simply bail out so we don't call the rest of the code in onTargetAvailable.
      
      Those guards are not enough to prevent any failure while attaching, so we're
      wrapping calls to `attachAndInitThread`/`_onThreadInitialized` in try/catch
      blocks to avoid test failures.
      
      Differential Revision: https://phabricator.services.mozilla.com/D88766
      7c81f0a2
    • Nicolas Chevobbe's avatar
      Bug 1662054 - Add a destroy function to targetList. r=jdescottes, a=RyanVM · 1a982041
      Nicolas Chevobbe authored
      At the moment, we don't have any guards in the targetList to _not_ execute the
      creation/destruction listeners once the toolbox gets destroyed.
      We only have a stopListening function on the targetList that is called when we
      close the toolbox, but we can't rely only on that since it's also called when
      doing a target switch (and working around that is very racy).
      
      One solution would be to follow the common pattern we have everywhere by having
      a destroy method that we would check before trying to call the listeners callback.
      
      This might help with intermittent test failures.
      
      Differential Revision: https://phabricator.services.mozilla.com/D88765
      1a982041
  2. 07 Sep, 2020 1 commit
  3. 08 Sep, 2020 10 commits
  4. 07 Sep, 2020 12 commits
  5. 06 Sep, 2020 10 commits
  6. 31 Aug, 2020 1 commit
  7. 04 Sep, 2020 2 commits
  8. 03 Sep, 2020 2 commits