GitLab

Alex Catarineu authored Sep 04, 2020 and Matthew Finkel committed Jan 15, 2021

This loads HTTPS Everywhere as a builtin addon from a hardcoded
resource:// URI in desktop. It also ensures that the non-builtin
HTTPS Everywhere addon is always uninstalled on browser startup.

The reason of making this desktop-only is that there are some issues
when installing a builtin extension from geckoview side, making
the extension not available on first startup. So, at least for
now we handle the Fenix case separately. See #40118 for a followup
for investigating these.

Alex Catarineu authored Aug 13, 2020 and Matthew Finkel committed Jan 15, 2021

In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
fetching the Public Suffix List via RemoteSettings and replacing the default
one at runtime, which we do not want.

Alex Catarineu authored Mar 05, 2020 and Matthew Finkel committed Jan 15, 2021

Whenever a valid Onion-Location HTTP header (or corresponding HTML
<meta> http-equiv attribute) is found in a document load, we either
redirect to it (if the user opted-in via preference) or notify the
presence of an onionsite alternative with a badge in the urlbar.

Alex Catarineu authored Feb 13, 2020 and Matthew Finkel committed Jan 15, 2021

A custom HTTPS Everywhere update channel is installed,
which provides rules for locally redirecting some memorable
.tor.onion URLs to non-memorable .onion URLs.

When these redirects occur, we also rewrite the URL in the urlbar
to display the human-memorable hostname instead of the actual
.onion.

Bug 34196: Update site info URL with the onion name

Alex Catarineu authored May 29, 2019 and Matthew Finkel committed Jan 15, 2021

Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"

This reverts commit f7ffd78b.

Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"

This reverts commit 057fe36f.

Bug 28822: Convert onboarding to webextension

Partially revert 1564367 (controlCenter in UITour.jsm)

Alex Catarineu authored Sep 09, 2019 and Matthew Finkel committed Jan 15, 2021

Avoid loading AboutNewTab in BrowserGlue.jsm in order
to avoid several network requests that we do not need. Besides,
about:newtab will now point to about:blank or about:tor (depending
on browser.newtabpage.enabled) and about:home will point to
about:tor.

Kathleen Brade authored May 23, 2017 and Matthew Finkel committed Jan 15, 2021

Only ship the pdfjs extension.

Kathleen Brade authored Nov 25, 2015 and Matthew Finkel committed Jan 15, 2021

Add an about:tbupdate page that displays the first section from
TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
post-update page (typically our blog entry for the release).

Always load about:tbupdate in a content process, but implement the
code that reads the file system (changelog) in the chrome process
for compatibility with future sandboxing efforts.

Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
changelog page that is designed to be displayed via a link that is on
about:tor.

Bug 1682553 - Move bookmarks listeners to PlacesUIUtils so there will only be one listener instead of one per window. r=Gijs, a=jcristau

Differential Revision: https://phabricator.services.mozilla.com/D99923

Bug 1681382 - Drop BrowserSearch.record*SearchInTelemetry and call BrowserSearchTelemetry direct. r=daleharvey

Depends on D99206

Differential Revision: https://phabricator.services.mozilla.com/D99207

Differential Revision: https://phabricator.services.mozilla.com/D98740

Differential Revision: https://phabricator.services.mozilla.com/D98791

For debug builds, it seems we'd unexpectedly hit the AboutHomeStartupCache shutdown
timer when simulating shutdowns, which would put the cache entry into a half-written
state that risked confusing later tests.

This patch now makes sure that only tests that exercise/expect the timeout will hit it.
We also make sure to clear the cache of any half-written state after the
browser_shutdown_timeout.js test runs.

Differential Revision: https://phabricator.services.mozilla.com/D98828

Bug 1680274 - enabling the experiment pref during first startup should show the import button in the toolbar, r=jaws a=RyanVM

This allows the pref to cause us to add the button later during the uptime of the first run. Note that this
would still require us to apply the experimental pref during the first run - it won't work if the experiment
only applies on the next run - the only way to do that would be to save even more state in a pref or similar,
and that didn't seem worth it.

Differential Revision: https://phabricator.services.mozilla.com/D98606

Differential Revision: https://phabricator.services.mozilla.com/D98526

Bug 1673716 - Move the AboutHomeStartupCache shutdown blocker timeout to the onShutdown method. r=emalysz

In an earlier attempt to fix this shutdown hang, a timeout was added to the cacheNow
task function to try to have a maximum of 1s of wait time during the shutdown blocker
before giving up and letting the shutdown proceed.

This didn't seem to put a dent in the shutdown hangs. It looks like DeferredTasks
that are being finalized don't actually re-enter the task if the task was already
running, which might explain why in some cases the timeout wasn't being hit. This
patch makes sure that the timeout is being used regardless of whether or not the
cache task is already underway.

Differential Revision: https://phabricator.services.mozilla.com/D98688

Differential Revision: https://phabricator.services.mozilla.com/D96479

Differential Revision: https://phabricator.services.mozilla.com/D95206

This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500

Backed out 4 changesets (bug 1425290, bug 1432604, bug 16653896) for bc failures on browser_bookmarkProperties_addKeywordForThisSearch.js . CLOSED TREE

Backed out changeset 455ff5647429 (bug 1432604)
Backed out changeset cf70da964b70 (bug 1425290)
Backed out changeset e6b38d403cc3 (bug 1425290)
Backed out changeset 09f049232773 (bug 16653896)

This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500

Bug 1674185 - Remove managed-bookmarks from uiCustomization.state now that it is dynamic. r=Gijs, a=pascal

Bug 1665938 - Add telemetry to report if a WebExtension engine is saved in the search settings but not in the add-on manager. r=daleharvey

Differential Revision: https://phabricator.services.mozilla.com/D91920

Backed out 2 changesets (bug 1665938, bug 1671404) for causing browser_urlbar_event_telemetry failures. CLOSED TREE

Backed out changeset ce37b9b99fd6 (bug 1665938)
Backed out changeset fa95a02b2c90 (bug 1671404)

Bug 1665938 - Add telemetry to report if a WebExtension engine is saved in the search settings but not in the add-on manager. r=daleharvey

Differential Revision: https://phabricator.services.mozilla.com/D91920

Bug 1667454 - part2 : add telemetry probe to record the number of times a user changes media control setting. r=preferences-reviewers,mossop,Gijs

Differential Revision: https://phabricator.services.mozilla.com/D92872

Backed out 4 changesets (bug 1667454, bug 1668139) for perma failures on browser_media_control.js. CLOSED TREE

Backed out changeset 302032fe6d64 (bug 1668139)
Backed out changeset 859ee72e9e57 (bug 1668139)
Backed out changeset fe7de882fcbf (bug 1667454)
Backed out changeset dfd0308f5ab7 (bug 1667454)

Bug 1667454 - part2 : add telemetry probe to record the number of times a user changes media control setting. r=preferences-reviewers,mossop,Gijs

Differential Revision: https://phabricator.services.mozilla.com/D92872

I missed to add this change on the last update, but the test change did
land.

Seems similar to the modified preferences so remove them for now as
well...

Differential Revision: https://phabricator.services.mozilla.com/D93212

Differential Revision: https://phabricator.services.mozilla.com/D91441

Bug 1668507 - Add back accidentally removed call to show the modal dialog when the notificationbar is disabled. r=Gijs, a=jcristau

Differential Revision: https://phabricator.services.mozilla.com/D92134

Bug 1668782 - Reset security.tls.version.enable-deprecated pref to retrigger override prompt and gather fresh telemetry. r=keeler,Gijs

Differential Revision: https://phabricator.services.mozilla.com/D92281

Differential Revision: https://phabricator.services.mozilla.com/D90749

Bug 1669230 - [remote] Remove --remote-debugger command line argument. r=remote-protocol-reviewers,jgraham

Using different names for enabling the remote agent via
--remote-debugger and --remote-debugging-port adds confusion
to users. Also given that --remote-debugging is actually
not used by any client library including Puppeteer,
it can be removed.

Using --remote-debugging-port instead will bring us onpar
with Chrome and how it enables CDP.

Differential Revision: https://phabricator.services.mozilla.com/D92603

Bug 1664874 - Call DoHController.init from _onFirstWindowLoaded instead of _onWindowsRestored r=nhnt11

Depends on D92431

Differential Revision: https://phabricator.services.mozilla.com/D92447

Backed out changeset 4e240b88ba93 (bug 1666575) for bc failure on browser_pdfjs_find_not_default.js CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D91441

Bug 1668507 - Add back accidentally removed call to show the modal dialog when the notificationbar is disabled. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D92134

Differential Revision: https://phabricator.services.mozilla.com/D98526