1. 17 Mar, 2021 1 commit
    • Kathleen Brade's avatar
      Bug 31607: App menu items stop working on macOS · 9b050342
      Kathleen Brade authored and Matthew Finkel's avatar Matthew Finkel committed
      Avoid re-creating the hidden window, since this causes the nsMenuBarX
      object that is associated with the app menu to be freed (which in
      turn causes all of the app menu items to stop working).
      
      More detail: There should only be one hidden window.
      XREMain::XRE_mainRun() contains an explicit call to create the
      hidden window and that is the normal path by which it is created.
      However, when Tor Launcher's wizard/progress window is opened during
      startup, a hidden window is created earlier as a side effect of
      calls to nsAppShellService::GetHiddenWindow(). Then, when
      XREMain::XRE_mainRun() creates its hidden window, the original one
      is freed which also causes the app menu's nsMenuBarX object which
      is associated with that window to be destroyed. When that happens,
      the menuGroupOwner property within each Cocoa menu items's MenuItemInfo
      object is cleared. This breaks the link that is necessary for
      NativeMenuItemTarget's menuItemHit method to dispatch a menu item
      event.
      9b050342
  2. 05 Jun, 2020 1 commit
  3. 08 May, 2020 1 commit
  4. 07 May, 2020 3 commits
  5. 06 May, 2020 2 commits
  6. 24 Apr, 2020 1 commit
  7. 23 Apr, 2020 1 commit
  8. 22 Apr, 2020 6 commits
  9. 24 Apr, 2020 1 commit
  10. 15 Apr, 2020 1 commit
  11. 07 Apr, 2020 3 commits
  12. 06 Apr, 2020 4 commits
    • Cosmin Sabou's avatar
      Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp. · aefb5f9c
      Cosmin Sabou authored
      Backed out changeset 3a43210e4900 (bug 1616353)
      Backed out changeset cb77e9149cf8 (bug 1616353)
      Backed out changeset 3aacc7cfe33f (bug 1616353)
      Backed out changeset c026b06063a5 (bug 1616353)
      Backed out changeset 580e790c5d17 (bug 1616353)
      Backed out changeset 6f09bc1c476d (bug 1616353)
      Backed out changeset 6955906262c0 (bug 1616353)
      Backed out changeset a7700472807a (bug 1616353)
      Backed out changeset a4735096e01b (bug 1616353)
      Backed out changeset bd1706c57d91 (bug 1616353)
      Backed out changeset 363c13296fda (bug 1616353)
      Backed out changeset e414df387524 (bug 1616353)
      Backed out changeset 765d3364cca0 (bug 1616353)
      Backed out changeset 8a13355b4ac4 (bug 1616353)
      Backed out changeset ada17fb8fca7 (bug 1616353)
      Backed out changeset 6b6b99af186d (bug 1616353)
      Backed out changeset ea966e78b296 (bug 1616353)
      Backed out changeset cb88e0bbb3b9 (bug 1616353)
      Backed out changeset f89a89015114 (bug 1616353)
      Backed out changeset ae6058552969 (bug 1616353)
      Backed out changeset f42bb5b48c1b (bug 1616353)
      Backed out changeset 1ab9d22c73bb (bug 1616353)
      Backed out changeset 2692c2c1396b (bug 1616353)
      Backed out changeset 11a279c8da08 (bug 1616353)
      aefb5f9c
    • Nika Layzell's avatar
      Bug 1616353 - Part 7.2: Create and use nsOpenWindowInfo types in nsWindowWatcher logic, r=kmag · 0d1eecbd
      Nika Layzell authored
      This patch builds on top of part 7.1 by creating this object within
      nsWindowWatcher and ContentParent to carry the relevant information through
      provider interfaces when creating new content windows. The nsOpenWindowInfo
      object is not created for new chrome windows.
      
      This patch does not propagate these flags all of the way through to the
      nsFrameLoader. That change is performed in later parts to keep each part
      smaller.
      
      Differential Revision: https://phabricator.services.mozilla.com/D67051
      
      --HG--
      extra : moz-landing-system : lando
      0d1eecbd
    • Nika Layzell's avatar
      Bug 1616353 - Part 6.4: Delay loading chrome window URIs until docshell has... · cf8902e5
      Nika Layzell authored
      Bug 1616353 - Part 6.4: Delay loading chrome window URIs until docshell has been configured, r=smaug
      
      Previously, a load of the URI within a chrome docshell would start before the
      chrome docshell has had a chance to be configured. This could cause problems, as
      the load would be configured incorrectly.
      
      After these changes, starting the load is delayed until after nsILoadContext
      configuration is complete.
      
      Differential Revision: https://phabricator.services.mozilla.com/D67048
      
      --HG--
      extra : moz-landing-system : lando
      cf8902e5
    • Nika Layzell's avatar
      Bug 1616353 - Part 4: Don't second-guess CHROME_{REMOTE,FISSION}_WINDOW flags, r=kmag · 45946074
      Nika Layzell authored
      This could cause issues, as we could incorrectly override the decision made by
      nsWindowWatcher, and then override the decision again after the method returns.
      This could cause the initial content browser to be configured incorrectly.
      
      Differential Revision: https://phabricator.services.mozilla.com/D67043
      
      --HG--
      extra : moz-landing-system : lando
      45946074
  13. 06 Feb, 2020 2 commits
  14. 06 Dec, 2019 1 commit
    • Gabriele Svelto's avatar
      Bug 1600545 - Remove useless inclusions of header files generated from IDL... · 5dc21d56
      Gabriele Svelto authored
      Bug 1600545 - Remove useless inclusions of header files generated from IDL files in modules/, netwerk/, parser/, security/, startupcache/, storage/, toolkit/, tools/, uriloader/, widget/, xpcom/ and xpfe/ r=Ehsan
      
      The inclusions were removed with the following very crude script and the
      resulting breakage was fixed up by hand. The manual fixups did either
      revert the changes done by the script, replace a generic header with a more
      specific one or replace a header with a forward declaration.
      
      find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
          interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
          if [ -n "$interfaces" ]; then
              if [[ "$interfaces" == *$'\n'* ]]; then
                regexp="\("
                for i in $interfaces; do regexp="$regexp$i\|"; done
                regexp="${regexp%%\\\|}\)"
              else
                regexp="$interfaces"
              fi
              interface=$(basename "$path")
              rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
                  hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
                  if [ $hits -eq 0 ]; then
                      echo "Removing ${interface} from ${path2}"
                      grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                      mv -f "$path2".tmp "$path2"
                  fi
              done
          fi
      done
      
      Differential Revision: https://phabricator.services.mozilla.com/D55444
      
      --HG--
      extra : moz-landing-system : lando
      5dc21d56
  15. 05 Dec, 2019 1 commit
  16. 04 Dec, 2019 1 commit
  17. 24 Nov, 2019 3 commits
  18. 05 Nov, 2019 3 commits
  19. 04 Nov, 2019 4 commits